From: John Baldwin <jhb@freebsd.org>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org,
freebsd-current@freebsd.org, kib@freebsd.org,
xen-devel@lists.xenproject.org, gibbs@freebsd.org
Subject: Re: [PATCH RFC 07/13] xen: implement IO APIC support in Xen mptable parser
Date: Sat, 08 Feb 2014 16:36:11 -0500 [thread overview]
Message-ID: <11166680.j6yj7PCWSG__45766.868760302$1392323212$gmane$org@ralph.baldwin.cx> (raw)
In-Reply-To: <1387884062-41154-8-git-send-email-roger.pau@citrix.com>
On Tuesday, December 24, 2013 12:20:56 PM Roger Pau Monne wrote:
> Use madt_setup_io (from madt.c) on Xen apic_enumerator, in order to
> parse the interrupt sources from the IO APIC.
>
> I would like to get opinions, but I think we should rename and move
> madt_setup_io to io_apic.c.
It wouldn't be appropriate for io_apic.c as it isn't generic to I/O
APICs but is specific to ACPI. However, mptable.c is really not a
great name for this file in sys/x86/xen. I wonder if it should be
xen_apic.c instead? Also, if Xen PV has an MADT table, why do you
need a custom APIC enumerator at all? That is, what is preventing
the code in madt.c from just working? Do you just not have
'device acpi' in the kernel config you are using?
--
John Baldwin
next prev parent reply other threads:[~2014-02-13 20:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1387884062-41154-1-git-send-email-roger.pau@citrix.com>
2013-12-24 11:20 ` [PATCH RFC 01/13] xen: use the hardware e820 map on Dom0 Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 02/13] ioapic: introduce hooks for some ioapic ops Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 03/13] xen: mask event channels while changing affinity Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 04/13] xen: implement basic PIRQ support for Dom0 Roger Pau Monne
2014-01-21 18:52 ` John Baldwin
2013-12-24 11:20 ` [PATCH RFC 05/13] xen: implement Xen IO APIC ops Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 06/13] xen: Dom0 console fixes Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 07/13] xen: implement IO APIC support in Xen mptable parser Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 08/13] xen: change order of Xen intr init and IO APIC registration Roger Pau Monne
2013-12-24 11:20 ` [PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator Roger Pau Monne
2014-02-08 21:42 ` John Baldwin
[not found] ` <1980951.95r2q2cca3@ralph.baldwin.cx>
2014-02-14 1:49 ` Andrew Cooper
[not found] ` <52FD7624.90202@citrix.com>
2014-02-14 17:51 ` John Baldwin
[not found] ` <201402141251.10278.jhb@freebsd.org>
2014-02-17 16:01 ` Roger Pau Monné
2013-12-24 11:20 ` [PATCH RFC 10/13] xen: add ACPI bus to xen_nexus when running as Dom0 Roger Pau Monne
2013-12-24 11:21 ` [PATCH RFC 11/13] pci: introduce a new event on PCI device detection Roger Pau Monne
2013-12-24 11:21 ` [PATCH RFC 12/13] mca: disable cmc enable on Xen PV Roger Pau Monne
2013-12-24 11:21 ` [PATCH RFC 13/13] xenstore: changes needed to boot in Dom0 mode Roger Pau Monne
[not found] ` <1387884062-41154-4-git-send-email-roger.pau@citrix.com>
2014-01-03 20:45 ` [PATCH RFC 03/13] xen: mask event channels while changing affinity Konrad Rzeszutek Wilk
[not found] ` <1387884062-41154-2-git-send-email-roger.pau@citrix.com>
2014-01-21 18:25 ` [PATCH RFC 01/13] xen: use the hardware e820 map on Dom0 John Baldwin
[not found] ` <1387884062-41154-3-git-send-email-roger.pau@citrix.com>
2014-01-21 18:27 ` [PATCH RFC 02/13] ioapic: introduce hooks for some ioapic ops John Baldwin
[not found] ` <1387884062-41154-6-git-send-email-roger.pau@citrix.com>
2014-01-21 18:55 ` [PATCH RFC 05/13] xen: implement Xen IO APIC ops John Baldwin
[not found] ` <1387884062-41154-7-git-send-email-roger.pau@citrix.com>
2014-01-21 19:02 ` [PATCH RFC 06/13] xen: Dom0 console fixes John Baldwin
[not found] ` <1387884062-41154-8-git-send-email-roger.pau@citrix.com>
2014-02-08 21:36 ` John Baldwin [this message]
[not found] ` <1387884062-41154-9-git-send-email-roger.pau@citrix.com>
2014-02-08 21:37 ` [PATCH RFC 08/13] xen: change order of Xen intr init and IO APIC registration John Baldwin
[not found] ` <1387884062-41154-11-git-send-email-roger.pau@citrix.com>
2014-02-08 21:50 ` [PATCH RFC 10/13] xen: add ACPI bus to xen_nexus when running as Dom0 John Baldwin
[not found] ` <2410827.IqfpSAhe3T@ralph.baldwin.cx>
2014-02-14 10:38 ` Roger Pau Monné
[not found] ` <52FDF217.3040005@citrix.com>
2014-02-14 17:50 ` John Baldwin
[not found] ` <1387884062-41154-12-git-send-email-roger.pau@citrix.com>
2014-02-08 21:57 ` [PATCH RFC 11/13] pci: introduce a new event on PCI device detection John Baldwin
[not found] ` <1387884062-41154-13-git-send-email-roger.pau@citrix.com>
2014-02-08 22:02 ` [PATCH RFC 12/13] mca: disable cmc enable on Xen PV John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='11166680.j6yj7PCWSG__45766.868760302$1392323212$gmane$org@ralph.baldwin.cx' \
--to=jhb@freebsd.org \
--cc=freebsd-current@freebsd.org \
--cc=freebsd-xen@freebsd.org \
--cc=gibbs@freebsd.org \
--cc=julien.grall@citrix.com \
--cc=kib@freebsd.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.