All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stekloff <dsteklof@us.ibm.com>
To: xen-devel@lists.xensource.com
Subject: DOM0_GETDOMAININFO intended behavior
Date: Fri, 03 Jun 2005 16:18:43 -0700	[thread overview]
Message-ID: <1117840723.11942.12.camel@w-stekloff.beaverton.ibm.com> (raw)


Hi,

Is it intended behavior for DOM0_GETDOMAININFO to return the next
domain's info if a requested domain doesn't exist? 

In xeno-unstable - xen/common/dom0_ops.c - lines 310-325:

        for_each_domain ( d )
        {
            if ( d->domain_id >= op->u.getdomaininfo.domain )
                break;
        }

        if ( (d == NULL) || !get_domain(d) )
        {
            read_unlock(&domlist_lock);
            ret = -ESRCH;
            break;
        }

        read_unlock(&domlist_lock);

        op->u.getdomaininfo.domain = d->domain_id;



If, as an example, I request info for domain 2 that doesn't exist
anymore and a higher domain number does exist, xen will return the next
domain's information rather than an error telling me domain 2 doesn't
exist.

Is this correct? 

I noticed that libxc's xc_domain_getinfo() is built to use this when
grabbing multiple domain information. I want to know if we need to fix
vm-list to check what's returned or if this is unwanted behavior in the
library and hypervisor.

Thanks,

Dan

             reply	other threads:[~2005-06-03 23:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 23:18 Daniel Stekloff [this message]
2005-06-04  0:43 ` DOM0_GETDOMAININFO intended behavior Kip Macy
2005-06-04  2:24   ` Anthony Liguori
2005-06-04  8:20 Ian Pratt
2005-06-04 14:56 ` Daniel Stekloff
2005-06-04 19:42   ` Christian Limpach
2005-06-04 20:48     ` Daniel Stekloff
2005-06-04 21:51 Ian Pratt
2005-06-05  0:17 ` Kip Macy
2005-06-06 22:28 ` Daniel Stekloff
2005-06-08 10:42 Ian Pratt
2005-06-09 22:35 ` Daniel Stekloff
2005-06-10  0:18 Macy, Kip

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1117840723.11942.12.camel@w-stekloff.beaverton.ibm.com \
    --to=dsteklof@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.