Re: [PATCH] mfd: remove dead code from drivers/mfd/max8997-irq.c:get_i2c()

Re: [PATCH] mfd: remove dead code from drivers/mfd/max8997-irq.c:get_i2c()

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1320 bytes --]

Sender : Jesper Juhl<jj@chaosbits.net> Date : 2011-07-03 05:38 (GMT+09:00)
> 
> We either hit one of the case's or the default in the switch statement
> in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the
> function is just dead code - remove it.
> 
> Signed-off-by: Jesper Juhl 

Looks good.

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
> drivers/mfd/max8997-irq.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c
> index 638bf7e..09274cf 100644
> --- a/drivers/mfd/max8997-irq.c
> +++ b/drivers/mfd/max8997-irq.c
> @@ -58,8 +58,6 @@ static struct i2c_client *get_i2c(struct max8997_dev *max8997,
> default:
> return ERR_PTR(-EINVAL);
> }
> -
> - return ERR_PTR(-EINVAL);
> }
> 
> struct max8997_irq_data {
> -- 
> 1.7.6
> 
> 
> -- 
> Jesper Juhl        http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.

 MyungJoo Ham (ÇÔ¸íÁÖ)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] mfd: remove dead code from drivers/mfd/max8997-irq.c:get_i2c()

[Samuel Ortiz]

Hi Jesper,

On Sat, Jul 02, 2011 at 10:38:11PM +0200, Jesper Juhl wrote:
> We either hit one of the case's or the default in the switch statement
> in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the
> function is just dead code - remove it.
Thanks, patch applied.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

[PATCH] mfd: remove dead code from drivers/mfd/max8997-irq.c:get_i2c()

[Jesper Juhl]

We either hit one of the case's or the default in the switch statement
in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the
function is just dead code - remove it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 drivers/mfd/max8997-irq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c
index 638bf7e..09274cf 100644
--- a/drivers/mfd/max8997-irq.c
+++ b/drivers/mfd/max8997-irq.c
@@ -58,8 +58,6 @@ static struct i2c_client *get_i2c(struct max8997_dev *max8997,
 	default:
 		return ERR_PTR(-EINVAL);
 	}
-
-	return ERR_PTR(-EINVAL);
 }
 
 struct max8997_irq_data {
-- 
1.7.6


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.