* [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX
@ 2020-08-03 6:58 Thomas Huth
2020-08-03 21:23 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2020-08-03 6:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Fam Zheng, qemu-block
test-image-locking.c uses the qemu_lock_fd_test() function which is
only available on Posix-like systems.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/Makefile.include | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 5ff731be2b..430119db74 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
+ifeq ($(CONFIG_POSIX),y)
check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
+endif
check-unit-y += tests/test-x86-cpuid$(EXESUF)
# all code tested by test-x86-cpuid is inside topology.h
ifeq ($(CONFIG_SOFTMMU),y)
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX
2020-08-03 6:58 [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
@ 2020-08-03 21:23 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2020-08-03 21:23 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial, Fam Zheng, qemu-block
On 8/3/20 2:58 AM, Thomas Huth wrote:
> test-image-locking.c uses the qemu_lock_fd_test() function which is
> only available on Posix-like systems.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/Makefile.include | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 5ff731be2b..430119db74 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
> +ifeq ($(CONFIG_POSIX),y)
> check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
> +endif
> check-unit-y += tests/test-x86-cpuid$(EXESUF)
> # all code tested by test-x86-cpuid is inside topology.h
> ifeq ($(CONFIG_SOFTMMU),y)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 6:58 [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-03 21:23 ` John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.