* [PATCH] PCI: Export pci_cfg_space_size
@ 2005-12-13 7:09 Benjamin Herrenschmidt
2005-12-13 19:48 ` patch pci-export-pci_cfg_space_size.patch added to gregkh-2.6 tree gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2005-12-13 7:09 UTC (permalink / raw)
To: Greg KH, Paul Mackerras; +Cc: linuxppc64-dev, linux-pci, linuxppc-dev list
The powerpc PCI code sets up the PCI tree without doing config space
accesses in most cases, from the firmware tree. However, it still wants
to call pci_cfg_space_size() under some conditions, thus it needs to
be made non-static (though I don't see a point to export it to modules).
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Greg: I don't remember if I already sent you that patch or not, if not,
then heh, here it is :) The powerpc patch that requires this one will be
going next to the powerpc git tree and -mm, with a 2.6.16 target. Let me
know if there is any objection.
Paul: You need that for the new G5 support patch that I'm sending next.
Index: linux-work/drivers/pci/probe.c
===================================================================
--- linux-work.orig/drivers/pci/probe.c 2005-11-24 17:18:45.000000000 +1100
+++ linux-work/drivers/pci/probe.c 2005-12-08 10:15:41.000000000 +1100
@@ -678,7 +678,7 @@ static void pci_release_dev(struct devic
* reading the dword at 0x100 which must either be 0 or a valid extended
* capability header.
*/
-static int pci_cfg_space_size(struct pci_dev *dev)
+int pci_cfg_space_size(struct pci_dev *dev)
{
int pos;
u32 status;
Index: linux-work/include/linux/pci.h
===================================================================
--- linux-work.orig/include/linux/pci.h 2005-11-30 10:43:15.000000000 +1100
+++ linux-work/include/linux/pci.h 2005-12-08 10:16:19.000000000 +1100
@@ -515,6 +515,7 @@ int pci_scan_bridge(struct pci_bus *bus,
void pci_walk_bus(struct pci_bus *top, void (*cb)(struct pci_dev *, void *),
void *userdata);
+int pci_cfg_space_size(struct pci_dev *dev);
/* kmem_cache style wrapper around pci_alloc_consistent() */
^ permalink raw reply [flat|nested] 2+ messages in thread
* patch pci-export-pci_cfg_space_size.patch added to gregkh-2.6 tree
2005-12-13 7:09 [PATCH] PCI: Export pci_cfg_space_size Benjamin Herrenschmidt
@ 2005-12-13 19:48 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2005-12-13 19:48 UTC (permalink / raw)
To: benh, greg, gregkh, linux-pci, linuxppc-dev, linuxppc64-dev, paulus
This is a note to let you know that I've just added the patch titled
Subject: [PATCH] PCI: Export pci_cfg_space_size
to my gregkh-2.6 tree. Its filename is
pci-export-pci_cfg_space_size.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
Patches currently in gregkh-2.6 which might be from benh@kernel.crashing.org are
i2c/i2c-drop-driver-owner-and-name-04-macintosh.patch
pci/pci-export-pci_cfg_space_size.patch
>From benh@kernel.crashing.org Mon Dec 12 23:16:21 2005
Subject: [PATCH] PCI: Export pci_cfg_space_size
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Greg KH <greg@kroah.com>, Paul Mackerras <paulus@samba.org>
Cc: linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>, linuxppc64-dev <linuxppc64-dev@ozlabs.org>, linuxppc-dev list <linuxppc-dev@ozlabs.org>
Date: Tue, 13 Dec 2005 18:09:16 +1100
Message-Id: <1134457757.6989.195.camel@gaston>
The powerpc PCI code sets up the PCI tree without doing config space
accesses in most cases, from the firmware tree. However, it still wants
to call pci_cfg_space_size() under some conditions, thus it needs to
be made non-static (though I don't see a point to export it to modules).
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/pci/probe.c | 2 +-
include/linux/pci.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--- gregkh-2.6.orig/drivers/pci/probe.c
+++ gregkh-2.6/drivers/pci/probe.c
@@ -717,7 +717,7 @@ static void pci_release_dev(struct devic
* reading the dword at 0x100 which must either be 0 or a valid extended
* capability header.
*/
-static int pci_cfg_space_size(struct pci_dev *dev)
+int pci_cfg_space_size(struct pci_dev *dev)
{
int pos;
u32 status;
--- gregkh-2.6.orig/include/linux/pci.h
+++ gregkh-2.6/include/linux/pci.h
@@ -514,6 +514,7 @@ int pci_scan_bridge(struct pci_bus *bus,
void pci_walk_bus(struct pci_bus *top, void (*cb)(struct pci_dev *, void *),
void *userdata);
+int pci_cfg_space_size(struct pci_dev *dev);
/* kmem_cache style wrapper around pci_alloc_consistent() */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-12-13 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-13 7:09 [PATCH] PCI: Export pci_cfg_space_size Benjamin Herrenschmidt
2005-12-13 19:48 ` patch pci-export-pci_cfg_space_size.patch added to gregkh-2.6 tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.