All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/nouveau: Remove set but not used variable 'width'
@ 2021-05-25  8:17 ` Baokun Li
  0 siblings, 0 replies; 5+ messages in thread
From: Baokun Li @ 2021-05-25  8:17 UTC (permalink / raw)
  To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
  Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
 variable ‘width’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
 drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 929de41c281f..2b460835a438 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
 	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
 	struct drm_framebuffer *fb;
 	const struct drm_format_info *info;
-	unsigned int width, height, i;
+	unsigned int height, i;
 	uint32_t tile_mode;
 	uint8_t kind;
 	int ret;
@@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
 	info = drm_get_format_info(dev, mode_cmd);
 
 	for (i = 0; i < info->num_planes; i++) {
-		width = drm_format_info_plane_width(info,
-						    mode_cmd->width,
-						    i);
 		height = drm_format_info_plane_height(info,
 						      mode_cmd->height,
 						      i);
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH -next] drm/nouveau: Remove set but not used variable 'width'
@ 2021-05-25  8:17 ` Baokun Li
  0 siblings, 0 replies; 5+ messages in thread
From: Baokun Li @ 2021-05-25  8:17 UTC (permalink / raw)
  To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
  Cc: yuehaibing, libaokun1, weiyongjun1, yukuai3, yangjihong1

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
 variable ‘width’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
 drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 929de41c281f..2b460835a438 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
 	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
 	struct drm_framebuffer *fb;
 	const struct drm_format_info *info;
-	unsigned int width, height, i;
+	unsigned int height, i;
 	uint32_t tile_mode;
 	uint8_t kind;
 	int ret;
@@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
 	info = drm_get_format_info(dev, mode_cmd);
 
 	for (i = 0; i < info->num_planes; i++) {
-		width = drm_format_info_plane_width(info,
-						    mode_cmd->width,
-						    i);
 		height = drm_format_info_plane_height(info,
 						      mode_cmd->height,
 						      i);
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/nouveau: Remove set but not used variable 'width'
  2021-05-25  8:17 ` Baokun Li
  (?)
@ 2021-06-15  1:58   ` libaokun (A)
  -1 siblings, 0 replies; 5+ messages in thread
From: libaokun (A) @ 2021-06-15  1:58 UTC (permalink / raw)
  To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
  Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3

ping

在 2021/5/25 16:17, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
> drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
>   variable ‘width’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 929de41c281f..2b460835a438 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
>   	struct drm_framebuffer *fb;
>   	const struct drm_format_info *info;
> -	unsigned int width, height, i;
> +	unsigned int height, i;
>   	uint32_t tile_mode;
>   	uint8_t kind;
>   	int ret;
> @@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	info = drm_get_format_info(dev, mode_cmd);
>   
>   	for (i = 0; i < info->num_planes; i++) {
> -		width = drm_format_info_plane_width(info,
> -						    mode_cmd->width,
> -						    i);
>   		height = drm_format_info_plane_height(info,
>   						      mode_cmd->height,
>   						      i);

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Nouveau] [PATCH -next] drm/nouveau: Remove set but not used variable 'width'
@ 2021-06-15  1:58   ` libaokun (A)
  0 siblings, 0 replies; 5+ messages in thread
From: libaokun (A) @ 2021-06-15  1:58 UTC (permalink / raw)
  To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
  Cc: yuehaibing, weiyongjun1, yukuai3, yangjihong1

ping

在 2021/5/25 16:17, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
> drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
>   variable ‘width’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 929de41c281f..2b460835a438 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
>   	struct drm_framebuffer *fb;
>   	const struct drm_format_info *info;
> -	unsigned int width, height, i;
> +	unsigned int height, i;
>   	uint32_t tile_mode;
>   	uint8_t kind;
>   	int ret;
> @@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	info = drm_get_format_info(dev, mode_cmd);
>   
>   	for (i = 0; i < info->num_planes; i++) {
> -		width = drm_format_info_plane_width(info,
> -						    mode_cmd->width,
> -						    i);
>   		height = drm_format_info_plane_height(info,
>   						      mode_cmd->height,
>   						      i);
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/nouveau: Remove set but not used variable 'width'
@ 2021-06-15  1:58   ` libaokun (A)
  0 siblings, 0 replies; 5+ messages in thread
From: libaokun (A) @ 2021-06-15  1:58 UTC (permalink / raw)
  To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
  Cc: yuehaibing, weiyongjun1, yukuai3, yangjihong1

ping

在 2021/5/25 16:17, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_framebuffer_new':
> drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning:
>   variable ‘width’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_display.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 929de41c281f..2b460835a438 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -306,7 +306,7 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	struct nouveau_bo *nvbo = nouveau_gem_object(gem);
>   	struct drm_framebuffer *fb;
>   	const struct drm_format_info *info;
> -	unsigned int width, height, i;
> +	unsigned int height, i;
>   	uint32_t tile_mode;
>   	uint8_t kind;
>   	int ret;
> @@ -343,9 +343,6 @@ nouveau_framebuffer_new(struct drm_device *dev,
>   	info = drm_get_format_info(dev, mode_cmd);
>   
>   	for (i = 0; i < info->num_planes; i++) {
> -		width = drm_format_info_plane_width(info,
> -						    mode_cmd->width,
> -						    i);
>   		height = drm_format_info_plane_height(info,
>   						      mode_cmd->height,
>   						      i);

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-27  3:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25  8:17 [PATCH -next] drm/nouveau: Remove set but not used variable 'width' Baokun Li
2021-05-25  8:17 ` Baokun Li
2021-06-15  1:58 ` libaokun (A)
2021-06-15  1:58   ` libaokun (A)
2021-06-15  1:58   ` [Nouveau] " libaokun (A)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.