All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] intel-vbtn: match power button on press rather than release
@ 2017-08-04 17:00 Mario Limonciello
  2017-08-04 17:29 ` Darren Hart
  2017-09-16 13:45 ` Pali Rohár
  0 siblings, 2 replies; 10+ messages in thread
From: Mario Limonciello @ 2017-08-04 17:00 UTC (permalink / raw)
  To: AceLan Kao, dvhart, linux-pm, Rafael J . Wysocki
  Cc: LKML, platform-driver-x86, Len Brown, Srinivas Pandruvada,
	Mario Limonciello

This fixes a problem where the system gets stuck in a loop
unable to wakeup via power button in s2idle.

The problem happens because:
 - press power button:
   - system emits 0xc0 (power press), event ignored
   - system emits 0xc1 (power release), event processed,
     emited as KEY_POWER
   - set wakeup_mode to true
   - system goes to s2idle
 - press power button
   - system emits 0xc0 (power press), wakeup_mode is true,
     system wakes
   - system emits 0xc1 (power release), event processed,
     emited as KEY_POWER
   - system goes to s2idle again

To avoid this situation, process the presses (which matches what
intel-hid does too).

Verified on an Dell XPS 9365

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
 drivers/platform/x86/intel-vbtn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 61f1063..4809267 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -36,8 +36,8 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
 
 /* In theory, these are HID usages. */
 static const struct key_entry intel_vbtn_keymap[] = {
-	{ KE_IGNORE, 0xC0, { KEY_POWER } },	/* power key press */
-	{ KE_KEY, 0xC1, { KEY_POWER } },	/* power key release */
+	{ KE_KEY, 0xC0, { KEY_POWER } },	/* power key press */
+	{ KE_IGNORE, 0xC1, { KEY_POWER } },	/* power key release */
 	{ KE_KEY, 0xC4, { KEY_VOLUMEUP } },		/* volume-up key press */
 	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },		/* volume-up key release */
 	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },		/* volume-down key press */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-04 17:00 [PATCH] intel-vbtn: match power button on press rather than release Mario Limonciello
@ 2017-08-04 17:29 ` Darren Hart
  2017-08-04 23:30   ` Rafael J. Wysocki
  2017-09-16 13:45 ` Pali Rohár
  1 sibling, 1 reply; 10+ messages in thread
From: Darren Hart @ 2017-08-04 17:29 UTC (permalink / raw)
  To: Mario Limonciello
  Cc: AceLan Kao, linux-pm, Rafael J . Wysocki, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada

On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> This fixes a problem where the system gets stuck in a loop
> unable to wakeup via power button in s2idle.
> 
> The problem happens because:
>  - press power button:
>    - system emits 0xc0 (power press), event ignored
>    - system emits 0xc1 (power release), event processed,
>      emited as KEY_POWER
>    - set wakeup_mode to true
>    - system goes to s2idle
>  - press power button
>    - system emits 0xc0 (power press), wakeup_mode is true,
>      system wakes
>    - system emits 0xc1 (power release), event processed,
>      emited as KEY_POWER
>    - system goes to s2idle again
> 
> To avoid this situation, process the presses (which matches what
> intel-hid does too).
> 
> Verified on an Dell XPS 9365
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>

This looks good to me - responding to the release is non-intuitive IMHO
anyway.  I'd like to see agreement from AceLan, but this should go into
the 4.13 rc cycle (at rc3 currently).

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-04 17:29 ` Darren Hart
@ 2017-08-04 23:30   ` Rafael J. Wysocki
  2017-08-05 20:57     ` Darren Hart
  0 siblings, 1 reply; 10+ messages in thread
From: Rafael J. Wysocki @ 2017-08-04 23:30 UTC (permalink / raw)
  To: Darren Hart
  Cc: Mario Limonciello, AceLan Kao, linux-pm, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > This fixes a problem where the system gets stuck in a loop
> > unable to wakeup via power button in s2idle.
> > 
> > The problem happens because:
> >  - press power button:
> >    - system emits 0xc0 (power press), event ignored
> >    - system emits 0xc1 (power release), event processed,
> >      emited as KEY_POWER
> >    - set wakeup_mode to true
> >    - system goes to s2idle
> >  - press power button
> >    - system emits 0xc0 (power press), wakeup_mode is true,
> >      system wakes
> >    - system emits 0xc1 (power release), event processed,
> >      emited as KEY_POWER
> >    - system goes to s2idle again
> > 
> > To avoid this situation, process the presses (which matches what
> > intel-hid does too).
> > 
> > Verified on an Dell XPS 9365
> > 
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> 
> This looks good to me - responding to the release is non-intuitive IMHO
> anyway.  I'd like to see agreement from AceLan, but this should go into
> the 4.13 rc cycle (at rc3 currently).

Yes, it should, and I'm not sure if the original author's opinion matters here.

The patch makes sense to everyone involved and fixes an annoying issue, so
I don't see any real arguments against applying it.

Please feel free to add my ACK to it if that helps.

In any case, it has to go in before https://patchwork.kernel.org/patch/9873163/
does, is if it doesn't go into 4.13-rc after all, please let me know.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-04 23:30   ` Rafael J. Wysocki
@ 2017-08-05 20:57     ` Darren Hart
  2017-08-05 22:20       ` Rafael J. Wysocki
  0 siblings, 1 reply; 10+ messages in thread
From: Darren Hart @ 2017-08-05 20:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Mario Limonciello, AceLan Kao, linux-pm, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
> On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > > This fixes a problem where the system gets stuck in a loop
> > > unable to wakeup via power button in s2idle.
> > > 
> > > The problem happens because:
> > >  - press power button:
> > >    - system emits 0xc0 (power press), event ignored
> > >    - system emits 0xc1 (power release), event processed,
> > >      emited as KEY_POWER
> > >    - set wakeup_mode to true
> > >    - system goes to s2idle
> > >  - press power button
> > >    - system emits 0xc0 (power press), wakeup_mode is true,
> > >      system wakes
> > >    - system emits 0xc1 (power release), event processed,
> > >      emited as KEY_POWER
> > >    - system goes to s2idle again
> > > 
> > > To avoid this situation, process the presses (which matches what
> > > intel-hid does too).
> > > 
> > > Verified on an Dell XPS 9365
> > > 
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > 
> > This looks good to me - responding to the release is non-intuitive IMHO
> > anyway.  I'd like to see agreement from AceLan, but this should go into
> > the 4.13 rc cycle (at rc3 currently).
> 
> Yes, it should, and I'm not sure if the original author's opinion matters here.
> 
> The patch makes sense to everyone involved and fixes an annoying issue, so
> I don't see any real arguments against applying it.
> 
> Please feel free to add my ACK to it if that helps.

I always try to give those in MAINTAINERS a chance to respond, but I will queue
this up to fixes now.

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-05 20:57     ` Darren Hart
@ 2017-08-05 22:20       ` Rafael J. Wysocki
  2017-08-06 23:24         ` Darren Hart
  0 siblings, 1 reply; 10+ messages in thread
From: Rafael J. Wysocki @ 2017-08-05 22:20 UTC (permalink / raw)
  To: Darren Hart
  Cc: Mario Limonciello, AceLan Kao, linux-pm, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote:
> On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
> > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > > > This fixes a problem where the system gets stuck in a loop
> > > > unable to wakeup via power button in s2idle.
> > > > 
> > > > The problem happens because:
> > > >  - press power button:
> > > >    - system emits 0xc0 (power press), event ignored
> > > >    - system emits 0xc1 (power release), event processed,
> > > >      emited as KEY_POWER
> > > >    - set wakeup_mode to true
> > > >    - system goes to s2idle
> > > >  - press power button
> > > >    - system emits 0xc0 (power press), wakeup_mode is true,
> > > >      system wakes
> > > >    - system emits 0xc1 (power release), event processed,
> > > >      emited as KEY_POWER
> > > >    - system goes to s2idle again
> > > > 
> > > > To avoid this situation, process the presses (which matches what
> > > > intel-hid does too).
> > > > 
> > > > Verified on an Dell XPS 9365
> > > > 
> > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > 
> > > This looks good to me - responding to the release is non-intuitive IMHO
> > > anyway.  I'd like to see agreement from AceLan, but this should go into
> > > the 4.13 rc cycle (at rc3 currently).
> > 
> > Yes, it should, and I'm not sure if the original author's opinion matters here.
> > 
> > The patch makes sense to everyone involved and fixes an annoying issue, so
> > I don't see any real arguments against applying it.
> > 
> > Please feel free to add my ACK to it if that helps.
> 
> I always try to give those in MAINTAINERS a chance to respond, but I will queue
> this up to fixes now.

Thanks!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-05 22:20       ` Rafael J. Wysocki
@ 2017-08-06 23:24         ` Darren Hart
  2017-08-07  0:38           ` Rafael J. Wysocki
  0 siblings, 1 reply; 10+ messages in thread
From: Darren Hart @ 2017-08-06 23:24 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Mario Limonciello, AceLan Kao, linux-pm, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote:
> On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote:
> > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
> > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> > > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > > > > This fixes a problem where the system gets stuck in a loop
> > > > > unable to wakeup via power button in s2idle.
> > > > > 
> > > > > The problem happens because:
> > > > >  - press power button:
> > > > >    - system emits 0xc0 (power press), event ignored
> > > > >    - system emits 0xc1 (power release), event processed,
> > > > >      emited as KEY_POWER
> > > > >    - set wakeup_mode to true
> > > > >    - system goes to s2idle
> > > > >  - press power button
> > > > >    - system emits 0xc0 (power press), wakeup_mode is true,
> > > > >      system wakes
> > > > >    - system emits 0xc1 (power release), event processed,
> > > > >      emited as KEY_POWER
> > > > >    - system goes to s2idle again
> > > > > 
> > > > > To avoid this situation, process the presses (which matches what
> > > > > intel-hid does too).
> > > > > 
> > > > > Verified on an Dell XPS 9365
> > > > > 
> > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > > 
> > > > This looks good to me - responding to the release is non-intuitive IMHO
> > > > anyway.  I'd like to see agreement from AceLan, but this should go into
> > > > the 4.13 rc cycle (at rc3 currently).
> > > 
> > > Yes, it should, and I'm not sure if the original author's opinion matters here.
> > > 
> > > The patch makes sense to everyone involved and fixes an annoying issue, so
> > > I don't see any real arguments against applying it.
> > > 
> > > Please feel free to add my ACK to it if that helps.
> > 
> > I always try to give those in MAINTAINERS a chance to respond, but I will queue
> > this up to fixes now.
> 
> Thanks!

Rafael,

Merged to mainline (in case you were waiting on this for the dependent
patch you mentioned).

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-06 23:24         ` Darren Hart
@ 2017-08-07  0:38           ` Rafael J. Wysocki
  2017-08-07  0:59             ` AceLan Kao
  0 siblings, 1 reply; 10+ messages in thread
From: Rafael J. Wysocki @ 2017-08-07  0:38 UTC (permalink / raw)
  To: Darren Hart
  Cc: Rafael J. Wysocki, Mario Limonciello, AceLan Kao, Linux PM, LKML,
	Platform Driver, Len Brown, Srinivas Pandruvada, Andy Shevchenko

On Mon, Aug 7, 2017 at 1:24 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote:
>> On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote:
>> > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
>> > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
>> > > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
>> > > > > This fixes a problem where the system gets stuck in a loop
>> > > > > unable to wakeup via power button in s2idle.
>> > > > >
>> > > > > The problem happens because:
>> > > > >  - press power button:
>> > > > >    - system emits 0xc0 (power press), event ignored
>> > > > >    - system emits 0xc1 (power release), event processed,
>> > > > >      emited as KEY_POWER
>> > > > >    - set wakeup_mode to true
>> > > > >    - system goes to s2idle
>> > > > >  - press power button
>> > > > >    - system emits 0xc0 (power press), wakeup_mode is true,
>> > > > >      system wakes
>> > > > >    - system emits 0xc1 (power release), event processed,
>> > > > >      emited as KEY_POWER
>> > > > >    - system goes to s2idle again
>> > > > >
>> > > > > To avoid this situation, process the presses (which matches what
>> > > > > intel-hid does too).
>> > > > >
>> > > > > Verified on an Dell XPS 9365
>> > > > >
>> > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>> > > >
>> > > > This looks good to me - responding to the release is non-intuitive IMHO
>> > > > anyway.  I'd like to see agreement from AceLan, but this should go into
>> > > > the 4.13 rc cycle (at rc3 currently).
>> > >
>> > > Yes, it should, and I'm not sure if the original author's opinion matters here.
>> > >
>> > > The patch makes sense to everyone involved and fixes an annoying issue, so
>> > > I don't see any real arguments against applying it.
>> > >
>> > > Please feel free to add my ACK to it if that helps.
>> >
>> > I always try to give those in MAINTAINERS a chance to respond, but I will queue
>> > this up to fixes now.
>>
>> Thanks!
>
> Rafael,
>
> Merged to mainline (in case you were waiting on this for the dependent
> patch you mentioned).

Awesome, thanks!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-07  0:38           ` Rafael J. Wysocki
@ 2017-08-07  0:59             ` AceLan Kao
  2017-08-07  3:54               ` Darren Hart
  0 siblings, 1 reply; 10+ messages in thread
From: AceLan Kao @ 2017-08-07  0:59 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Darren Hart, Rafael J. Wysocki, Mario Limonciello, Linux PM,
	LKML, Platform Driver, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

Looks like I'm one hour late to ack the patch.
Thanks any way for the quick response.

2017-08-07 8:38 GMT+08:00 Rafael J. Wysocki <rafael@kernel.org>:
> On Mon, Aug 7, 2017 at 1:24 AM, Darren Hart <dvhart@infradead.org> wrote:
>> On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote:
>>> On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote:
>>> > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
>>> > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
>>> > > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
>>> > > > > This fixes a problem where the system gets stuck in a loop
>>> > > > > unable to wakeup via power button in s2idle.
>>> > > > >
>>> > > > > The problem happens because:
>>> > > > >  - press power button:
>>> > > > >    - system emits 0xc0 (power press), event ignored
>>> > > > >    - system emits 0xc1 (power release), event processed,
>>> > > > >      emited as KEY_POWER
>>> > > > >    - set wakeup_mode to true
>>> > > > >    - system goes to s2idle
>>> > > > >  - press power button
>>> > > > >    - system emits 0xc0 (power press), wakeup_mode is true,
>>> > > > >      system wakes
>>> > > > >    - system emits 0xc1 (power release), event processed,
>>> > > > >      emited as KEY_POWER
>>> > > > >    - system goes to s2idle again
>>> > > > >
>>> > > > > To avoid this situation, process the presses (which matches what
>>> > > > > intel-hid does too).
>>> > > > >
>>> > > > > Verified on an Dell XPS 9365
>>> > > > >
>>> > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>>> > > >
>>> > > > This looks good to me - responding to the release is non-intuitive IMHO
>>> > > > anyway.  I'd like to see agreement from AceLan, but this should go into
>>> > > > the 4.13 rc cycle (at rc3 currently).
>>> > >
>>> > > Yes, it should, and I'm not sure if the original author's opinion matters here.
>>> > >
>>> > > The patch makes sense to everyone involved and fixes an annoying issue, so
>>> > > I don't see any real arguments against applying it.
>>> > >
>>> > > Please feel free to add my ACK to it if that helps.
>>> >
>>> > I always try to give those in MAINTAINERS a chance to respond, but I will queue
>>> > this up to fixes now.
>>>
>>> Thanks!
>>
>> Rafael,
>>
>> Merged to mainline (in case you were waiting on this for the dependent
>> patch you mentioned).
>
> Awesome, thanks!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] intel-vbtn: match power button on press rather than release
  2017-08-07  0:59             ` AceLan Kao
@ 2017-08-07  3:54               ` Darren Hart
  0 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2017-08-07  3:54 UTC (permalink / raw)
  To: AceLan Kao
  Cc: Rafael J. Wysocki, Rafael J. Wysocki, Mario Limonciello,
	Linux PM, LKML, Platform Driver, Len Brown, Srinivas Pandruvada,
	Andy Shevchenko

On Mon, Aug 07, 2017 at 08:59:30AM +0800, AceLan Kao wrote:
> Looks like I'm one hour late to ack the patch.
> Thanks any way for the quick response.

Thanks for chiming in all the same - and normally I'd have provided for
more time. In this case, I will be away for a few days, and it was
important to get this in sooner rather than later in the RC cycle.

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: intel-vbtn: match power button on press rather than release
  2017-08-04 17:00 [PATCH] intel-vbtn: match power button on press rather than release Mario Limonciello
  2017-08-04 17:29 ` Darren Hart
@ 2017-09-16 13:45 ` Pali Rohár
  1 sibling, 0 replies; 10+ messages in thread
From: Pali Rohár @ 2017-09-16 13:45 UTC (permalink / raw)
  To: Mario Limonciello, dvhart, Dmitry Torokhov
  Cc: AceLan Kao, linux-pm, Rafael J . Wysocki, LKML,
	platform-driver-x86, Len Brown, Srinivas Pandruvada

[-- Attachment #1: Type: Text/Plain, Size: 2188 bytes --]

On Friday 04 August 2017 19:00:06 Mario Limonciello wrote:
> This fixes a problem where the system gets stuck in a loop
> unable to wakeup via power button in s2idle.
> 
> The problem happens because:
>  - press power button:
>    - system emits 0xc0 (power press), event ignored
>    - system emits 0xc1 (power release), event processed,
>      emited as KEY_POWER
>    - set wakeup_mode to true
>    - system goes to s2idle
>  - press power button
>    - system emits 0xc0 (power press), wakeup_mode is true,
>      system wakes
>    - system emits 0xc1 (power release), event processed,
>      emited as KEY_POWER
>    - system goes to s2idle again
> 
> To avoid this situation, process the presses (which matches what
> intel-hid does too).
> 
> Verified on an Dell XPS 9365
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
>  drivers/platform/x86/intel-vbtn.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel-vbtn.c
> b/drivers/platform/x86/intel-vbtn.c index 61f1063..4809267 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -36,8 +36,8 @@ static const struct acpi_device_id intel_vbtn_ids[]
> = {
> 
>  /* In theory, these are HID usages. */
>  static const struct key_entry intel_vbtn_keymap[] = {
> -	{ KE_IGNORE, 0xC0, { KEY_POWER } },	/* power key press */
> -	{ KE_KEY, 0xC1, { KEY_POWER } },	/* power key release */
> +	{ KE_KEY, 0xC0, { KEY_POWER } },	/* power key press */
> +	{ KE_IGNORE, 0xC1, { KEY_POWER } },	/* power key release */
>  	{ KE_KEY, 0xC4, { KEY_VOLUMEUP } },		/* volume-up key press */
>  	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },		/* volume-up key release 
*/
>  	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },		/* volume-down key press */

Hello, maybe a stupid question, but why to not report both events "key 
pressed" and "key released" to userspace? IIRC kernel input layer can 
distinguish between these two type of events. But in intel-vbtn.c source 
code I see that all "release" ACPI events are ignored and just "press" 
are processed.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-09-16 13:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 17:00 [PATCH] intel-vbtn: match power button on press rather than release Mario Limonciello
2017-08-04 17:29 ` Darren Hart
2017-08-04 23:30   ` Rafael J. Wysocki
2017-08-05 20:57     ` Darren Hart
2017-08-05 22:20       ` Rafael J. Wysocki
2017-08-06 23:24         ` Darren Hart
2017-08-07  0:38           ` Rafael J. Wysocki
2017-08-07  0:59             ` AceLan Kao
2017-08-07  3:54               ` Darren Hart
2017-09-16 13:45 ` Pali Rohár

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.