[PATCH] ceph: make ceph_queue_cap_snap static

[PATCH] ceph: make ceph_queue_cap_snap static

[Jeff Layton]

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ceph/snap.c  | 2 +-
 fs/ceph/super.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
index 4ce18055d931..44b380a53727 100644
--- a/fs/ceph/snap.c
+++ b/fs/ceph/snap.c
@@ -460,7 +460,7 @@ static bool has_new_snaps(struct ceph_snap_context *o,
  * Caller must hold snap_rwsem for read (i.e., the realm topology won't
  * change).
  */
-void ceph_queue_cap_snap(struct ceph_inode_info *ci)
+static void ceph_queue_cap_snap(struct ceph_inode_info *ci)
 {
 	struct inode *inode = &ci->vfs_inode;
 	struct ceph_cap_snap *capsnap;
diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index db80d89556b1..12d30153e4ca 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -931,7 +931,6 @@ extern int ceph_update_snap_trace(struct ceph_mds_client *m,
 extern void ceph_handle_snap(struct ceph_mds_client *mdsc,
 			     struct ceph_mds_session *session,
 			     struct ceph_msg *msg);
-extern void ceph_queue_cap_snap(struct ceph_inode_info *ci);
 extern int __ceph_finish_cap_snap(struct ceph_inode_info *ci,
 				  struct ceph_cap_snap *capsnap);
 extern void ceph_cleanup_empty_realms(struct ceph_mds_client *mdsc);
-- 
2.31.1

Re: [PATCH] ceph: make ceph_queue_cap_snap static

[Xiubo Li]

On 5/19/21 5:36 AM, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>   fs/ceph/snap.c  | 2 +-
>   fs/ceph/super.h | 1 -
>   2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
> index 4ce18055d931..44b380a53727 100644
> --- a/fs/ceph/snap.c
> +++ b/fs/ceph/snap.c
> @@ -460,7 +460,7 @@ static bool has_new_snaps(struct ceph_snap_context *o,
>    * Caller must hold snap_rwsem for read (i.e., the realm topology won't
>    * change).
>    */
> -void ceph_queue_cap_snap(struct ceph_inode_info *ci)
> +static void ceph_queue_cap_snap(struct ceph_inode_info *ci)
>   {
>   	struct inode *inode = &ci->vfs_inode;
>   	struct ceph_cap_snap *capsnap;
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index db80d89556b1..12d30153e4ca 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -931,7 +931,6 @@ extern int ceph_update_snap_trace(struct ceph_mds_client *m,
>   extern void ceph_handle_snap(struct ceph_mds_client *mdsc,
>   			     struct ceph_mds_session *session,
>   			     struct ceph_msg *msg);
> -extern void ceph_queue_cap_snap(struct ceph_inode_info *ci);
>   extern int __ceph_finish_cap_snap(struct ceph_inode_info *ci,
>   				  struct ceph_cap_snap *capsnap);
>   extern void ceph_cleanup_empty_realms(struct ceph_mds_client *mdsc);

Reviewed-by: Xiubo Li <xiubli@redhat.com>