* [Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code
@ 2018-03-04 17:26 Stefan Wahren
2018-03-09 12:50 ` Stefan Wahren
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Wahren @ 2018-03-04 17:26 UTC (permalink / raw)
To: Arend van Spriel, Johannes Berg, Franky Lin, Hante Meuleman,
Chi-Hsien Lin, Wright Feng
Cc: linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list
Hi,
the commit "regulatory: add NUL to request alpha2" in linux-next-20180302 causes a regression with brcmfmac (Platform: Raspberry Pi 3 B). During driver probe i will get this error:
brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code (0x44 0x45)
But 0x44 0x45 ( = DE ) is a valid ISO3166 code.
The reason for this behavior is that the function checks the complete array, not just the first 2 elements.
IMO at least the functions brcmf_cfg80211_reg_notifier() and brcmf_translate_country_code() should be fixed.
Regards
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code
2018-03-04 17:26 [Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code Stefan Wahren
@ 2018-03-09 12:50 ` Stefan Wahren
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Wahren @ 2018-03-09 12:50 UTC (permalink / raw)
To: Arend van Spriel, Johannes Berg, Wright Feng, Franky Lin,
Hante Meuleman, Chi-Hsien Lin, Kalle Valo
Cc: linux-wireless, brcm80211-dev-list, brcm80211-dev-list.pdl
Hi,
> Stefan Wahren <stefan.wahren@i2se.com> hat am 4. März 2018 um 18:26 geschrieben:
>
>
> Hi,
>
> the commit "regulatory: add NUL to request alpha2" in linux-next-20180302 causes a regression with brcmfmac (Platform: Raspberry Pi 3 B). During driver probe i will get this error:
>
> brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code (0x44 0x45)
>
> But 0x44 0x45 ( = DE ) is a valid ISO3166 code.
>
> The reason for this behavior is that the function checks the complete array, not just the first 2 elements.
>
> IMO at least the functions brcmf_cfg80211_reg_notifier() and brcmf_translate_country_code() should be fixed.
would it be okay to fix the regression like this [1]?
[1] - https://github.com/lategoodbye/rpi-zero/commit/5986aa583b1a8ac4dd5242b0aa489826c74fcb81
Regards
Stefan
>
> Regards
> Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-09 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-04 17:26 [Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code Stefan Wahren
2018-03-09 12:50 ` Stefan Wahren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.