From: Rusty Russell <rusty@rustcorp.com.au> To: Andrew Morton <akpm@linux-foundation.org> Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.osdl.org>, Ingo Molnar <mingo@elte.hu> Subject: [PATCH 2/2] lguest preparation: expose futex infrastructure: get_futex_key, get_key_refs and drop_key_refs Date: Mon, 12 Feb 2007 14:42:50 +1100 [thread overview] Message-ID: <1171251770.10409.23.camel@localhost.localdomain> (raw) In-Reply-To: <1171251698.10409.20.camel@localhost.localdomain> lguest uses the convenient futex infrastructure for inter-domain I/O, so expose get_futex_key, get_key_refs (renamed get_futex_key_refs) and drop_key_refs (renamed drop_futex_key_refs). Also means we need to expose the union that these use. No code changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> =================================================================== --- a/include/linux/futex.h +++ b/include/linux/futex.h @@ -100,6 +100,35 @@ extern int extern int handle_futex_death(u32 __user *uaddr, struct task_struct *curr, int pi); +/* + * Futexes are matched on equal values of this key. + * The key type depends on whether it's a shared or private mapping. + * Don't rearrange members without looking at hash_futex(). + * + * offset is aligned to a multiple of sizeof(u32) (== 4) by definition. + * We set bit 0 to indicate if it's an inode-based key. + */ +union futex_key { + struct { + unsigned long pgoff; + struct inode *inode; + int offset; + } shared; + struct { + unsigned long address; + struct mm_struct *mm; + int offset; + } private; + struct { + unsigned long word; + void *ptr; + int offset; + } both; +}; +int get_futex_key(u32 __user *uaddr, union futex_key *key); +void get_futex_key_refs(union futex_key *key); +void drop_futex_key_refs(union futex_key *key); + #ifdef CONFIG_FUTEX extern void exit_robust_list(struct task_struct *curr); extern void exit_pi_state_list(struct task_struct *curr); =================================================================== --- a/kernel/futex.c +++ b/kernel/futex.c @@ -48,37 +48,12 @@ #include <linux/pagemap.h> #include <linux/syscalls.h> #include <linux/signal.h> +#include <linux/module.h> #include <asm/futex.h> #include "rtmutex_common.h" #define FUTEX_HASHBITS (CONFIG_BASE_SMALL ? 4 : 8) - -/* - * Futexes are matched on equal values of this key. - * The key type depends on whether it's a shared or private mapping. - * Don't rearrange members without looking at hash_futex(). - * - * offset is aligned to a multiple of sizeof(u32) (== 4) by definition. - * We set bit 0 to indicate if it's an inode-based key. - */ -union futex_key { - struct { - unsigned long pgoff; - struct inode *inode; - int offset; - } shared; - struct { - unsigned long address; - struct mm_struct *mm; - int offset; - } private; - struct { - unsigned long word; - void *ptr; - int offset; - } both; -}; /* * Priority Inheritance state: @@ -175,7 +150,7 @@ static inline int match_futex(union fute * * Should be called with ¤t->mm->mmap_sem but NOT any spinlocks. */ -static int get_futex_key(u32 __user *uaddr, union futex_key *key) +int get_futex_key(u32 __user *uaddr, union futex_key *key) { unsigned long address = (unsigned long)uaddr; struct mm_struct *mm = current->mm; @@ -246,6 +221,7 @@ static int get_futex_key(u32 __user *uad } return err; } +EXPORT_SYMBOL_GPL(get_futex_key); /* * Take a reference to the resource addressed by a key. @@ -254,7 +230,7 @@ static int get_futex_key(u32 __user *uad * NOTE: mmap_sem MUST be held between get_futex_key() and calling this * function, if it is called at all. mmap_sem keeps key->shared.inode valid. */ -static inline void get_key_refs(union futex_key *key) +inline void get_futex_key_refs(union futex_key *key) { if (key->both.ptr != 0) { if (key->both.offset & 1) @@ -263,12 +239,13 @@ static inline void get_key_refs(union fu atomic_inc(&key->private.mm->mm_count); } } +EXPORT_SYMBOL_GPL(get_futex_key_refs); /* * Drop a reference to the resource addressed by a key. * The hash bucket spinlock must not be held. */ -static void drop_key_refs(union futex_key *key) +void drop_futex_key_refs(union futex_key *key) { if (key->both.ptr != 0) { if (key->both.offset & 1) @@ -277,6 +254,7 @@ static void drop_key_refs(union futex_ke mmdrop(key->private.mm); } } +EXPORT_SYMBOL_GPL(drop_futex_key_refs); static inline int get_futex_value_locked(u32 *dest, u32 __user *from) { @@ -871,7 +849,7 @@ static int futex_requeue(u32 __user *uad this->lock_ptr = &hb2->lock; } this->key = key2; - get_key_refs(&key2); + get_futex_key_refs(&key2); drop_count++; if (ret - nr_wake >= nr_requeue) @@ -884,9 +862,9 @@ out_unlock: if (hb1 != hb2) spin_unlock(&hb2->lock); - /* drop_key_refs() must be called outside the spinlocks. */ + /* drop_futex_key_refs() must be called outside the spinlocks. */ while (--drop_count >= 0) - drop_key_refs(&key1); + drop_futex_key_refs(&key1); out: up_read(¤t->mm->mmap_sem); @@ -904,7 +882,7 @@ queue_lock(struct futex_q *q, int fd, st init_waitqueue_head(&q->waiters); - get_key_refs(&q->key); + get_futex_key_refs(&q->key); hb = hash_futex(&q->key); q->lock_ptr = &hb->lock; @@ -923,7 +901,7 @@ queue_unlock(struct futex_q *q, struct f queue_unlock(struct futex_q *q, struct futex_hash_bucket *hb) { spin_unlock(&hb->lock); - drop_key_refs(&q->key); + drop_futex_key_refs(&q->key); } /* @@ -978,7 +956,7 @@ static int unqueue_me(struct futex_q *q) ret = 1; } - drop_key_refs(&q->key); + drop_futex_key_refs(&q->key); return ret; } @@ -997,7 +975,7 @@ static void unqueue_me_pi(struct futex_q spin_unlock(&hb->lock); - drop_key_refs(&q->key); + drop_futex_key_refs(&q->key); } static int futex_wait(u32 __user *uaddr, u32 val, unsigned long time)
next prev parent reply other threads:[~2007-02-12 3:43 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-12 3:32 [PATCH 1/7] cleanup: paravirt unhandled fallthrough Rusty Russell 2007-02-12 3:33 ` [PATCH 2/7] cleanup: Initialize esp0 properly all the time Rusty Russell 2007-02-12 3:34 ` [PATCH 3/7] cleanup: Make hvc_console.c compile on non-PowerPC Rusty Russell 2007-02-12 3:35 ` [PATCH 4/7] cleanup: Move mce_disabled to asm/mce.h Rusty Russell 2007-02-12 3:36 ` [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declaration from smpboot.c Rusty Russell 2007-02-12 3:37 ` [PATCH 6/7] cleanup: Remove extern declaration from mm/discontig.c, put in header Rusty Russell 2007-02-12 3:39 ` [PATCH 7/7] cleanup: make disable_acpi() valid w/o CONFIG_ACPI Rusty Russell 2007-02-12 3:41 ` [PATCH 1/2] lguest preparation: EXPORT_SYMBOL_GPL 5 functions Rusty Russell 2007-02-12 3:42 ` Rusty Russell [this message] 2007-02-12 3:44 ` [PATCH 1/8] lguest: Kconfig and headers Rusty Russell 2007-02-12 3:46 ` [PATCH 2/8] lguest: the host code (lg.ko) Rusty Russell 2007-02-12 3:48 ` [PATCH 3/8] lguest: Guest code Rusty Russell 2007-02-12 3:50 ` [PATCH 4/8] lguest: Makefile Rusty Russell 2007-02-12 3:52 ` [PATCH 5/8] lguest: trivial guest network driver Rusty Russell 2007-02-12 3:53 ` [PATCH 6/8] lguest: trivial guest console driver Rusty Russell 2007-02-12 3:54 ` [PATCH 7/8] lguest: trivial guest block driver Rusty Russell 2007-02-12 3:55 ` [PATCH 8/8] lguest: documentatation and example launcher Rusty Russell 2007-02-12 4:43 ` [PATCH 7/8] lguest: trivial guest block driver Jens Axboe 2007-02-12 5:27 ` Rusty Russell 2007-02-12 5:32 ` Jens Axboe 2007-02-12 5:33 ` Jens Axboe 2007-02-12 7:09 ` Rusty Russell 2007-02-12 7:09 ` Rusty Russell 2007-02-12 15:01 ` Jens Axboe 2007-02-13 0:25 ` Rusty Russell 2007-02-13 0:25 ` Rusty Russell 2007-02-13 0:44 ` Jens Axboe 2007-02-12 15:55 ` [PATCH 5/8] lguest: trivial guest network driver Herbert Xu 2007-02-13 2:15 ` Rusty Russell 2007-02-13 14:06 ` Herbert Xu 2007-02-14 4:47 ` Rusty Russell 2007-02-14 13:57 ` Herbert Xu 2007-02-14 23:00 ` Rusty Russell 2007-02-12 16:02 ` [PATCH 1/8] lguest: Kconfig and headers James Morris 2007-02-13 5:09 ` [PATCH 7/7] cleanup: make disable_acpi() valid w/o CONFIG_ACPI Len Brown 2007-02-12 9:16 ` [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declaration from smpboot.c Zachary Amsden
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1171251770.10409.23.camel@localhost.localdomain \ --to=rusty@rustcorp.com.au \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=virtualization@lists.osdl.org \ --subject='Re: [PATCH 2/2] lguest preparation: expose futex infrastructure: get_futex_key, get_key_refs and drop_key_refs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.