All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] d80211: Fix wireless statistics reporting
Date: Sun, 11 Feb 2007 23:09:10 -0500	[thread overview]
Message-ID: <1171253350.27742.17.camel@dv> (raw)
In-Reply-To: <200702112209.46093.flamingice@sourmilk.net>

Hi, Michael!

On Sun, 2007-02-11 at 22:09 -0500, Michael Wu wrote:
> d80211: Fix wireless statistics reporting
> 
> This fixes statistics reporting. It allows drivers to specify what type of
> values they support, makes scan results return correct statistics, and
> generally fixes the brain damaged statistics reporting code.
> 
> Signed-off-by: Michael Wu <flamingice@sourmilk.net>
[skip]
> -	int signal;
> +	int signal; /* used as qual in statistics reporting */

I'm sorry but that the thing I have always hated about wireless
extensions.  Such tricks make the API context sensitive and loaded with
assumptions.

> +	/* Maximum values for various statistics.
> +	 * Leave at 0 to indicate no support. Use negative numbers for dBm. */

That's another context sensitive API.

I've actually worked with the hardware capable of receiving more that 0
dBm (1mW).  It had to be worked around.  Please keep in mind that Linux
is used not only on FCC approved Part 15 devices, but also on embedded
systems operating on licensed frequencies.

"One milliwatt should be enough for everyone" is an approach flawed from
the outset.  It's limiting even for existing equipment running Linux.
One megawatt would be enough though :)

Note that Jean actually added a flag to indicate that a value is in dBm
in the latest versions of Wireless Extensions.

I understand d80211 still has to interact with Wireless Extensions, but
let's not make things even worse.

-- 
Regards,
Pavel Roskin


  reply	other threads:[~2007-02-12  4:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  3:09 Michael Wu
2007-02-12  4:09 ` Pavel Roskin [this message]
2007-02-12  4:29   ` Michael Wu
2007-02-12  4:40     ` Pavel Roskin
2007-02-19 20:22 ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171253350.27742.17.camel@dv \
    --to=proski@gnu.org \
    --cc=flamingice@sourmilk.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    --subject='Re: [PATCH] d80211: Fix wireless statistics reporting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.