[Bluez-devel] [PATCH] Minor issues with sdp-xml

[Bluez-devel] [PATCH] Minor issues with sdp-xml

[Denis KENZIOR]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Marcel,

This patch fixes up a couple of minor bugs I found.

-Denis

[-- Attachment #2: sdp-xml.patch --]
[-- Type: text/x-diff, Size: 929 bytes --]

Index: sdp-xml.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-xml.c,v
retrieving revision 1.7
diff -u -r1.7 sdp-xml.c
--- sdp-xml.c	20 Jan 2007 21:28:02 -0000	1.7
+++ sdp-xml.c	6 Feb 2007 05:12:31 -0000
@@ -265,7 +265,7 @@
 		if (hex) {
 			appender(data, "encoding=\"hex\" ");
 			strBuf = (char *) malloc(sizeof(char)
-						 * (value->unitSize * 2 + 1));
+						 * ((value->unitSize-1) * 2 + 1));
 
 			/* Unit Size seems to include the size for dtd
 			   It is thus off by 1
@@ -276,7 +276,7 @@
 					"%02x",
 					(unsigned char) value->val.str[i]);
 
-			strBuf[value->unitSize * 2] = '\0';
+			strBuf[(value->unitSize-1) * 2] = '\0';
 		}
 		else {
 			int j;
@@ -603,7 +603,7 @@
 			buf[0] = data[i];
 			buf[1] = data[i + 1];
 
-			val.data[i] = strtoul(buf, 0, 16);
+			val.data[i >> 1] = strtoul(buf, 0, 16);
 		}
 
 		ret = sdp_data_alloc(dtd, &val);

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Minor issues with sdp-xml

[Stefan Seyfried]

On Tue, Feb 06, 2007 at 03:13:32PM +1000, Denis KENZIOR wrote:
> Marcel,
> =

> This patch fixes up a couple of minor bugs I found.

Thanks. Parts of this were also reported today:
https://bugzilla.novell.com/show_bug.cgi?id=3D242030

> Index: sdp-xml.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/bluez/utils/common/sdp-xml.c,v
> retrieving revision 1.7
> diff -u -r1.7 sdp-xml.c
> --- sdp-xml.c	20 Jan 2007 21:28:02 -0000	1.7
> +++ sdp-xml.c	6 Feb 2007 05:12:31 -0000
> @@ -603,7 +603,7 @@
>  			buf[0] =3D data[i];
>  			buf[1] =3D data[i + 1];
>  =

> -			val.data[i] =3D strtoul(buf, 0, 16);
> +			val.data[i >> 1] =3D strtoul(buf, 0, 16);
>  		}

This is the part that was reported as generating a compiler warning.
-- =

Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg  | "Well, surrounding them's out." =


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easi=
er.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1=
21642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Minor issues with sdp-xml

[Marcel Holtmann]

Hi Denis,

> This patch fixes up a couple of minor bugs I found.

the patch has been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[Bluez-devel] Linux Distribution for Bluez

[enigma enu]

[-- Attachment #1.1: Type: text/plain, Size: 1055 bytes --]

Hi ,

I am a newbie to Bluetooth Development using Linux. Which Linux Distribution is the best to use to with the BlueZ Linux protocol stack,

thanks for your replies and suggestions,

regards,

Mark.

Marcel Holtmann <marcel@holtmann.org> wrote: Hi Denis,

> This patch fixes up a couple of minor bugs I found.

the patch has been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel


 
---------------------------------
Never miss an email again!
Yahoo! Toolbar alerts you the instant new Mail arrives. Check it out.

[-- Attachment #1.2: Type: text/html, Size: 1503 bytes --]

[-- Attachment #2: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Linux Distribution for Bluez

[Marcel Holtmann]

Hi,

don't hi-jack threads with a different topic.

> I am a newbie to Bluetooth Development using Linux. Which Linux
> Distribution is the best to use to with the BlueZ Linux protocol
> stack,

Actually all distros are usable. The question is which one is more
up-to-date than others. All of them have at least bluez-utils-3.7 and I
think there exists pending update to bluez-utils-3.9 for Fedora Core 6.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Linux Distribution for Bluez

[enigma enu]

[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

thank you Marcel for the reply. I apologise for hijacking of a thread with different topic.

regards,

mark.

Marcel Holtmann <marcel@holtmann.org> wrote: Hi,

don't hi-jack threads with a different topic.

> I am a newbie to Bluetooth Development using Linux. Which Linux
> Distribution is the best to use to with the BlueZ Linux protocol
> stack,

Actually all distros are usable. The question is which one is more
up-to-date than others. All of them have at least bluez-utils-3.7 and I
think there exists pending update to bluez-utils-3.9 for Fedora Core 6.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel


 
---------------------------------
Now that's room service! Choose from over 150,000 hotels 
in 45,000 destinations on Yahoo! Travel to find your fit.

[-- Attachment #1.2: Type: text/html, Size: 1683 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel