* UBI: What's the correct assert condition in write_leb function in upd.c
@ 2007-02-14 8:28 Kyungmin Park
2007-02-14 8:55 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2007-02-14 8:28 UTC (permalink / raw)
To: linux-mtd
Hi,
I think it's wrong assert condition in write_leb function in upd.c
What's the correct assert condition?
Thank you,
Kyungmin Park
diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c
index 1359ca4..09e394a 100644
--- a/drivers/mtd/ubi/upd.c
+++ b/drivers/mtd/ubi/upd.c
@@ -364,7 +364,7 @@ static int write_leb(const struct ubi_info *ubi, int
vol_id, int lnum,
if (vtr->vol_type == UBI_DYNAMIC_VOLUME) {
size_t l;
- ubi_assert(len = vtr->usable_leb_size);
+ ubi_assert(len == vtr->usable_leb_size);
/* This is dynamic volume - skip the ending 0xFFs */
l = ubi_calc_data_len(ubi, buf, len);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: UBI: What's the correct assert condition in write_leb function in upd.c
2007-02-14 8:28 UBI: What's the correct assert condition in write_leb function in upd.c Kyungmin Park
@ 2007-02-14 8:55 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2007-02-14 8:55 UTC (permalink / raw)
To: kmpark; +Cc: linux-mtd
On Wed, 2007-02-14 at 17:28 +0900, Kyungmin Park wrote:
> I think it's wrong assert condition in write_leb function in upd.c
> What's the correct assert condition?
Sure, thanks!
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-14 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-14 8:28 UBI: What's the correct assert condition in write_leb function in upd.c Kyungmin Park
2007-02-14 8:55 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.