* [PATCH] UBI: fix typo and wrong comments
@ 2007-02-14 9:05 Kyungmin Park
2007-02-14 10:16 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Kyungmin Park @ 2007-02-14 9:05 UTC (permalink / raw)
To: linux-mtd
Hi,
Here's some fix of typo and wrong comments.
Thank you,
Kyungmin Park
diff --git a/drivers/mtd/ubi/gluebi.c b/drivers/mtd/ubi/gluebi.c
index 63def5d..d396c59 100644
--- a/drivers/mtd/ubi/gluebi.c
+++ b/drivers/mtd/ubi/gluebi.c
@@ -168,8 +168,7 @@ static int gluebi_get_device(struct mtd_info *mtd)
*
* @mtd: the MTD device description object
*
- * This function is called every time the MTD device is being put. Returns
- * zero in case of success and a negative error code in case of failure.
+ * This function is called every time the MTD device is being put.
*/
static void gluebi_put_device(struct mtd_info *mtd)
{
diff --git a/drivers/mtd/ubi/scan.c b/drivers/mtd/ubi/scan.c
index c433ded..5142baf 100644
--- a/drivers/mtd/ubi/scan.c
+++ b/drivers/mtd/ubi/scan.c
@@ -767,7 +767,7 @@ static struct ubi_scan_volume *add_volume(const struct
ubi_info *ubi,
* o bit 1 is cleared: no bit-flips were detected in the newer PEB;
* o bit 1 is set: bit-flips were detected in the newer PEB;
* o bit 2 is cleared: the older PEB is not corrupted;
- * o bit 2 is set: the older PEB is not corrupted.
+ * o bit 2 is set: the older PEB is corrupted.
*/
static int compare_lebs(const struct ubi_info *ubi,
const struct ubi_scan_leb *seb, int pnum,
diff --git a/drivers/mtd/ubi/uif.c b/drivers/mtd/ubi/uif.c
index bdce784..65b6865 100644
--- a/drivers/mtd/ubi/uif.c
+++ b/drivers/mtd/ubi/uif.c
@@ -508,7 +508,7 @@ int ubi_eraseblock_unmap(struct ubi_vol_desc *udesc,
int lnum)
const struct ubi_info *ubi = desc->vol->ubi;
int err, vol_id = desc->vol->vol_id;
- dbg_uif("erase LEB %d:%d", vol_id, lnum);
+ dbg_uif("unmap LEB %d:%d", vol_id, lnum);
vtr = ubi_vtbl_get_vtr(ubi, vol_id);
ubi_assert(!IS_ERR(vtr));
diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index d657cf6..5dc9951 100644
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -643,7 +643,7 @@ static struct ubi_vol_tbl_record *process_lvol(const
struct ubi_info *ubi,
* recent information.
*
* So the plan is to first check LEB 0. Then
- * a. if LEB 0 is OK, it contains the most resent data; then we
+ * a. if LEB 0 is OK, it contains the most recent data; then we
* compare its contents with LEB 1, and if they are different, we
copy
* LEB 0 to LEB 1.
* b. if LEB 0 is corrupted, but LEB 1 is OK, we copy LEB 1 to LEB
0.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] UBI: fix typo and wrong comments
2007-02-14 9:05 [PATCH] UBI: fix typo and wrong comments Kyungmin Park
@ 2007-02-14 10:16 ` Artem Bityutskiy
2007-02-15 1:05 ` Kyungmin Park
0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2007-02-14 10:16 UTC (permalink / raw)
To: kmpark; +Cc: linux-mtd
Kyungmin,
On Wed, 2007-02-14 at 18:05 +0900, Kyungmin Park wrote:
> Hi,
>
> Here's some fix of typo and wrong comments.
Thanks for patches, they look good but they are corrupted and I cannot
apply them. If you use evolution, select "Preformat" instead of Normal,
then Insert->Text file to insert your patch, then it is not corrupted.
Also, please, add Signed-off-by.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] UBI: fix typo and wrong comments
2007-02-14 10:16 ` Artem Bityutskiy
@ 2007-02-15 1:05 ` Kyungmin Park
2007-02-15 14:47 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Kyungmin Park @ 2007-02-15 1:05 UTC (permalink / raw)
To: dedekind; +Cc: linux-mtd
>From 116743c0db0bfaac73d1d5b302a67bbb2231f8a1 Mon Sep 17 00:00:00 2001
From: Kyungmin Park <kyungmin.park@samsung.com>
Date: Thu, 15 Feb 2007 10:00:42 +0900
Subject: [PATCH] UBI: fix typo & wrong comments
fix typo & wrong comments
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mtd/ubi/gluebi.c | 3 +--
drivers/mtd/ubi/scan.c | 2 +-
drivers/mtd/ubi/uif.c | 2 +-
drivers/mtd/ubi/vtbl.c | 2 +-
4 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/ubi/gluebi.c b/drivers/mtd/ubi/gluebi.c
index 63def5d..d396c59 100644
--- a/drivers/mtd/ubi/gluebi.c
+++ b/drivers/mtd/ubi/gluebi.c
@@ -168,8 +168,7 @@ static int gluebi_get_device(struct mtd_info *mtd)
*
* @mtd: the MTD device description object
*
- * This function is called every time the MTD device is being put. Returns
- * zero in case of success and a negative error code in case of failure.
+ * This function is called every time the MTD device is being put.
*/
static void gluebi_put_device(struct mtd_info *mtd)
{
diff --git a/drivers/mtd/ubi/scan.c b/drivers/mtd/ubi/scan.c
index c695b81..9e77a3a 100644
--- a/drivers/mtd/ubi/scan.c
+++ b/drivers/mtd/ubi/scan.c
@@ -767,7 +767,7 @@ static struct ubi_scan_volume *add_volume(const struct
ubi_info *ubi,
* o bit 1 is cleared: no bit-flips were detected in the newer PEB;
* o bit 1 is set: bit-flips were detected in the newer PEB;
* o bit 2 is cleared: the older PEB is not corrupted;
- * o bit 2 is set: the older PEB is not corrupted.
+ * o bit 2 is set: the older PEB is corrupted.
*/
static int compare_lebs(const struct ubi_info *ubi,
const struct ubi_scan_leb *seb, int pnum,
diff --git a/drivers/mtd/ubi/uif.c b/drivers/mtd/ubi/uif.c
index bdce784..65b6865 100644
--- a/drivers/mtd/ubi/uif.c
+++ b/drivers/mtd/ubi/uif.c
@@ -508,7 +508,7 @@ int ubi_eraseblock_unmap(struct ubi_vol_desc *udesc,
int lnum)
const struct ubi_info *ubi = desc->vol->ubi;
int err, vol_id = desc->vol->vol_id;
- dbg_uif("erase LEB %d:%d", vol_id, lnum);
+ dbg_uif("unmap LEB %d:%d", vol_id, lnum);
vtr = ubi_vtbl_get_vtr(ubi, vol_id);
ubi_assert(!IS_ERR(vtr));
diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index ac48c7d..9d9d98d 100644
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -645,7 +645,7 @@ static struct ubi_vol_tbl_record *process_lvol(const
struct ubi_info *ubi,
* recent information.
*
* So the plan is to first check LEB 0. Then
- * a. if LEB 0 is OK, it contains the most resent data; then we
+ * a. if LEB 0 is OK, it contains the most recent data; then we
* compare its contents with LEB 1, and if they are different, we
copy
* LEB 0 to LEB 1.
* b. if LEB 0 is corrupted, but LEB 1 is OK, we copy LEB 1 to LEB
0.
--
1.4.4.2
>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] UBI: fix typo and wrong comments
2007-02-15 1:05 ` Kyungmin Park
@ 2007-02-15 14:47 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2007-02-15 14:47 UTC (permalink / raw)
To: kmpark; +Cc: linux-mtd
On Thu, 2007-02-15 at 10:05 +0900, Kyungmin Park wrote:
> >From 116743c0db0bfaac73d1d5b302a67bbb2231f8a1 Mon Sep 17 00:00:00 2001
> From: Kyungmin Park <kyungmin.park@samsung.com>
> Date: Thu, 15 Feb 2007 10:00:42 +0900
> Subject: [PATCH] UBI: fix typo & wrong comments
Applying 'UBI: fix typo & wrong comments'
fatal: corrupt patch at line 27
Patch failed at 0001.
When you have resolved this problem run "git-am -i --resolved".
If you would prefer to skip this patch, instead run "git-am -i --skip".
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-02-15 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-14 9:05 [PATCH] UBI: fix typo and wrong comments Kyungmin Park
2007-02-14 10:16 ` Artem Bityutskiy
2007-02-15 1:05 ` Kyungmin Park
2007-02-15 14:47 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.