* [PATCH 2/3] slab: export ksize to modules
@ 2007-02-21 8:06 Pekka J Enberg
2007-02-21 8:14 ` Muli Ben-Yehuda
2007-02-21 8:56 ` Arjan van de Ven
0 siblings, 2 replies; 6+ messages in thread
From: Pekka J Enberg @ 2007-02-21 8:06 UTC (permalink / raw)
To: akpm; +Cc: clameter, linux-kernel, jsipek, unionfs, bunk, hooanon05
From: Pekka Enberg <penberg@cs.helsinki.fi>
This exports ksize in slab and slob allocators to modules.
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
mm/slab.c | 1 +
mm/slob.c | 2 ++
2 files changed, 3 insertions(+)
Index: 2.6/mm/slab.c
===================================================================
--- 2.6.orig/mm/slab.c 2007-02-21 09:46:16.000000000 +0200
+++ 2.6/mm/slab.c 2007-02-21 09:46:25.000000000 +0200
@@ -4485,3 +4485,4 @@
return obj_size(virt_to_cache(objp));
}
+EXPORT_SYMBOL(ksize);
Index: 2.6/mm/slob.c
===================================================================
--- 2.6.orig/mm/slob.c 2007-02-21 09:46:28.000000000 +0200
+++ 2.6/mm/slob.c 2007-02-21 09:46:42.000000000 +0200
@@ -240,6 +240,8 @@
return ((slob_t *)block - 1)->units * SLOB_UNIT;
}
+EXPORT_SYMBOL(ksize);
+
struct kmem_cache {
unsigned int size, align;
const char *name;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] slab: export ksize to modules
2007-02-21 8:06 [PATCH 2/3] slab: export ksize to modules Pekka J Enberg
@ 2007-02-21 8:14 ` Muli Ben-Yehuda
2007-02-21 8:22 ` Pekka J Enberg
2007-02-21 18:33 ` Christoph Lameter
2007-02-21 8:56 ` Arjan van de Ven
1 sibling, 2 replies; 6+ messages in thread
From: Muli Ben-Yehuda @ 2007-02-21 8:14 UTC (permalink / raw)
To: Pekka J Enberg
Cc: akpm, clameter, linux-kernel, jsipek, unionfs, bunk, hooanon05
On Wed, Feb 21, 2007 at 10:06:52AM +0200, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This exports ksize in slab and slob allocators to modules.
That's a pretty generic name... if it's going to be part of the module
API, it should be renamed to something a bit more obvious.
Cheers,
Muli
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] slab: export ksize to modules
2007-02-21 8:14 ` Muli Ben-Yehuda
@ 2007-02-21 8:22 ` Pekka J Enberg
2007-02-21 18:33 ` Christoph Lameter
1 sibling, 0 replies; 6+ messages in thread
From: Pekka J Enberg @ 2007-02-21 8:22 UTC (permalink / raw)
To: Muli Ben-Yehuda
Cc: akpm, clameter, linux-kernel, jsipek, unionfs, bunk, hooanon05
Hi Muli,
On Wed, Feb 21, 2007 at 10:06:52AM +0200, Pekka J Enberg wrote:
> > This exports ksize in slab and slob allocators to modules.
On Wed, 21 Feb 2007, Muli Ben-Yehuda wrote:
> That's a pretty generic name... if it's going to be part of the module
> API, it should be renamed to something a bit more obvious.
Well, it is the established slab API so I am bit relucant to change it.
But if someone comes up with a better name, why not...
Pekka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] slab: export ksize to modules
2007-02-21 8:06 [PATCH 2/3] slab: export ksize to modules Pekka J Enberg
2007-02-21 8:14 ` Muli Ben-Yehuda
@ 2007-02-21 8:56 ` Arjan van de Ven
2007-02-21 9:03 ` Pekka J Enberg
1 sibling, 1 reply; 6+ messages in thread
From: Arjan van de Ven @ 2007-02-21 8:56 UTC (permalink / raw)
To: Pekka J Enberg
Cc: akpm, clameter, linux-kernel, jsipek, unionfs, bunk, hooanon05
On Wed, 2007-02-21 at 10:06 +0200, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This exports ksize in slab and slob allocators to modules.
what's the user of this? If none, don't export it please since every
useless export does take up space.
Please specify the use in the description of the patch!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] slab: export ksize to modules
2007-02-21 8:56 ` Arjan van de Ven
@ 2007-02-21 9:03 ` Pekka J Enberg
0 siblings, 0 replies; 6+ messages in thread
From: Pekka J Enberg @ 2007-02-21 9:03 UTC (permalink / raw)
To: Arjan van de Ven
Cc: akpm, clameter, linux-kernel, jsipek, unionfs, bunk, hooanon05
On Wed, 21 Feb 2007, Arjan van de Ven wrote:
> Please specify the use in the description of the patch!
See [PATCH 3/3] unionfs: fix up slab abuses.
Pekka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] slab: export ksize to modules
2007-02-21 8:14 ` Muli Ben-Yehuda
2007-02-21 8:22 ` Pekka J Enberg
@ 2007-02-21 18:33 ` Christoph Lameter
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2007-02-21 18:33 UTC (permalink / raw)
To: Muli Ben-Yehuda
Cc: Pekka J Enberg, akpm, linux-kernel, jsipek, unionfs, bunk, hooanon05
On Wed, 21 Feb 2007, Muli Ben-Yehuda wrote:
> On Wed, Feb 21, 2007 at 10:06:52AM +0200, Pekka J Enberg wrote:
> > From: Pekka Enberg <penberg@cs.helsinki.fi>
> >
> > This exports ksize in slab and slob allocators to modules.
>
> That's a pretty generic name... if it's going to be part of the module
> API, it should be renamed to something a bit more obvious.
Hmmm... The current names are
kmalloc
kcalloc
kzalloc
kfree
ksize
All are pretty terse and most are frequently used (except ksize and
maybe kcalloc).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-21 18:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-21 8:06 [PATCH 2/3] slab: export ksize to modules Pekka J Enberg
2007-02-21 8:14 ` Muli Ben-Yehuda
2007-02-21 8:22 ` Pekka J Enberg
2007-02-21 18:33 ` Christoph Lameter
2007-02-21 8:56 ` Arjan van de Ven
2007-02-21 9:03 ` Pekka J Enberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.