* [PATCH] aoa: fix a sparse warning
@ 2007-02-26 23:23 Johannes Berg
2007-03-08 13:51 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2007-02-26 23:23 UTC (permalink / raw)
To: Takashi Iwai; +Cc: ALSA development
This fixes a warning sparse gives.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
There are more sparse warnings but they're about signedness where I
explicitly need to get signed values from the hw but the functions are
declared unsigned because I also need unsigned values sometimes...
sound/aoa/soundbus/core.c | 2 --
sound/aoa/soundbus/soundbus.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
--- wireless-dev.orig/sound/aoa/soundbus/core.c 2007-02-27 00:18:47.534692803 +0100
+++ wireless-dev/sound/aoa/soundbus/core.c 2007-02-27 00:18:52.994692803 +0100
@@ -179,8 +179,6 @@ static int soundbus_device_resume(struct
#endif /* CONFIG_PM */
-extern struct device_attribute soundbus_dev_attrs[];
-
static struct bus_type soundbus_bus_type = {
.name = "aoa-soundbus",
.probe = soundbus_probe,
--- wireless-dev.orig/sound/aoa/soundbus/soundbus.h 2007-02-27 00:17:50.574692803 +0100
+++ wireless-dev/sound/aoa/soundbus/soundbus.h 2007-02-27 00:18:58.224692803 +0100
@@ -199,4 +199,6 @@ struct soundbus_driver {
extern int soundbus_register_driver(struct soundbus_driver *drv);
extern void soundbus_unregister_driver(struct soundbus_driver *drv);
+extern struct device_attribute soundbus_dev_attrs[];
+
#endif /* __SOUNDBUS_H */
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] aoa: fix a sparse warning
2007-02-26 23:23 [PATCH] aoa: fix a sparse warning Johannes Berg
@ 2007-03-08 13:51 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-03-08 13:51 UTC (permalink / raw)
To: Johannes Berg; +Cc: ALSA development
At Tue, 27 Feb 2007 00:23:59 +0100,
Johannes Berg wrote:
>
> This fixes a warning sparse gives.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Applied on ALSA HG tree now. Thanks.
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-08 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-26 23:23 [PATCH] aoa: fix a sparse warning Johannes Berg
2007-03-08 13:51 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.