* [PATCH] powerpc: fix dcr_unmap()
@ 2007-03-28 10:07 Jean-Christophe Dubois
2007-03-28 12:42 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe Dubois @ 2007-03-28 10:07 UTC (permalink / raw)
To: linuxppc-dev
Fix a bug in dcr_unmap().
At unmap time the DCR offset need to be added instead of substracted.
Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
===================================================================
--- linux-2.6.20.orig/arch/powerpc/sysdev/dcr.c
+++ linux-2.6.20/arch/powerpc/sysdev/dcr.c
@@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
if (h.token == NULL)
return;
- h.token -= dcr_n * h.stride;
+ h.token += dcr_n * h.stride;
iounmap(h.token);
h.token = NULL;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: fix dcr_unmap()
2007-03-28 10:07 [PATCH] powerpc: fix dcr_unmap() Jean-Christophe Dubois
@ 2007-03-28 12:42 ` Benjamin Herrenschmidt
2007-03-28 20:55 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2007-03-28 12:42 UTC (permalink / raw)
To: Jean-Christophe Dubois; +Cc: linuxppc-dev, Linus Torvalds
On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> Fix a bug in dcr_unmap().
>
> At unmap time the DCR offset need to be added instead of substracted.
>
> Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
If possible that should go in 2.6.21
> Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
> ===================================================================
> --- linux-2.6.20.orig/arch/powerpc/sysdev/dcr.c
> +++ linux-2.6.20/arch/powerpc/sysdev/dcr.c
> @@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
>
> if (h.token == NULL)
> return;
> - h.token -= dcr_n * h.stride;
> + h.token += dcr_n * h.stride;
> iounmap(h.token);
> h.token = NULL;
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: fix dcr_unmap()
2007-03-28 12:42 ` Benjamin Herrenschmidt
@ 2007-03-28 20:55 ` Linus Torvalds
2007-03-28 22:24 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2007-03-28 20:55 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Wed, 28 Mar 2007, Benjamin Herrenschmidt wrote:
> On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> > Fix a bug in dcr_unmap().
> >
> > At unmap time the DCR offset need to be added instead of substracted.
> >
> > Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> If possible that should go in 2.6.21
Can I get an original patch email and/or a git pull request? I didn't see
the original email, since I'm not on the linuxppc list..
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: fix dcr_unmap()
2007-03-28 20:55 ` Linus Torvalds
@ 2007-03-28 22:24 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2007-03-28 22:24 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linuxppc-dev
On Wed, 2007-03-28 at 13:55 -0700, Linus Torvalds wrote:
>
> On Wed, 28 Mar 2007, Benjamin Herrenschmidt wrote:
>
> > On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> > > Fix a bug in dcr_unmap().
> > >
> > > At unmap time the DCR offset need to be added instead of substracted.
> > >
> > > Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
> >
> > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >
> > If possible that should go in 2.6.21
>
> Can I get an original patch email and/or a git pull request? I didn't see
> the original email, since I'm not on the linuxppc list..
Sorry about that, I'll bounce it to you
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-28 22:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-28 10:07 [PATCH] powerpc: fix dcr_unmap() Jean-Christophe Dubois
2007-03-28 12:42 ` Benjamin Herrenschmidt
2007-03-28 20:55 ` Linus Torvalds
2007-03-28 22:24 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.