All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Longhaul - Revert ACPI C3 on Longhaul ver. 2
@ 2007-04-19  6:28 Rafal Bilski
  0 siblings, 0 replies; 3+ messages in thread
From: Rafal Bilski @ 2007-04-19  6:28 UTC (permalink / raw)
  To: Dave Jones; +Cc: cpufreq

Support for Longhaul ver. 2 broke driver for VIA C3 Eden
600MHz with Samuel 2 core. Processor is not able to switch
frequency anymore. I don't know much about this issue at
the moment, but until (if ever) I will know why, this part
should be reversed. I hope it isn't to late to include it in
2.6.21.

Signed-off-by: Rafal Bilski <rafalbilski@interia.pl>
---
 arch/i386/kernel/cpu/cpufreq/longhaul.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/cpu/cpufreq/longhaul.c b/arch/i386/kernel/cpu/cpufreq/longhaul.c
index a1f1b71..2b030d6 100644
--- a/arch/i386/kernel/cpu/cpufreq/longhaul.c
+++ b/arch/i386/kernel/cpu/cpufreq/longhaul.c
@@ -758,7 +758,7 @@ static int __init longhaul_cpu_init(struct cpufreq_policy *policy)
 				NULL, (void *)&pr);
 
 	/* Check ACPI support for C3 state */
-	if (pr != NULL && longhaul_version != TYPE_LONGHAUL_V1) {
+	if (pr != NULL && longhaul_version == TYPE_POWERSAVER) {
 		cx = &pr->power.states[ACPI_STATE_C3];
 		if (cx->address > 0 && cx->latency <= 1000) {
 			longhaul_flags |= USE_ACPI_C3;
-- 
1.5.0.6


----------------------------------------------------------------------
Playery MP3 za drogie?
Sprawdz, kto ma najtaniej >> http://link.interia.pl/f1a63

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Longhaul - Revert ACPI C3 on Longhaul ver. 2
  2007-04-21 14:40 Rafał Bilski
@ 2007-04-21 19:44 ` Dave Jones
  0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2007-04-21 19:44 UTC (permalink / raw)
  To: Rafał Bilski; +Cc: cpufreq, Linus Torvalds

On Sat, Apr 21, 2007 at 04:40:09PM +0200, Rafał Bilski wrote:
 > Please ignore. It isn't fixing anything. I don't 
 > know at the moment if ver. 2 support is to blame, 
 > or frequency test is doing it's job and it is 
 > returning correct CPU frequency.

gah, this went to linus yesterday, hopefully he hasn't applied it yet.

	Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Longhaul - Revert ACPI C3 on Longhaul ver. 2
@ 2007-04-21 14:40 Rafał Bilski
  2007-04-21 19:44 ` Dave Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Rafał Bilski @ 2007-04-21 14:40 UTC (permalink / raw)
  To: Dave Jones; +Cc: cpufreq

Please ignore. It isn't fixing anything. I don't 
know at the moment if ver. 2 support is to blame, 
or frequency test is doing it's job and it is 
returning correct CPU frequency.

Rafa³


----------------------------------------------------------------------
Dziecko - instrukcja obs³ugi
>>> http://link.interia.pl/f1a51

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-04-21 19:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-19  6:28 [PATCH] Longhaul - Revert ACPI C3 on Longhaul ver. 2 Rafal Bilski
2007-04-21 14:40 Rafał Bilski
2007-04-21 19:44 ` Dave Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.