* [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 8:56 ` Matthew Auld
0 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-11 8:56 UTC (permalink / raw)
To: intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, Christian König,
dri-devel, Nirmoy Das
If we hit the sync case, like when skipping clearing for kernel internal
objects, or when falling back to cpu clearing, like in i915, we end up
trying to add a NULL fence, but with some recent changes in this area
this now just results in NULL deref in dma_resv_add_fence:
<1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
<1>[ 5.466384] #PF: supervisor read access in kernel mode
<1>[ 5.466385] #PF: error_code(0x0000) - not-present page
<6>[ 5.466386] PGD 0 P4D 0
<4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
<4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
<4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
<4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
<4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
<4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
<4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
<4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
<4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
<4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
<4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
<4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
<4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
<4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
<4>[ 5.466404] Call Trace:
<4>[ 5.466405] <TASK>
<4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
<4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
<4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
<4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
<4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
<4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
<4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
<4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
<4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
<4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
<4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
<4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
<4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
<4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
<4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
<4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
<4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
In the ttm_bo_move_sync_cleanup() case it seems we only really care
about calling ttm_bo_wait_free_node(), so let's instead just call that
directly.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
---
drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
include/drm/ttm/ttm_bo_driver.h | 11 +++--------
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
index bc5190340b9c..1cbfb00c1d65 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_util.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
@@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
}
EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
+void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
+ struct ttm_resource *new_mem)
+{
+ struct ttm_device *bdev = bo->bdev;
+ struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
+ int ret;
+
+ ret = ttm_bo_wait_free_node(bo, man->use_tt);
+ if (WARN_ON(ret))
+ return;
+
+ ttm_bo_assign_mem(bo, new_mem);
+}
+EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
+
/**
* ttm_bo_pipeline_gutting - purge the contents of a bo
* @bo: The buffer object
diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index 059a595e14e5..897b88f0bd59 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
struct ttm_resource *new_mem);
/**
- * ttm_bo_move_accel_cleanup.
+ * ttm_bo_move_sync_cleanup.
*
* @bo: A pointer to a struct ttm_buffer_object.
* @new_mem: struct ttm_resource indicating where to move.
@@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
* Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
* by the caller to be idle. Typically used after memcpy buffer moves.
*/
-static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
- struct ttm_resource *new_mem)
-{
- int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
-
- WARN_ON(ret);
-}
+void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
+ struct ttm_resource *new_mem);
/**
* ttm_bo_pipeline_gutting.
--
2.34.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 8:56 ` Matthew Auld
0 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-11 8:56 UTC (permalink / raw)
To: intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, Christian König, dri-devel
If we hit the sync case, like when skipping clearing for kernel internal
objects, or when falling back to cpu clearing, like in i915, we end up
trying to add a NULL fence, but with some recent changes in this area
this now just results in NULL deref in dma_resv_add_fence:
<1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
<1>[ 5.466384] #PF: supervisor read access in kernel mode
<1>[ 5.466385] #PF: error_code(0x0000) - not-present page
<6>[ 5.466386] PGD 0 P4D 0
<4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
<4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
<4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
<4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
<4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
<4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
<4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
<4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
<4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
<4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
<4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
<4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
<4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
<4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
<4>[ 5.466404] Call Trace:
<4>[ 5.466405] <TASK>
<4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
<4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
<4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
<4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
<4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
<4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
<4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
<4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
<4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
<4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
<4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
<4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
<4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
<4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
<4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
<4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
<4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
In the ttm_bo_move_sync_cleanup() case it seems we only really care
about calling ttm_bo_wait_free_node(), so let's instead just call that
directly.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
---
drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
include/drm/ttm/ttm_bo_driver.h | 11 +++--------
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
index bc5190340b9c..1cbfb00c1d65 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_util.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
@@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
}
EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
+void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
+ struct ttm_resource *new_mem)
+{
+ struct ttm_device *bdev = bo->bdev;
+ struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
+ int ret;
+
+ ret = ttm_bo_wait_free_node(bo, man->use_tt);
+ if (WARN_ON(ret))
+ return;
+
+ ttm_bo_assign_mem(bo, new_mem);
+}
+EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
+
/**
* ttm_bo_pipeline_gutting - purge the contents of a bo
* @bo: The buffer object
diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index 059a595e14e5..897b88f0bd59 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
struct ttm_resource *new_mem);
/**
- * ttm_bo_move_accel_cleanup.
+ * ttm_bo_move_sync_cleanup.
*
* @bo: A pointer to a struct ttm_buffer_object.
* @new_mem: struct ttm_resource indicating where to move.
@@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
* Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
* by the caller to be idle. Typically used after memcpy buffer moves.
*/
-static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
- struct ttm_resource *new_mem)
-{
- int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
-
- WARN_ON(ret);
-}
+void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
+ struct ttm_resource *new_mem);
/**
* ttm_bo_pipeline_gutting.
--
2.34.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
@ 2022-04-11 9:56 ` Thomas Hellström
-1 siblings, 0 replies; 20+ messages in thread
From: Thomas Hellström @ 2022-04-11 9:56 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
Cc: Nirmoy Das, Lucas De Marchi, Christian König, dri-devel
Hi, Matthew
On 4/11/22 10:56, Matthew Auld wrote:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
I don't think this will help in the case where we call
ttm_bo_move_accel_cleanup() with a NULL fence....
Perhaps we need to fix it there.
/Thomas
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 9:56 ` Thomas Hellström
0 siblings, 0 replies; 20+ messages in thread
From: Thomas Hellström @ 2022-04-11 9:56 UTC (permalink / raw)
To: Matthew Auld, intel-gfx; +Cc: Lucas De Marchi, Christian König, dri-devel
Hi, Matthew
On 4/11/22 10:56, Matthew Auld wrote:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
I don't think this will help in the case where we call
ttm_bo_move_accel_cleanup() with a NULL fence....
Perhaps we need to fix it there.
/Thomas
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 9:56 ` [Intel-gfx] " Thomas Hellström
@ 2022-04-11 10:06 ` Matthew Auld
-1 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-11 10:06 UTC (permalink / raw)
To: Thomas Hellström, intel-gfx
Cc: Nirmoy Das, Lucas De Marchi, Christian König, dri-devel
On 11/04/2022 10:56, Thomas Hellström wrote:
> Hi, Matthew
>
> On 4/11/22 10:56, Matthew Auld wrote:
>> If we hit the sync case, like when skipping clearing for kernel internal
>> objects, or when falling back to cpu clearing, like in i915, we end up
>> trying to add a NULL fence, but with some recent changes in this area
>> this now just results in NULL deref in dma_resv_add_fence:
>>
>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>> 0000000000000008
>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>> <6>[ 5.466386] PGD 0 P4D 0
>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60
>> a5 0a 82
>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>> 00000000ffffffff
>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>> ffffffff8233f087
>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>> 0000000000000001
>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>> 0000000000000000
>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>> ffff88810a88d600
>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>> 00000000003706e0
>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>> 0000000000000000
>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>> 0000000000000400
>> <4>[ 5.466404] Call Trace:
>> <4>[ 5.466405] <TASK>
>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>> [i915]
>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>
>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>> directly.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>> ---
>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> index bc5190340b9c..1cbfb00c1d65 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> }
>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem)
>> +{
>> + struct ttm_device *bdev = bo->bdev;
>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>> new_mem->mem_type);
>> + int ret;
>> +
>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>> + if (WARN_ON(ret))
>> + return;
>> +
>> + ttm_bo_assign_mem(bo, new_mem);
>> +}
>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>
> I don't think this will help in the case where we call
> ttm_bo_move_accel_cleanup() with a NULL fence....
Hmm, do you know if that case actually exists? I thought the only
current user passing fence == NULL was ttm_bo_move_sync_cleanup().
>
> Perhaps we need to fix it there.
>
> /Thomas
>
>
>
>> +
>> /**
>> * ttm_bo_pipeline_gutting - purge the contents of a bo
>> * @bo: The buffer object
>> diff --git a/include/drm/ttm/ttm_bo_driver.h
>> b/include/drm/ttm/ttm_bo_driver.h
>> index 059a595e14e5..897b88f0bd59 100644
>> --- a/include/drm/ttm/ttm_bo_driver.h
>> +++ b/include/drm/ttm/ttm_bo_driver.h
>> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> struct ttm_resource *new_mem);
>> /**
>> - * ttm_bo_move_accel_cleanup.
>> + * ttm_bo_move_sync_cleanup.
>> *
>> * @bo: A pointer to a struct ttm_buffer_object.
>> * @new_mem: struct ttm_resource indicating where to move.
>> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
>> * by the caller to be idle. Typically used after memcpy buffer moves.
>> */
>> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object
>> *bo,
>> - struct ttm_resource *new_mem)
>> -{
>> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
>> -
>> - WARN_ON(ret);
>> -}
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem);
>> /**
>> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 10:06 ` Matthew Auld
0 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-11 10:06 UTC (permalink / raw)
To: Thomas Hellström, intel-gfx
Cc: Lucas De Marchi, Christian König, dri-devel
On 11/04/2022 10:56, Thomas Hellström wrote:
> Hi, Matthew
>
> On 4/11/22 10:56, Matthew Auld wrote:
>> If we hit the sync case, like when skipping clearing for kernel internal
>> objects, or when falling back to cpu clearing, like in i915, we end up
>> trying to add a NULL fence, but with some recent changes in this area
>> this now just results in NULL deref in dma_resv_add_fence:
>>
>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>> 0000000000000008
>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>> <6>[ 5.466386] PGD 0 P4D 0
>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60
>> a5 0a 82
>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>> 00000000ffffffff
>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>> ffffffff8233f087
>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>> 0000000000000001
>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>> 0000000000000000
>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>> ffff88810a88d600
>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>> 00000000003706e0
>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>> 0000000000000000
>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>> 0000000000000400
>> <4>[ 5.466404] Call Trace:
>> <4>[ 5.466405] <TASK>
>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>> [i915]
>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>
>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>> directly.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>> ---
>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> index bc5190340b9c..1cbfb00c1d65 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> }
>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem)
>> +{
>> + struct ttm_device *bdev = bo->bdev;
>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>> new_mem->mem_type);
>> + int ret;
>> +
>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>> + if (WARN_ON(ret))
>> + return;
>> +
>> + ttm_bo_assign_mem(bo, new_mem);
>> +}
>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>
> I don't think this will help in the case where we call
> ttm_bo_move_accel_cleanup() with a NULL fence....
Hmm, do you know if that case actually exists? I thought the only
current user passing fence == NULL was ttm_bo_move_sync_cleanup().
>
> Perhaps we need to fix it there.
>
> /Thomas
>
>
>
>> +
>> /**
>> * ttm_bo_pipeline_gutting - purge the contents of a bo
>> * @bo: The buffer object
>> diff --git a/include/drm/ttm/ttm_bo_driver.h
>> b/include/drm/ttm/ttm_bo_driver.h
>> index 059a595e14e5..897b88f0bd59 100644
>> --- a/include/drm/ttm/ttm_bo_driver.h
>> +++ b/include/drm/ttm/ttm_bo_driver.h
>> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> struct ttm_resource *new_mem);
>> /**
>> - * ttm_bo_move_accel_cleanup.
>> + * ttm_bo_move_sync_cleanup.
>> *
>> * @bo: A pointer to a struct ttm_buffer_object.
>> * @new_mem: struct ttm_resource indicating where to move.
>> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
>> * by the caller to be idle. Typically used after memcpy buffer moves.
>> */
>> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object
>> *bo,
>> - struct ttm_resource *new_mem)
>> -{
>> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
>> -
>> - WARN_ON(ret);
>> -}
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem);
>> /**
>> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 10:06 ` [Intel-gfx] " Matthew Auld
@ 2022-04-11 10:45 ` Thomas Hellström
-1 siblings, 0 replies; 20+ messages in thread
From: Thomas Hellström @ 2022-04-11 10:45 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
Cc: Nirmoy Das, Lucas De Marchi, Christian König, dri-devel
On 4/11/22 12:06, Matthew Auld wrote:
> On 11/04/2022 10:56, Thomas Hellström wrote:
>> Hi, Matthew
>>
>> On 4/11/22 10:56, Matthew Auld wrote:
>>> If we hit the sync case, like when skipping clearing for kernel
>>> internal
>>> objects, or when falling back to cpu clearing, like in i915, we end up
>>> trying to add a NULL fence, but with some recent changes in this area
>>> this now just results in NULL deref in dma_resv_add_fence:
>>>
>>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>>> 0000000000000008
>>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>>> <6>[ 5.466386] PGD 0 P4D 0
>>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d
>>> 60 a5 0a 82
>>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>>> 00000000ffffffff
>>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>>> ffffffff8233f087
>>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>>> 0000000000000001
>>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>>> 0000000000000000
>>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>>> ffff88810a88d600
>>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>>> 00000000003706e0
>>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>>> 0000000000000000
>>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>>> 0000000000000400
>>> <4>[ 5.466404] Call Trace:
>>> <4>[ 5.466405] <TASK>
>>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140
>>> [ttm]
>>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>>> [i915]
>>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>>
>>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>>> directly.
>>>
>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> index bc5190340b9c..1cbfb00c1d65 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>>> ttm_buffer_object *bo,
>>> }
>>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>>> + struct ttm_resource *new_mem)
>>> +{
>>> + struct ttm_device *bdev = bo->bdev;
>>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>>> new_mem->mem_type);
>>> + int ret;
>>> +
>>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>>> + if (WARN_ON(ret))
>>> + return;
>>> +
>>> + ttm_bo_assign_mem(bo, new_mem);
>>> +}
>>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>>
>> I don't think this will help in the case where we call
>> ttm_bo_move_accel_cleanup() with a NULL fence....
>
> Hmm, do you know if that case actually exists? I thought the only
> current user passing fence == NULL was ttm_bo_move_sync_cleanup().
Yes, indeed, you're right. Not sure if any other driver hits that, though.
/Thomas
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 10:45 ` Thomas Hellström
0 siblings, 0 replies; 20+ messages in thread
From: Thomas Hellström @ 2022-04-11 10:45 UTC (permalink / raw)
To: Matthew Auld, intel-gfx; +Cc: Lucas De Marchi, Christian König, dri-devel
On 4/11/22 12:06, Matthew Auld wrote:
> On 11/04/2022 10:56, Thomas Hellström wrote:
>> Hi, Matthew
>>
>> On 4/11/22 10:56, Matthew Auld wrote:
>>> If we hit the sync case, like when skipping clearing for kernel
>>> internal
>>> objects, or when falling back to cpu clearing, like in i915, we end up
>>> trying to add a NULL fence, but with some recent changes in this area
>>> this now just results in NULL deref in dma_resv_add_fence:
>>>
>>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>>> 0000000000000008
>>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>>> <6>[ 5.466386] PGD 0 P4D 0
>>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d
>>> 60 a5 0a 82
>>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>>> 00000000ffffffff
>>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>>> ffffffff8233f087
>>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>>> 0000000000000001
>>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>>> 0000000000000000
>>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>>> ffff88810a88d600
>>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>>> 00000000003706e0
>>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>>> 0000000000000000
>>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>>> 0000000000000400
>>> <4>[ 5.466404] Call Trace:
>>> <4>[ 5.466405] <TASK>
>>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140
>>> [ttm]
>>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>>> [i915]
>>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>>
>>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>>> directly.
>>>
>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> index bc5190340b9c..1cbfb00c1d65 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>>> ttm_buffer_object *bo,
>>> }
>>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>>> + struct ttm_resource *new_mem)
>>> +{
>>> + struct ttm_device *bdev = bo->bdev;
>>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>>> new_mem->mem_type);
>>> + int ret;
>>> +
>>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>>> + if (WARN_ON(ret))
>>> + return;
>>> +
>>> + ttm_bo_assign_mem(bo, new_mem);
>>> +}
>>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>>
>> I don't think this will help in the case where we call
>> ttm_bo_move_accel_cleanup() with a NULL fence....
>
> Hmm, do you know if that case actually exists? I thought the only
> current user passing fence == NULL was ttm_bo_move_sync_cleanup().
Yes, indeed, you're right. Not sure if any other driver hits that, though.
/Thomas
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
(?)
(?)
@ 2022-04-11 10:47 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-04-11 10:47 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
URL : https://patchwork.freedesktop.org/series/102483/
State : warning
== Summary ==
Error: dim checkpatch failed
db59dc3b0c7f drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
<1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
total: 0 errors, 1 warnings, 0 checks, 44 lines checked
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
` (2 preceding siblings ...)
(?)
@ 2022-04-11 10:47 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-04-11 10:47 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
URL : https://patchwork.freedesktop.org/series/102483/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
` (3 preceding siblings ...)
(?)
@ 2022-04-11 11:14 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-04-11 11:14 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12530 bytes --]
== Series Details ==
Series: drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
URL : https://patchwork.freedesktop.org/series/102483/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11481 -> Patchwork_102483v1
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_102483v1 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_102483v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/index.html
Participating hosts (48 -> 40)
------------------------------
Additional (6): fi-cml-u2 fi-tgl-u2 fi-skl-guc fi-ivb-3770 fi-pnv-d510 fi-ehl-2
Missing (14): shard-tglu bat-dg1-6 bat-dg2-8 shard-rkl bat-adlm-1 fi-icl-u2 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-rpls-1 bat-rpls-2 shard-dg1 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102483v1:
### IGT changes ###
#### Warnings ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-7567u: [DMESG-WARN][1] ([i915#5437]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
Known issues
------------
Here are the changes found in Patchwork_102483v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-cml-u2: NOTRUN -> [DMESG-WARN][3] ([i915#5437])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@core_hotunplug@unbind-rebind.html
- fi-skl-guc: NOTRUN -> [DMESG-WARN][4] ([i915#5437])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-cml-u2: NOTRUN -> [SKIP][5] ([i915#1208]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][6] -> [INCOMPLETE][7] ([i915#146])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][8] ([i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@gem_huc_copy@huc-copy.html
- fi-tgl-u2: NOTRUN -> [SKIP][9] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-cml-u2: NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-ivb-3770: NOTRUN -> [SKIP][12] ([fdo#109271]) +18 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-ivb-3770/igt@gem_lmem_swapping@random-engines.html
* igt@i915_selftest@live@hangcheck:
- fi-bdw-samus: NOTRUN -> [INCOMPLETE][13] ([i915#3921])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-bdw-samus/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [PASS][14] -> [INCOMPLETE][15] ([i915#3921])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@dp-crc-fast:
- fi-skl-guc: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ivb-3770: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
- fi-tgl-u2: NOTRUN -> [SKIP][18] ([fdo#109284] / [fdo#111827]) +8 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-tgl-u2/igt@kms_chamelium@dp-hpd-fast.html
- fi-cml-u2: NOTRUN -> [SKIP][19] ([fdo#109284] / [fdo#111827]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-bdw-samus: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-bdw-samus/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][21] ([fdo#109271]) +11 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-tgl-u2: NOTRUN -> [SKIP][22] ([i915#4103]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-cml-u2: NOTRUN -> [SKIP][23] ([fdo#109278]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][24] ([fdo#109285])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html
- fi-tgl-u2: NOTRUN -> [SKIP][25] ([fdo#109285])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: NOTRUN -> [DMESG-WARN][26] ([i915#4269])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-pnv-d510: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#5341])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-pnv-d510/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-bdw-samus: NOTRUN -> [SKIP][28] ([fdo#109271]) +16 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-bdw-samus/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cml-u2: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#533])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-guc: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#533])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-cml-u2: NOTRUN -> [SKIP][31] ([i915#3555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@kms_setmode@basic-clone-single-crtc.html
- fi-tgl-u2: NOTRUN -> [SKIP][32] ([i915#3555])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-tgl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][33] ([fdo#109271]) +39 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
- fi-cml-u2: NOTRUN -> [SKIP][34] ([i915#3301])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-cml-u2: NOTRUN -> [FAIL][35] ([i915#4312] / [i915#5257])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-cml-u2/igt@runner@aborted.html
- fi-skl-guc: NOTRUN -> [FAIL][36] ([i915#4312] / [i915#5257])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-skl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-samus: [INCOMPLETE][37] ([i915#4831]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-bdw-samus/igt@gem_exec_suspend@basic-s3@smem.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-bdw-samus/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][39] ([i915#4785]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-soraka: [DMESG-WARN][41] ([i915#5437]) -> [DMESG-WARN][42] ([i915#1982] / [i915#5437])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4831]: https://gitlab.freedesktop.org/drm/intel/issues/4831
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5437]: https://gitlab.freedesktop.org/drm/intel/issues/5437
[i915#5577]: https://gitlab.freedesktop.org/drm/intel/issues/5577
Build changes
-------------
* Linux: CI_DRM_11481 -> Patchwork_102483v1
CI-20190529: 20190529
CI_DRM_11481: 9bf68eb47288411da23ce5c9967f27dba43bda1d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6415: c3b690bd5f7fb1fb7ed786ab0f3b815930a6a55f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102483v1: 102483v1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6b29edf782a1 drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/index.html
[-- Attachment #2: Type: text/html, Size: 15687 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
` (4 preceding siblings ...)
(?)
@ 2022-04-11 12:37 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-04-11 12:37 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30287 bytes --]
== Series Details ==
Series: drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
URL : https://patchwork.freedesktop.org/series/102483/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11481_full -> Patchwork_102483v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 10)
------------------------------
Missing (3): shard-rkl shard-dg1 shard-tglu
Known issues
------------
Here are the changes found in Patchwork_102483v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][1] -> [TIMEOUT][2] ([i915#2481] / [i915#3070])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb4/igt@gem_eio@unwedge-stress.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-snb: [PASS][12] -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-snb4/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-apl3/igt@gem_exec_suspend@basic-s3@smem.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl4/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_lmem_swapping@verify-random:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl3/igt@gem_lmem_swapping@verify-random.html
* igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#768])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][20] ([i915#3318])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#5566] / [i915#716])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl1/igt@gen9_exec_parse@allowed-single.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][23] ([i915#454])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][24] -> [FAIL][25] ([i915#454])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#1937])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#3650])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl1/igt@i915_pm_sseu@full-enable.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl8/igt@i915_pm_sseu@full-enable.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][29] -> [INCOMPLETE][30] ([i915#3921])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-snb4/igt@i915_selftest@live@hangcheck.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@bad-pitch-999:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#62]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-apl3/igt@kms_addfb_basic@bad-pitch-999.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl4/igt@kms_addfb_basic@bad-pitch-999.html
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#4272])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_async_flips@crc.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3777]) +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3777])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl9/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][37] ([i915#3763])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][38] ([i915#3743])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl1/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +7 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#3886]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb7/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278]) +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +7 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl4/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl4/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +12 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl1/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109300] / [fdo#111066])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][48] ([i915#2105])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +98 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-offscreen:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#3359])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb2/igt@kms_cursor_crc@pipe-b-cursor-32x10-offscreen.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-skl: [PASS][51] -> [DMESG-WARN][52] ([i915#1982] / [i915#533])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl9/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#2346]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: NOTRUN -> [FAIL][55] ([i915#2346])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- shard-skl: [PASS][56] -> [FAIL][57] ([i915#2122])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl7/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#79]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][60] -> [DMESG-WARN][61] ([i915#180]) +8 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: NOTRUN -> [FAIL][62] ([i915#2122])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109280] / [fdo#111825])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109280]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) +3 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][68] ([fdo#108145] / [i915#265])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][69] -> [FAIL][70] ([fdo#108145] / [i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale:
- shard-iclb: [PASS][71] -> [SKIP][72] ([i915#5235]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format:
- shard-iclb: [PASS][73] -> [INCOMPLETE][74] ([i915#5395])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb8/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb2/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl7/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#111068] / [i915#658])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][78] -> [SKIP][79] ([fdo#109441]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271]) +196 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl6/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#5030]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271]) +125 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl4/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_vrr@flip-basic:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109502])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb2/igt@kms_vrr@flip-basic.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2437])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_writeback@writeback-invalid-parameters.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl1/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][86] -> [FAIL][87] ([i915#1542])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl1/igt@perf@polling-parameterized.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl8/igt@perf@polling-parameterized.html
* igt@prime_nv_test@i915_nv_sharing:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109291])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb8/igt@prime_nv_test@i915_nv_sharing.html
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- shard-kbl: NOTRUN -> [DMESG-WARN][89] ([i915#5098])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@syncobj_timeline@invalid-transfer-non-existent-point.html
* igt@syncobj_timeline@transfer-timeline-point:
- shard-apl: NOTRUN -> [DMESG-FAIL][90] ([i915#5098])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl3/igt@syncobj_timeline@transfer-timeline-point.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][93] ([i915#232]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-tglb8/igt@gem_eio@unwedge-stress.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [INCOMPLETE][95] ([i915#4547]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl4/igt@gem_exec_capture@pi@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl9/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][97] ([i915#2842]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb5/igt@gem_exec_fair@basic-pace@bcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb6/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_flush@basic-uc-prw-default:
- shard-snb: [SKIP][99] ([fdo#109271]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-snb6/igt@gem_exec_flush@basic-uc-prw-default.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-snb7/igt@gem_exec_flush@basic-uc-prw-default.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][103] ([i915#79]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][105] ([i915#180]) -> [PASS][106] +6 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a:
- shard-skl: [FAIL][107] ([i915#1188]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl10/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl4/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][109] ([fdo#108145] / [i915#265]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping:
- shard-iclb: [INCOMPLETE][111] ([i915#5243]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][113] ([fdo#109441]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb8/igt@kms_psr@psr2_basic.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][115] ([i915#3614]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][117] ([i915#1542]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-tglb6/igt@perf@polling-parameterized.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-tglb2/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [SKIP][119] ([i915#4525]) -> [DMESG-WARN][120] ([i915#5614]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb5/igt@gem_exec_balancer@parallel-contexts.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][121] ([i915#2842]) -> [FAIL][122] ([i915#2852])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][123] ([i915#454]) -> [INCOMPLETE][124] ([i915#1982] / [i915#5626])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-skl10/igt@i915_pm_dc@dc6-psr.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-skl8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][125] ([i915#1804] / [i915#2684]) -> [WARN][126] ([i915#2684])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [INCOMPLETE][127] -> [DMESG-WARN][128] ([i915#180])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][129] ([fdo#111068] / [i915#658]) -> [SKIP][130] ([i915#2920])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb4/igt@kms_psr2_sf@cursor-plane-update-sf.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][131] ([i915#2920]) -> [SKIP][132] ([i915#658])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/shard-iclb7/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#5257])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl4/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl3/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl6/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl7/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/shard-kbl4/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_D
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102483v1/index.html
[-- Attachment #2: Type: text/html, Size: 33951 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
@ 2022-04-11 12:39 ` Christian König
-1 siblings, 0 replies; 20+ messages in thread
From: Christian König @ 2022-04-11 12:39 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, dri-devel, Nirmoy Das
Am 11.04.22 um 10:56 schrieb Matthew Auld:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Ideally we wouldn't export that to drivers, but that's a different problem.
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 12:39 ` Christian König
0 siblings, 0 replies; 20+ messages in thread
From: Christian König @ 2022-04-11 12:39 UTC (permalink / raw)
To: Matthew Auld, intel-gfx; +Cc: Thomas Hellström, Lucas De Marchi, dri-devel
Am 11.04.22 um 10:56 schrieb Matthew Auld:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Ideally we wouldn't export that to drivers, but that's a different problem.
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 10:45 ` [Intel-gfx] " Thomas Hellström
@ 2022-04-11 12:44 ` Christian König
-1 siblings, 0 replies; 20+ messages in thread
From: Christian König @ 2022-04-11 12:44 UTC (permalink / raw)
To: Thomas Hellström, Matthew Auld, intel-gfx
Cc: Nirmoy Das, Lucas De Marchi, dri-devel
Am 11.04.22 um 12:45 schrieb Thomas Hellström:
>
> On 4/11/22 12:06, Matthew Auld wrote:
>> On 11/04/2022 10:56, Thomas Hellström wrote:
>>> Hi, Matthew
>>>
>>> On 4/11/22 10:56, Matthew Auld wrote:
>>>> If we hit the sync case, like when skipping clearing for kernel
>>>> internal
>>>> objects, or when falling back to cpu clearing, like in i915, we end up
>>>> trying to add a NULL fence, but with some recent changes in this area
>>>> this now just results in NULL deref in dma_resv_add_fence:
>>>>
>>>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>>>> 0000000000000008
>>>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>>>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>>>> <6>[ 5.466386] PGD 0 P4D 0
>>>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>>>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>>>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>>>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>>>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00
>>>> 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0
>>>> 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00
>>>> 48 3d 60 a5 0a 82
>>>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>>>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>>>> 00000000ffffffff
>>>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>>>> ffffffff8233f087
>>>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>>>> 0000000000000001
>>>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>>>> 0000000000000000
>>>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>>>> ffff88810a88d600
>>>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>>>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>>>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>>>> 00000000003706e0
>>>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>>>> 0000000000000000
>>>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>>>> 0000000000000400
>>>> <4>[ 5.466404] Call Trace:
>>>> <4>[ 5.466405] <TASK>
>>>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>>>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>>>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>>>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>>>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140
>>>> [ttm]
>>>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>>>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>>>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>>>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>>>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>>>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>>>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>>>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>>>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>>>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>>>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>>>> [i915]
>>>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>>>
>>>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>>>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>>>> directly.
>>>>
>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>>> Cc: Christian König <christian.koenig@amd.com>
>>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>>>> ---
>>>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>>>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>>>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> index bc5190340b9c..1cbfb00c1d65 100644
>>>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>>>> ttm_buffer_object *bo,
>>>> }
>>>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>>>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>>>> + struct ttm_resource *new_mem)
>>>> +{
>>>> + struct ttm_device *bdev = bo->bdev;
>>>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>>>> new_mem->mem_type);
>>>> + int ret;
>>>> +
>>>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>>>> + if (WARN_ON(ret))
>>>> + return;
>>>> +
>>>> + ttm_bo_assign_mem(bo, new_mem);
>>>> +}
>>>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>>>
>>> I don't think this will help in the case where we call
>>> ttm_bo_move_accel_cleanup() with a NULL fence....
>>
>> Hmm, do you know if that case actually exists? I thought the only
>> current user passing fence == NULL was ttm_bo_move_sync_cleanup().
>
>
> Yes, indeed, you're right. Not sure if any other driver hits that,
> though.
At least when I came up with that ~halve a year ago I double checked all
drivers to not call ttm_bo_move_accel_cleanup() without a fence.
But I also somehow missed ttm_bo_move_sync_cleanup(), so take that with
a grain of salt.
Christian.
>
> /Thomas
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 12:44 ` Christian König
0 siblings, 0 replies; 20+ messages in thread
From: Christian König @ 2022-04-11 12:44 UTC (permalink / raw)
To: Thomas Hellström, Matthew Auld, intel-gfx; +Cc: Lucas De Marchi, dri-devel
Am 11.04.22 um 12:45 schrieb Thomas Hellström:
>
> On 4/11/22 12:06, Matthew Auld wrote:
>> On 11/04/2022 10:56, Thomas Hellström wrote:
>>> Hi, Matthew
>>>
>>> On 4/11/22 10:56, Matthew Auld wrote:
>>>> If we hit the sync case, like when skipping clearing for kernel
>>>> internal
>>>> objects, or when falling back to cpu clearing, like in i915, we end up
>>>> trying to add a NULL fence, but with some recent changes in this area
>>>> this now just results in NULL deref in dma_resv_add_fence:
>>>>
>>>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>>>> 0000000000000008
>>>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>>>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>>>> <6>[ 5.466386] PGD 0 P4D 0
>>>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>>>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>>>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>>>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>>>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00
>>>> 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0
>>>> 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00
>>>> 48 3d 60 a5 0a 82
>>>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>>>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>>>> 00000000ffffffff
>>>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>>>> ffffffff8233f087
>>>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>>>> 0000000000000001
>>>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>>>> 0000000000000000
>>>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>>>> ffff88810a88d600
>>>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>>>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>>>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>>>> 00000000003706e0
>>>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>>>> 0000000000000000
>>>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>>>> 0000000000000400
>>>> <4>[ 5.466404] Call Trace:
>>>> <4>[ 5.466405] <TASK>
>>>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>>>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>>>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>>>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>>>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140
>>>> [ttm]
>>>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>>>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>>>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>>>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>>>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>>>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>>>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>>>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>>>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>>>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>>>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>>>> [i915]
>>>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>>>
>>>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>>>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>>>> directly.
>>>>
>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>>> Cc: Christian König <christian.koenig@amd.com>
>>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>>>> ---
>>>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>>>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>>>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> index bc5190340b9c..1cbfb00c1d65 100644
>>>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>>>> ttm_buffer_object *bo,
>>>> }
>>>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>>>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>>>> + struct ttm_resource *new_mem)
>>>> +{
>>>> + struct ttm_device *bdev = bo->bdev;
>>>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>>>> new_mem->mem_type);
>>>> + int ret;
>>>> +
>>>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>>>> + if (WARN_ON(ret))
>>>> + return;
>>>> +
>>>> + ttm_bo_assign_mem(bo, new_mem);
>>>> +}
>>>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>>>
>>> I don't think this will help in the case where we call
>>> ttm_bo_move_accel_cleanup() with a NULL fence....
>>
>> Hmm, do you know if that case actually exists? I thought the only
>> current user passing fence == NULL was ttm_bo_move_sync_cleanup().
>
>
> Yes, indeed, you're right. Not sure if any other driver hits that,
> though.
At least when I came up with that ~halve a year ago I double checked all
drivers to not call ttm_bo_move_accel_cleanup() without a fence.
But I also somehow missed ttm_bo_move_sync_cleanup(), so take that with
a grain of salt.
Christian.
>
> /Thomas
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
@ 2022-04-11 20:05 ` Thomas Zimmermann
-1 siblings, 0 replies; 20+ messages in thread
From: Thomas Zimmermann @ 2022-04-11 20:05 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, Christian König,
dri-devel, Nirmoy Das
[-- Attachment #1.1: Type: text/plain, Size: 6060 bytes --]
Am 11.04.22 um 10:56 schrieb Matthew Auld:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
with bochs on ppc64le.
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-11 20:05 ` Thomas Zimmermann
0 siblings, 0 replies; 20+ messages in thread
From: Thomas Zimmermann @ 2022-04-11 20:05 UTC (permalink / raw)
To: Matthew Auld, intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, Christian König, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 6060 bytes --]
Am 11.04.22 um 10:56 schrieb Matthew Auld:
> If we hit the sync case, like when skipping clearing for kernel internal
> objects, or when falling back to cpu clearing, like in i915, we end up
> trying to add a NULL fence, but with some recent changes in this area
> this now just results in NULL deref in dma_resv_add_fence:
>
> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address: 0000000000000008
> <1>[ 5.466384] #PF: supervisor read access in kernel mode
> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
> <6>[ 5.466386] PGD 0 P4D 0
> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted 5.18.0-rc2-CI-CI_DRM_11481+ #1
> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60 a5 0a 82
> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX: 00000000ffffffff
> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI: ffffffff8233f087
> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09: 0000000000000001
> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12: 0000000000000000
> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15: ffff88810a88d600
> <4>[ 5.466401] FS: 00007f5fa1193540(0000) GS:ffff88845d880000(0000) knlGS:0000000000000000
> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4: 00000000003706e0
> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> <4>[ 5.466404] Call Trace:
> <4>[ 5.466405] <TASK>
> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915]
> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>
> In the ttm_bo_move_sync_cleanup() case it seems we only really care
> about calling ttm_bo_wait_free_node(), so let's instead just call that
> directly.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
with bochs on ppc64le.
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index bc5190340b9c..1cbfb00c1d65 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> }
> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem)
> +{
> + struct ttm_device *bdev = bo->bdev;
> + struct ttm_resource_manager *man = ttm_manager_type(bdev, new_mem->mem_type);
> + int ret;
> +
> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
> + if (WARN_ON(ret))
> + return;
> +
> + ttm_bo_assign_mem(bo, new_mem);
> +}
> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
> +
> /**
> * ttm_bo_pipeline_gutting - purge the contents of a bo
> * @bo: The buffer object
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 059a595e14e5..897b88f0bd59 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> struct ttm_resource *new_mem);
>
> /**
> - * ttm_bo_move_accel_cleanup.
> + * ttm_bo_move_sync_cleanup.
> *
> * @bo: A pointer to a struct ttm_buffer_object.
> * @new_mem: struct ttm_resource indicating where to move.
> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo,
> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
> * by the caller to be idle. Typically used after memcpy buffer moves.
> */
> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> - struct ttm_resource *new_mem)
> -{
> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
> -
> - WARN_ON(ret);
> -}
> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
> + struct ttm_resource *new_mem);
>
> /**
> * ttm_bo_pipeline_gutting.
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
2022-04-11 12:39 ` [Intel-gfx] " Christian König
@ 2022-04-12 12:08 ` Matthew Auld
-1 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-12 12:08 UTC (permalink / raw)
To: Christian König, intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, dri-devel, Nirmoy Das
On 11/04/2022 13:39, Christian König wrote:
> Am 11.04.22 um 10:56 schrieb Matthew Auld:
>> If we hit the sync case, like when skipping clearing for kernel internal
>> objects, or when falling back to cpu clearing, like in i915, we end up
>> trying to add a NULL fence, but with some recent changes in this area
>> this now just results in NULL deref in dma_resv_add_fence:
>>
>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>> 0000000000000008
>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>> <6>[ 5.466386] PGD 0 P4D 0
>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60
>> a5 0a 82
>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>> 00000000ffffffff
>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>> ffffffff8233f087
>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>> 0000000000000001
>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>> 0000000000000000
>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>> ffff88810a88d600
>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>> 00000000003706e0
>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>> 0000000000000000
>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>> 0000000000000400
>> <4>[ 5.466404] Call Trace:
>> <4>[ 5.466405] <TASK>
>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>> [i915]
>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>
>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>> directly.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>
> Ideally we wouldn't export that to drivers, but that's a different problem.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Thanks. Would you be able to merge this?
>
>> ---
>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> index bc5190340b9c..1cbfb00c1d65 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> }
>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem)
>> +{
>> + struct ttm_device *bdev = bo->bdev;
>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>> new_mem->mem_type);
>> + int ret;
>> +
>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>> + if (WARN_ON(ret))
>> + return;
>> +
>> + ttm_bo_assign_mem(bo, new_mem);
>> +}
>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>> +
>> /**
>> * ttm_bo_pipeline_gutting - purge the contents of a bo
>> * @bo: The buffer object
>> diff --git a/include/drm/ttm/ttm_bo_driver.h
>> b/include/drm/ttm/ttm_bo_driver.h
>> index 059a595e14e5..897b88f0bd59 100644
>> --- a/include/drm/ttm/ttm_bo_driver.h
>> +++ b/include/drm/ttm/ttm_bo_driver.h
>> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> struct ttm_resource *new_mem);
>> /**
>> - * ttm_bo_move_accel_cleanup.
>> + * ttm_bo_move_sync_cleanup.
>> *
>> * @bo: A pointer to a struct ttm_buffer_object.
>> * @new_mem: struct ttm_resource indicating where to move.
>> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
>> * by the caller to be idle. Typically used after memcpy buffer moves.
>> */
>> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object
>> *bo,
>> - struct ttm_resource *new_mem)
>> -{
>> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
>> -
>> - WARN_ON(ret);
>> -}
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem);
>> /**
>> * ttm_bo_pipeline_gutting.
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup
@ 2022-04-12 12:08 ` Matthew Auld
0 siblings, 0 replies; 20+ messages in thread
From: Matthew Auld @ 2022-04-12 12:08 UTC (permalink / raw)
To: Christian König, intel-gfx
Cc: Thomas Hellström, Lucas De Marchi, dri-devel
On 11/04/2022 13:39, Christian König wrote:
> Am 11.04.22 um 10:56 schrieb Matthew Auld:
>> If we hit the sync case, like when skipping clearing for kernel internal
>> objects, or when falling back to cpu clearing, like in i915, we end up
>> trying to add a NULL fence, but with some recent changes in this area
>> this now just results in NULL deref in dma_resv_add_fence:
>>
>> <1>[ 5.466383] BUG: kernel NULL pointer dereference, address:
>> 0000000000000008
>> <1>[ 5.466384] #PF: supervisor read access in kernel mode
>> <1>[ 5.466385] #PF: error_code(0x0000) - not-present page
>> <6>[ 5.466386] PGD 0 P4D 0
>> <4>[ 5.466387] Oops: 0000 [#1] PREEMPT SMP NOPTI
>> <4>[ 5.466389] CPU: 5 PID: 267 Comm: modprobe Not tainted
>> 5.18.0-rc2-CI-CI_DRM_11481+ #1
>> <4>[ 5.466391] RIP: 0010:dma_resv_add_fence+0x63/0x260
>> <4>[ 5.466395] Code: 38 85 c0 0f 84 df 01 00 00 0f 88 e8 01 00 00
>> 83 c0 01 0f 88 df 01 00 00 8b 05 35 89 10 01 49 8d 5e 68 85 c0 0f 85
>> 45 01 00 00 <48> 8b 45 08 48 3d c0 a5 0a 82 0f 84 5c 01 00 00 48 3d 60
>> a5 0a 82
>> <4>[ 5.466396] RSP: 0018:ffffc90000e974f8 EFLAGS: 00010202
>> <4>[ 5.466397] RAX: 0000000000000001 RBX: ffff888123e88b28 RCX:
>> 00000000ffffffff
>> <4>[ 5.466398] RDX: 0000000000000001 RSI: ffffffff822e4f50 RDI:
>> ffffffff8233f087
>> <4>[ 5.466399] RBP: 0000000000000000 R08: ffff8881313dbc80 R09:
>> 0000000000000001
>> <4>[ 5.466399] R10: 0000000000000001 R11: 00000000da354294 R12:
>> 0000000000000000
>> <4>[ 5.466400] R13: ffff88810927dc58 R14: ffff888123e88ac0 R15:
>> ffff88810a88d600
>> <4>[ 5.466401] FS: 00007f5fa1193540(0000)
>> GS:ffff88845d880000(0000) knlGS:0000000000000000
>> <4>[ 5.466402] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> <4>[ 5.466402] CR2: 0000000000000008 CR3: 0000000106dd6003 CR4:
>> 00000000003706e0
>> <4>[ 5.466403] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
>> 0000000000000000
>> <4>[ 5.466404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
>> 0000000000000400
>> <4>[ 5.466404] Call Trace:
>> <4>[ 5.466405] <TASK>
>> <4>[ 5.466406] ttm_bo_move_accel_cleanup+0x62/0x270 [ttm]
>> <4>[ 5.466411] ? i915_rsgt_from_buddy_resource+0x185/0x1e0 [i915]
>> <4>[ 5.466529] i915_ttm_move+0xfd/0x430 [i915]
>> <4>[ 5.466833] ? dma_resv_reserve_fences+0x4e/0x320
>> <4>[ 5.466836] ? ttm_bo_add_move_fence.constprop.20+0xf7/0x140 [ttm]
>> <4>[ 5.466841] ttm_bo_handle_move_mem+0xa1/0x140 [ttm]
>> <4>[ 5.466845] ttm_bo_validate+0xee/0x160 [ttm]
>> <4>[ 5.466849] __i915_ttm_get_pages+0x4f/0x210 [i915]
>> <4>[ 5.466976] i915_ttm_get_pages+0xad/0x140 [i915]
>> <4>[ 5.467094] ____i915_gem_object_get_pages+0x32/0xf0 [i915]
>> <4>[ 5.467210] __i915_gem_object_get_pages+0x89/0xa0 [i915]
>> <4>[ 5.467323] i915_vma_get_pages+0x114/0x1d0 [i915]
>> <4>[ 5.467446] i915_vma_pin_ww+0xd3/0xa90 [i915]
>> <4>[ 5.467570] i915_vma_pin.constprop.10+0x119/0x1b0 [i915]
>> <4>[ 5.467700] ? __mutex_unlock_slowpath+0x3e/0x2b0
>> <4>[ 5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390
>> [i915]
>> <4>[ 5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915]
>>
>> In the ttm_bo_move_sync_cleanup() case it seems we only really care
>> about calling ttm_bo_wait_free_node(), so let's instead just call that
>> directly.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>
> Ideally we wouldn't export that to drivers, but that's a different problem.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Thanks. Would you be able to merge this?
>
>> ---
>> drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++++++++
>> include/drm/ttm/ttm_bo_driver.h | 11 +++--------
>> 2 files changed, 18 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> index bc5190340b9c..1cbfb00c1d65 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>> @@ -572,6 +572,21 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> }
>> EXPORT_SYMBOL(ttm_bo_move_accel_cleanup);
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem)
>> +{
>> + struct ttm_device *bdev = bo->bdev;
>> + struct ttm_resource_manager *man = ttm_manager_type(bdev,
>> new_mem->mem_type);
>> + int ret;
>> +
>> + ret = ttm_bo_wait_free_node(bo, man->use_tt);
>> + if (WARN_ON(ret))
>> + return;
>> +
>> + ttm_bo_assign_mem(bo, new_mem);
>> +}
>> +EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);
>> +
>> /**
>> * ttm_bo_pipeline_gutting - purge the contents of a bo
>> * @bo: The buffer object
>> diff --git a/include/drm/ttm/ttm_bo_driver.h
>> b/include/drm/ttm/ttm_bo_driver.h
>> index 059a595e14e5..897b88f0bd59 100644
>> --- a/include/drm/ttm/ttm_bo_driver.h
>> +++ b/include/drm/ttm/ttm_bo_driver.h
>> @@ -245,7 +245,7 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> struct ttm_resource *new_mem);
>> /**
>> - * ttm_bo_move_accel_cleanup.
>> + * ttm_bo_move_sync_cleanup.
>> *
>> * @bo: A pointer to a struct ttm_buffer_object.
>> * @new_mem: struct ttm_resource indicating where to move.
>> @@ -253,13 +253,8 @@ int ttm_bo_move_accel_cleanup(struct
>> ttm_buffer_object *bo,
>> * Special case of ttm_bo_move_accel_cleanup where the bo is guaranteed
>> * by the caller to be idle. Typically used after memcpy buffer moves.
>> */
>> -static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object
>> *bo,
>> - struct ttm_resource *new_mem)
>> -{
>> - int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem);
>> -
>> - WARN_ON(ret);
>> -}
>> +void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo,
>> + struct ttm_resource *new_mem);
>> /**
>> * ttm_bo_pipeline_gutting.
>
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2022-04-12 12:09 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 8:56 [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup Matthew Auld
2022-04-11 8:56 ` [Intel-gfx] " Matthew Auld
2022-04-11 9:56 ` Thomas Hellström
2022-04-11 9:56 ` [Intel-gfx] " Thomas Hellström
2022-04-11 10:06 ` Matthew Auld
2022-04-11 10:06 ` [Intel-gfx] " Matthew Auld
2022-04-11 10:45 ` Thomas Hellström
2022-04-11 10:45 ` [Intel-gfx] " Thomas Hellström
2022-04-11 12:44 ` Christian König
2022-04-11 12:44 ` [Intel-gfx] " Christian König
2022-04-11 10:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-04-11 10:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-04-11 11:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-04-11 12:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-04-11 12:39 ` [PATCH] " Christian König
2022-04-11 12:39 ` [Intel-gfx] " Christian König
2022-04-12 12:08 ` Matthew Auld
2022-04-12 12:08 ` [Intel-gfx] " Matthew Auld
2022-04-11 20:05 ` Thomas Zimmermann
2022-04-11 20:05 ` [Intel-gfx] " Thomas Zimmermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.