From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> To: Boqun Feng <boqun.feng@gmail.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-api <linux-api@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Russell King <linux@arm.linux.org.uk>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Paul Turner <pjt@google.com>, Andrew Hunter <ahh@google.com>, Peter Zijlstra <peterz@infradead.org>, Andy Lutomirski <luto@amacapital.net>, Andi Kleen <andi@firstfloor.org>, Dave Watson <davejwatson@fb.com>, Chris Lameter <cl@linux.com>, Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Linus Torvalds <torvalds@linux-foundation.org>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org> Subject: Re: [RFC 1/4] rseq/param_test: Convert test_data_entry::count to intptr_t Date: Thu, 28 Jul 2016 03:07:51 +0000 (UTC) [thread overview] Message-ID: <1186455824.415.1469675271317.JavaMail.zimbra@efficios.com> (raw) In-Reply-To: <20160727150517.26983-1-boqun.feng@gmail.com> ----- On Jul 27, 2016, at 11:05 AM, Boqun Feng boqun.feng@gmail.com wrote: > The current semantics of do_resq() is to do a intptr_t type store in > successful cases, however, in test_percpu_{inc,spinlock}, we use > test_data_entry::count as the location to store, whose type is int. > > intptr_t and int have different size on LP64 systems, and despite the > inconsistency of types, having test_data_entry::count as int needs more > care on endian handling. > > To make things simpler and more consistent, convert > test_data_entry::count to type intptr_t, which also makes the coming > tests for ppc64le and ppc64 share the same code. Folded into my rseq tests patch for next round, thanks! I also took care of basic_percpu_ops_test.c which had the same issue. Thanks! Mathieu > > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > --- > tools/testing/selftests/rseq/param_test.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/rseq/param_test.c > b/tools/testing/selftests/rseq/param_test.c > index f95fba5a1b2a..db25e0a818e5 100644 > --- a/tools/testing/selftests/rseq/param_test.c > +++ b/tools/testing/selftests/rseq/param_test.c > @@ -124,7 +124,7 @@ struct percpu_lock { > }; > > struct test_data_entry { > - int count; > + intptr_t count; > } __attribute__((aligned(128))); > > struct spinlock_test_data { > @@ -234,7 +234,8 @@ void *test_percpu_spinlock_thread(void *arg) > void test_percpu_spinlock(void) > { > const int num_threads = opt_threads; > - int i, sum, ret; > + int i, ret; > + intptr_t sum; > pthread_t test_threads[num_threads]; > struct spinlock_test_data data; > struct spinlock_thread_test_data thread_data[num_threads]; > @@ -308,7 +309,8 @@ void *test_percpu_inc_thread(void *arg) > void test_percpu_inc(void) > { > const int num_threads = opt_threads; > - int i, sum, ret; > + int i, ret; > + intptr_t sum; > pthread_t test_threads[num_threads]; > struct inc_test_data data; > struct inc_thread_test_data thread_data[num_threads]; > -- > 2.9.0 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers <mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org> To: Boqun Feng <boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-api <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Andrew Hunter <ahh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>, Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>, Dave Watson <davejwatson-b10kYP2dOMg@public.gmane.org>, Chris Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>, Ben Maurer <bmaurer-b10kYP2dOMg@public.gmane.org>, rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>, "Paul E. McKenney" <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>, Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>, Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>, Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> Subject: Re: [RFC 1/4] rseq/param_test: Convert test_data_entry::count to intptr_t Date: Thu, 28 Jul 2016 03:07:51 +0000 (UTC) [thread overview] Message-ID: <1186455824.415.1469675271317.JavaMail.zimbra@efficios.com> (raw) In-Reply-To: <20160727150517.26983-1-boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ----- On Jul 27, 2016, at 11:05 AM, Boqun Feng boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > The current semantics of do_resq() is to do a intptr_t type store in > successful cases, however, in test_percpu_{inc,spinlock}, we use > test_data_entry::count as the location to store, whose type is int. > > intptr_t and int have different size on LP64 systems, and despite the > inconsistency of types, having test_data_entry::count as int needs more > care on endian handling. > > To make things simpler and more consistent, convert > test_data_entry::count to type intptr_t, which also makes the coming > tests for ppc64le and ppc64 share the same code. Folded into my rseq tests patch for next round, thanks! I also took care of basic_percpu_ops_test.c which had the same issue. Thanks! Mathieu > > Signed-off-by: Boqun Feng <boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > tools/testing/selftests/rseq/param_test.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/rseq/param_test.c > b/tools/testing/selftests/rseq/param_test.c > index f95fba5a1b2a..db25e0a818e5 100644 > --- a/tools/testing/selftests/rseq/param_test.c > +++ b/tools/testing/selftests/rseq/param_test.c > @@ -124,7 +124,7 @@ struct percpu_lock { > }; > > struct test_data_entry { > - int count; > + intptr_t count; > } __attribute__((aligned(128))); > > struct spinlock_test_data { > @@ -234,7 +234,8 @@ void *test_percpu_spinlock_thread(void *arg) > void test_percpu_spinlock(void) > { > const int num_threads = opt_threads; > - int i, sum, ret; > + int i, ret; > + intptr_t sum; > pthread_t test_threads[num_threads]; > struct spinlock_test_data data; > struct spinlock_thread_test_data thread_data[num_threads]; > @@ -308,7 +309,8 @@ void *test_percpu_inc_thread(void *arg) > void test_percpu_inc(void) > { > const int num_threads = opt_threads; > - int i, sum, ret; > + int i, ret; > + intptr_t sum; > pthread_t test_threads[num_threads]; > struct inc_test_data data; > struct inc_thread_test_data thread_data[num_threads]; > -- > 2.9.0 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
next prev parent reply other threads:[~2016-07-28 3:08 UTC|newest] Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-21 21:14 [RFC PATCH v7 0/7] Restartable sequences system call Mathieu Desnoyers 2016-07-21 21:14 ` Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 1/7] " Mathieu Desnoyers 2016-07-21 21:14 ` Mathieu Desnoyers 2016-07-25 23:02 ` Andy Lutomirski 2016-07-25 23:02 ` Andy Lutomirski 2016-07-26 3:02 ` Mathieu Desnoyers 2016-07-26 3:02 ` Mathieu Desnoyers 2016-08-03 12:27 ` Peter Zijlstra 2016-08-03 12:27 ` Peter Zijlstra 2016-08-03 16:37 ` Andy Lutomirski 2016-08-03 18:31 ` Christoph Lameter 2016-08-04 5:01 ` Andy Lutomirski 2016-08-04 5:01 ` Andy Lutomirski 2016-08-04 4:27 ` Boqun Feng 2016-08-04 4:27 ` Boqun Feng 2016-08-04 5:03 ` Andy Lutomirski 2016-08-09 16:13 ` Boqun Feng 2016-08-09 16:13 ` Boqun Feng 2016-08-10 8:01 ` Andy Lutomirski 2016-08-10 17:40 ` Mathieu Desnoyers 2016-08-10 17:33 ` Mathieu Desnoyers 2016-08-11 4:54 ` Boqun Feng 2016-08-11 4:54 ` Boqun Feng 2016-08-10 8:13 ` Andy Lutomirski 2016-08-10 8:13 ` Andy Lutomirski 2016-08-03 18:29 ` Christoph Lameter 2016-08-03 18:29 ` Christoph Lameter 2016-08-10 16:47 ` Mathieu Desnoyers 2016-08-10 16:47 ` Mathieu Desnoyers 2016-08-10 16:59 ` Christoph Lameter 2016-07-27 15:03 ` Boqun Feng 2016-07-27 15:03 ` Boqun Feng 2016-07-27 15:05 ` [RFC 1/4] rseq/param_test: Convert test_data_entry::count to intptr_t Boqun Feng 2016-07-27 15:05 ` Boqun Feng 2016-07-27 15:05 ` [RFC 2/4] Restartable sequences: powerpc architecture support Boqun Feng 2016-07-28 3:13 ` Mathieu Desnoyers 2016-07-27 15:05 ` [RFC 3/4] Restartable sequences: Wire up powerpc system call Boqun Feng 2016-07-28 3:13 ` Mathieu Desnoyers 2016-07-28 3:13 ` Mathieu Desnoyers 2016-07-27 15:05 ` [RFC 4/4] Restartable sequences: Add self-tests for PPC Boqun Feng 2016-07-28 2:59 ` Mathieu Desnoyers 2016-07-28 4:43 ` Boqun Feng 2016-07-28 4:43 ` Boqun Feng 2016-07-28 7:37 ` [RFC v2] " Boqun Feng 2016-07-28 14:04 ` Mathieu Desnoyers 2016-07-28 14:04 ` Mathieu Desnoyers 2016-07-28 13:42 ` [RFC 4/4] " Mathieu Desnoyers 2016-07-28 13:42 ` Mathieu Desnoyers 2016-07-28 3:07 ` Mathieu Desnoyers [this message] 2016-07-28 3:07 ` [RFC 1/4] rseq/param_test: Convert test_data_entry::count to intptr_t Mathieu Desnoyers 2016-07-28 3:10 ` [RFC PATCH v7 1/7] Restartable sequences system call Mathieu Desnoyers 2016-07-28 3:10 ` Mathieu Desnoyers 2016-08-03 13:19 ` Peter Zijlstra 2016-08-03 13:19 ` Peter Zijlstra 2016-08-03 14:53 ` Paul E. McKenney 2016-08-03 15:45 ` Boqun Feng 2016-08-03 15:45 ` Boqun Feng 2016-08-07 15:36 ` Mathieu Desnoyers 2016-08-07 23:35 ` Boqun Feng 2016-08-07 23:35 ` Boqun Feng 2016-08-09 13:22 ` Mathieu Desnoyers 2016-08-09 13:22 ` Mathieu Desnoyers 2016-08-09 20:06 ` Mathieu Desnoyers 2016-08-09 20:06 ` Mathieu Desnoyers 2016-08-09 21:33 ` Peter Zijlstra 2016-08-09 21:33 ` Peter Zijlstra 2016-08-09 22:41 ` Mathieu Desnoyers 2016-08-09 22:41 ` Mathieu Desnoyers 2016-08-10 7:50 ` Peter Zijlstra 2016-08-10 13:26 ` Mathieu Desnoyers 2016-08-10 13:33 ` Peter Zijlstra 2016-08-10 14:04 ` Mathieu Desnoyers 2016-08-10 8:10 ` Andy Lutomirski 2016-08-10 19:04 ` Mathieu Desnoyers 2016-08-10 19:04 ` Mathieu Desnoyers 2016-08-10 19:16 ` Andy Lutomirski 2016-08-10 20:06 ` Mathieu Desnoyers 2016-08-10 20:09 ` Andy Lutomirski 2016-08-10 20:09 ` Andy Lutomirski 2016-08-10 21:01 ` Mathieu Desnoyers 2016-08-11 7:23 ` Andy Lutomirski 2016-08-11 7:23 ` Andy Lutomirski 2016-08-10 8:43 ` Peter Zijlstra 2016-08-10 8:43 ` Peter Zijlstra 2016-08-10 13:57 ` Mathieu Desnoyers 2016-08-10 14:28 ` Peter Zijlstra 2016-08-10 14:44 ` Mathieu Desnoyers 2016-08-10 13:29 ` Peter Zijlstra 2016-07-21 21:14 ` [RFC PATCH v7 2/7] tracing: instrument restartable sequences Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 3/7] Restartable sequences: ARM 32 architecture support Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 4/7] Restartable sequences: wire up ARM 32 system call Mathieu Desnoyers 2016-07-21 21:14 ` Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 5/7] Restartable sequences: x86 32/64 architecture support Mathieu Desnoyers 2016-07-21 21:14 ` Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 6/7] Restartable sequences: wire up x86 32/64 system call Mathieu Desnoyers 2016-07-21 21:14 ` [RFC PATCH v7 7/7] Restartable sequences: self-tests Mathieu Desnoyers [not found] ` <CO1PR15MB09822FC140F84DCEEF2004CDDD0B0@CO1PR15MB0982.namprd15.prod.outlook.com> 2016-07-24 3:09 ` Mathieu Desnoyers 2016-07-24 3:09 ` Mathieu Desnoyers 2016-07-24 18:01 ` Dave Watson 2016-07-24 18:01 ` Dave Watson 2016-07-25 16:43 ` Mathieu Desnoyers 2016-07-25 16:43 ` Mathieu Desnoyers 2016-08-11 23:26 ` Mathieu Desnoyers 2016-08-12 1:28 ` Boqun Feng 2016-08-12 1:28 ` Boqun Feng 2016-08-12 3:10 ` Mathieu Desnoyers 2016-08-12 3:13 ` Mathieu Desnoyers 2016-08-12 3:13 ` Mathieu Desnoyers 2016-08-12 5:30 ` Boqun Feng 2016-08-12 5:30 ` Boqun Feng 2016-08-12 16:35 ` Boqun Feng 2016-08-12 16:35 ` Boqun Feng 2016-08-12 18:11 ` Mathieu Desnoyers 2016-08-12 18:11 ` Mathieu Desnoyers 2016-08-13 1:28 ` Boqun Feng 2016-08-13 1:28 ` Boqun Feng 2016-08-14 15:02 ` Mathieu Desnoyers 2016-08-14 15:02 ` Mathieu Desnoyers 2016-08-15 0:56 ` Boqun Feng 2016-08-15 0:56 ` Boqun Feng 2016-08-15 18:06 ` Mathieu Desnoyers 2016-08-15 18:06 ` Mathieu Desnoyers 2016-08-12 19:36 ` Mathieu Desnoyers 2016-08-12 19:36 ` Mathieu Desnoyers 2016-08-12 20:05 ` Dave Watson 2016-08-12 20:05 ` Dave Watson 2016-08-14 17:09 ` Mathieu Desnoyers 2016-08-14 17:09 ` Mathieu Desnoyers 2016-07-25 18:12 ` Mathieu Desnoyers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1186455824.415.1469675271317.JavaMail.zimbra@efficios.com \ --to=mathieu.desnoyers@efficios.com \ --cc=ahh@google.com \ --cc=akpm@linux-foundation.org \ --cc=andi@firstfloor.org \ --cc=benh@kernel.crashing.org \ --cc=bmaurer@fb.com \ --cc=boqun.feng@gmail.com \ --cc=cl@linux.com \ --cc=davejwatson@fb.com \ --cc=hpa@zytor.com \ --cc=josh@joshtriplett.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=luto@amacapital.net \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulmck@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.