From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shaopeng He <shaopeng.he@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf
Date: Tue, 24 Nov 2015 11:28:22 +0100 [thread overview]
Message-ID: <11881693.ZHnXqqknjk@xps13> (raw)
In-Reply-To: <20151120083527.64ffd576@xeon-e3>
> > vlan_tci should be copied from RX descriptor to mbuf,
> > and flag PKT_RX_VLAN_PKT should be set for every RX packet,
> > this patch fixes this issue.
> > Packets in fm10k device always carry at least one VLAN tag.
> > For those packets coming in without VLAN tag,
> > the port default VLAN tag will be used.
> > So in fm10k, always PKT_RX_VLAN_PKT flag is set and vlan_tci
> > is valid for each RX packet's mbuf.
> >
> > Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
>
> Looks good thanks.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
prev parent reply other threads:[~2015-11-24 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 8:50 [PATCH] fm10k: fix wrong VLAN value in RX mbuf Shaopeng He
2015-11-19 7:05 ` Chen, Jing D
2015-11-20 2:33 ` He, Shaopeng
2015-11-19 17:25 ` Stephen Hemminger
2015-11-20 2:54 ` He, Shaopeng
2015-11-20 6:28 ` [PATCH v2] " Shaopeng He
2015-11-20 10:35 ` Chen, Jing D
2015-11-20 14:23 ` He, Shaopeng
2015-11-20 14:09 ` [PATCH v3] " Shaopeng He
2015-11-20 16:35 ` Stephen Hemminger
2015-11-24 10:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11881693.ZHnXqqknjk@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=shaopeng.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.