From: Heiko Stuebner <heiko@sntech.de> To: dri-devel@lists.freedesktop.org Cc: Icenowy Zheng <icenowy@aosc.io>, Jernej Skrabec <jernej.skrabec@siol.net>, Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime.ripard@bootlin.com>, David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding Date: Mon, 03 Dec 2018 13:25:21 +0100 [thread overview] Message-ID: <11894938.HOUtrQJeEF@phil> (raw) In-Reply-To: <20181127074249.15204-2-icenowy@aosc.io> Am Dienstag, 27. November 2018, 08:42:49 CET schrieb Icenowy Zheng: > Allwinner H6 SoC uses a Mali T720 GPU, which is one of the GPUs in the > Midgard GPU product line. > > Add binding for the H6 Mali Midgard GPU. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 02f870cd60e6..c897dd7be48f 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -18,6 +18,7 @@ Required properties: > + "amlogic,meson-gxm-mali" > + "rockchip,rk3288-mali" > + "rockchip,rk3399-mali" > + + "allwinner,sun50i-h6-mali" I'd think you might want to keep an alphabetical sorting here, aka above amlogic, otherwise the list will probably become hard to read at some later point. > - reg : Physical base address of the device and length of the register area. > > @@ -44,6 +45,18 @@ Optional properties: > for details. > > > +Vendor-specific bindings > +------------------------ > + > +The Mali GPU is integrated very differently from one SoC to > +another. In order to accomodate those differences, you have the option > +to specify one more vendor-specific compatible, among: > + > + - allwinner,sun50i-h6-mali > + Required properties: > + * resets: phandle to the reset line for the GPU While this paragraph is similar to how it is done in Utgard, I'm wondering why we cannot just describe the "resets" as regular optional property above that. Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de> To: dri-devel@lists.freedesktop.org Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Jernej Skrabec <jernej.skrabec@siol.net>, Maxime Ripard <maxime.ripard@bootlin.com>, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Icenowy Zheng <icenowy@aosc.io> Subject: Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding Date: Mon, 03 Dec 2018 13:25:21 +0100 [thread overview] Message-ID: <11894938.HOUtrQJeEF@phil> (raw) In-Reply-To: <20181127074249.15204-2-icenowy@aosc.io> Am Dienstag, 27. November 2018, 08:42:49 CET schrieb Icenowy Zheng: > Allwinner H6 SoC uses a Mali T720 GPU, which is one of the GPUs in the > Midgard GPU product line. > > Add binding for the H6 Mali Midgard GPU. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 02f870cd60e6..c897dd7be48f 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -18,6 +18,7 @@ Required properties: > + "amlogic,meson-gxm-mali" > + "rockchip,rk3288-mali" > + "rockchip,rk3399-mali" > + + "allwinner,sun50i-h6-mali" I'd think you might want to keep an alphabetical sorting here, aka above amlogic, otherwise the list will probably become hard to read at some later point. > - reg : Physical base address of the device and length of the register area. > > @@ -44,6 +45,18 @@ Optional properties: > for details. > > > +Vendor-specific bindings > +------------------------ > + > +The Mali GPU is integrated very differently from one SoC to > +another. In order to accomodate those differences, you have the option > +to specify one more vendor-specific compatible, among: > + > + - allwinner,sun50i-h6-mali > + Required properties: > + * resets: phandle to the reset line for the GPU While this paragraph is similar to how it is done in Utgard, I'm wondering why we cannot just describe the "resets" as regular optional property above that. Heiko _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-03 12:25 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-27 7:42 [PATCH 1/2] dt-bindings: gpu: add bus clock for Mali Midgard GPUs Icenowy Zheng 2018-11-27 7:42 ` [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding Icenowy Zheng 2018-12-03 12:25 ` Heiko Stuebner [this message] 2018-12-03 12:25 ` Heiko Stuebner 2018-12-03 12:42 ` Maxime Ripard 2018-12-03 12:42 ` Maxime Ripard 2018-12-11 17:04 ` Rob Herring 2018-12-11 17:04 ` Rob Herring 2018-12-11 22:11 ` Rob Herring 2018-12-11 22:11 ` Rob Herring 2018-12-02 13:46 ` [PATCH 1/2] dt-bindings: gpu: add bus clock for Mali Midgard GPUs Icenowy Zheng 2018-12-02 13:46 ` Icenowy Zheng 2018-12-11 22:09 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=11894938.HOUtrQJeEF@phil \ --to=heiko@sntech.de \ --cc=airlied@linux.ie \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=icenowy@aosc.io \ --cc=jernej.skrabec@siol.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.