[PATCH 0/6] commits to move crownbay BSP to v3.4 kernel I v1.14 EMGD driver.

[PATCH 0/6] commits to move crownbay BSP to v3.4 kernel I v1.14 EMGD driver.

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

The following changes since commit 961f835e4f5dd2d02b34b7fce13316ec7b0bf1c4:

  emgd-driver-bin: remove FILES_${PN}-dev addition (2012-07-20 11:29:23 -0500)

are available in the git repository at:
  git://git.yoctoproject.org/meta-intel-contrib nitin/work
  http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/work

Nitin A Kamble (6):
  emgd-driver-bin: upgrade from 1.10 to 1.14
  crownbay: customize the xorg.conf for the flat panel on the corwnbay
    kit
  crownbay: update emgd driver version in the README
  crownbay: add recipe extension for linux-yocto-3.4
  crownbay: make v3.4 the default kernel
  gnu-efi: fix whitespace usage

 common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb         |   10 +++++-----
 ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
 meta-crownbay/README                               |    8 ++++----
 meta-crownbay/conf/machine/crownbay-noemgd.conf    |    2 +-
 meta-crownbay/conf/machine/crownbay.conf           |    2 +-
 .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
 .../recipes-kernel/linux/linux-yocto_3.4.bbappend  |   20 ++++++++++++++++++++
 7 files changed, 54 insertions(+), 19 deletions(-)
 rename common/recipes-graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} (88%)
 create mode 100644 meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend

-- 
1.7.3.4

[PATCH 1/6] emgd-driver-bin: upgrade from 1.10 to 1.14

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

1.14 is the latest released driver for emgd. This change is tested on crownbay machine.

Add runtime dependency to libxcb-dri2

Otherwise the libxcb-dri2.so is not getting installed, and video
acceleration of emgd does not work. It is dynamic dependency of
emgd_drv_video.so

emgd-driver-bin: add downloadfilename param to SRC_URI

As the url does not have the filename of the tarball, specify it here so that
updated wget bitbake fetcher can save the downloaded file accordingly.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)
 rename common/recipes-graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} (88%)

diff --git a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
similarity index 88%
rename from common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
rename to common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
index 5779e5d..b1ba1b8 100644
--- a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
+++ b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
@@ -1,9 +1,9 @@
-SUMMARY = "EMGD 1.10 xserver binaries"
-DESCRIPTION = "EMGD 1.10 includes some userspace binaries that use non-free \
+SUMMARY = "EMGD 1.14 xserver binaries"
+DESCRIPTION = "EMGD 1.14 includes some userspace binaries that use non-free \
 licensing, which are now available via a non-click-through downloadable \
 tarball, and is what this recipe now uses.  Since it is a non-free license, \
-this recipe is marked as 'License_emgd-driver-bin_1.10' and you need to add \
-to LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.10\" to your \
+this recipe is marked as 'License_emgd-driver-bin_1.14' and you need to add \
+to LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.14\" to your \
 local.conf in order to enable it in a build."
 LICENSE = "Intel-binary-only"
 LICENSE_FLAGS = "license_${PN}_${PV}"
@@ -16,17 +16,18 @@ EMGD_VIDEO_PLUGIN_DIR = "../common/video_plugin"
 LIC_FILES_CHKSUM = "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=b54f01caaf8483b3cb60c0c40f2bf22d"
 
 DEPENDS = "rpm-native xz-native"
+RDEPENDS = "libxcb-dri2"
 
-SRC_URI = "https://edc.intel.com/App_Shared/Downloads/LIN_EMGD_1_10_RC_2209.tgz"
+SRC_URI = "https://edc.intel.com/Download.aspx?id=6190;downloadfilename=LIN_IEMGD_1_14_GOLD_2443.tgz"
 
-SRC_URI[md5sum] = "e4a38d9efa0b086ae21b68145c4db4e9"
-SRC_URI[sha256sum] = "acea5f0f93a31553553428623c007d7ed0c604cf715fd87dfe075751da4be548"
+SRC_URI[md5sum] = "733a7f237ffce21238ce2c9956df4fd6"
+SRC_URI[sha256sum] = "bcdc333b5edbda7c746a83ef821ded4a0ca55ead30980e4e3680cdb6469f45a2"
 
 # These are closed binaries generated elsewhere so don't check ldflags
 INSANE_SKIP_${PN} = "ldflags"
 
 FILES_${PN} += "${libdir}/dri ${libdir}/gstreamer-0.10 ${libdir}/xorg/modules/drivers"
-FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug ${libdir}/dri/.debug"
+FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug ${libdir}/dri/.debug ${libdir}/gstreamer-0.10/.debug"
 
 S = "${WORKDIR}/${EMGD_RPM_DIR}"
 
-- 
1.7.3.4

[PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

The kit has Auo 800x600 LCD screen. Configuring Xorg for it.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
index 662f60f..d71173c 100644
--- a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
+++ b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
@@ -4,12 +4,26 @@
 ## DriverVer=
 ##
 
+# AUO G084SN05 V8 lcd flat panel
+Section "Monitor"
+    Identifier     "Monitor0"
+    VendorName     "Auo"
+#    HorizSync       33.6 - 48.3
+#    VertRefresh     60.0 - 60.0
+    Option         "DPMS"
+EndSection
+
 Section "Screen"
     Identifier    "Screen0"
     Device        "IntelEMGD-0"
     Monitor       "Monitor0"
+
+    # for the AUO flat screen
     SubSection    "Display"
+        Depth      24
+        Modes      "800x600"
     EndSubSection
+
 EndSection
 
 # Primary (First/only) display
-- 
1.7.3.4

[PATCH 3/6] crownbay: update emgd driver version in the README

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta-crownbay/README |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta-crownbay/README b/meta-crownbay/README
index b56c79a..2521432 100644
--- a/meta-crownbay/README
+++ b/meta-crownbay/README
@@ -6,7 +6,7 @@ The Crown Bay platform consists of the Intel Atom Z6xx processor,
 plus the Intel EG20T Platform Controller Hub (Tunnel Creek + Topcliff).
 
 It also supports the E6xx embedded on-chip graphics via the Intel
-Embedded Media and Graphics Driver (EMGD) 1.10 Driver.
+Embedded Media and Graphics Driver (EMGD) 1.14 Driver.
 
 
 Dependencies
@@ -63,7 +63,7 @@ common metadata shared between BSPs) e.g.:
 The meta-crownbay layer contains support for two different machine
 configurations. These configurations are identical except for the fact
 that the one prefixed with 'crownbay' makes use of the
-Intel-proprietary EMGD 1.10 graphics driver, while the one prefixed
+Intel-proprietary EMGD 1.14 graphics driver, while the one prefixed
 with 'crownbay-noemgd' does not.
 
 If you want to enable the layer that supports EMGD graphics add the
@@ -73,10 +73,10 @@ following to the local.conf file:
 
 The 'crownbay' machine includes the emgd-driver-bin package, which has
 a proprietary license that must be whitelisted by adding the string
-"license_emgd-driver-bin_1.10" to the LICENSE_FLAGS_WHITELIST variable
+"license_emgd-driver-bin_1.14" to the LICENSE_FLAGS_WHITELIST variable
 in your local.conf.  For example:
 
-  LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin_1.10"
+  LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin_1.14"
 
 If you want to enable the layer that does not support EMGD graphics
 add the following to the local.conf file:
-- 
1.7.3.4

[PATCH 4/6] crownbay: add recipe extension for linux-yocto-3.4

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

crownbay: linux-yocto v3.4 : add emgd branch info in git src_uri

At build time, the emgd-1.14 branch is merged with the crownbay bsp
kernel source branch to get emgd kernel driver's support.
  Refer it in the src_uri, & it's commit-id to be used, so that
any changes in the emgd branch will not affect the build unknowingly.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 .../recipes-kernel/linux/linux-yocto_3.4.bbappend  |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend

diff --git a/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend b/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
new file mode 100644
index 0000000..4f9dd70
--- /dev/null
+++ b/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
@@ -0,0 +1,20 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+COMPATIBLE_MACHINE_crownbay = "crownbay"
+KMACHINE_crownbay  = "crownbay"
+KBRANCH_crownbay  = "standard/default/crownbay"
+
+COMPATIBLE_MACHINE_crownbay-noemgd = "crownbay-noemgd"
+KMACHINE_crownbay-noemgd  = "crownbay"
+KBRANCH_crownbay-noemgd  = "standard/crownbay"
+
+SRCREV_machine_pn-linux-yocto_crownbay ?= "19f7e43b54aef08d58135ed2a897d77b624b320a"
+SRCREV_meta_pn-linux-yocto_crownbay ?= "d7a96809a585e06933d8c08adb9b9f66b21efb4c"
+SRCREV_emgd_pn-linux-yocto_crownbay ?= "86643bdd8cbad616a161ab91f51108cf0da827bc"
+
+SRCREV_machine_pn-linux-yocto_crownbay-noemgd ?= "19f7e43b54aef08d58135ed2a897d77b624b320a"
+SRCREV_meta_pn-linux-yocto_crownbay-noemgd ?= "d7a96809a585e06933d8c08adb9b9f66b21efb4c"
+
+KSRC_linux_yocto_3_4 ?= "git.yoctoproject.org/linux-yocto-3.4.git"
+SRC_URI_crownbay = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta,emgd-1.14;name=machine,meta,emgd"
+SRC_URI_crownbay-noemgd = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
-- 
1.7.3.4

[PATCH 5/6] crownbay: make v3.4 the default kernel

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta-crownbay/conf/machine/crownbay-noemgd.conf |    2 +-
 meta-crownbay/conf/machine/crownbay.conf        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-crownbay/conf/machine/crownbay-noemgd.conf b/meta-crownbay/conf/machine/crownbay-noemgd.conf
index af85b00..4c869ee 100644
--- a/meta-crownbay/conf/machine/crownbay-noemgd.conf
+++ b/meta-crownbay/conf/machine/crownbay-noemgd.conf
@@ -4,7 +4,7 @@
 #@DESCRIPTION: Machine configuration for Crown Bay systems, without Intel-proprietary graphics bits
 # i.e. E660 + EG20T
 
-PREFERRED_VERSION_linux-yocto ?= "3.2%"
+PREFERRED_VERSION_linux-yocto ?= "3.4%"
 
 require conf/machine/include/tune-atom.inc
 require conf/machine/include/ia32-base.inc
diff --git a/meta-crownbay/conf/machine/crownbay.conf b/meta-crownbay/conf/machine/crownbay.conf
index a39d037..7d5e597 100644
--- a/meta-crownbay/conf/machine/crownbay.conf
+++ b/meta-crownbay/conf/machine/crownbay.conf
@@ -4,7 +4,7 @@
 #@DESCRIPTION: Machine configuration for Crown Bay systems
 # i.e. E660 + EG20T
 
-PREFERRED_VERSION_linux-yocto ?= "3.2%"
+PREFERRED_VERSION_linux-yocto ?= "3.4%"
 
 require conf/machine/include/tune-atom.inc
 require conf/machine/include/ia32-base.inc
-- 
1.7.3.4

[PATCH 6/6] gnu-efi: fix whitespace usage

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

the use of tabs was causing bitbake warnings. TO avoid these warnings
converted tags into space which is also the recommended indenting for
python code.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb b/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
index 252d49a..a0d5823 100644
--- a/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
+++ b/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
@@ -17,11 +17,11 @@ SRC_URI[md5sum] = "d0a21125aee56c0c7291ad260e916cb3"
 S = "${WORKDIR}/gnu-efi-3.0"
 
 def gnu_efi_arch(d):
-	import re
-	tarch = d.getVar("TARGET_ARCH", True)
-	if re.match("i[3456789]86", tarch):
-		return "ia32"
-	return tarch
+    import re
+    tarch = d.getVar("TARGET_ARCH", True)
+    if re.match("i[3456789]86", tarch):
+        return "ia32"
+    return tarch
 
 EXTRA_OEMAKE = "'ARCH=${@gnu_efi_arch(d)}' 'CC=${CC}' 'AS=${AS}' 'LD=${LD}' 'AR=${AR}' \
                 'RANLIB=${RANLIB}' 'OBJCOPY=${OBJCOPY}' \
-- 
1.7.3.4

Re: [PATCH 1/6] emgd-driver-bin: upgrade from 1.10 to 1.14

[Kamble, Nitin A]

This commit needs latest poky master to get the bitbake wget fetcher enhancement needed for the SRC_URI.

Thanks,
Nitin


> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-
> bounces@yoctoproject.org] On Behalf Of nitin.a.kamble@intel.com
> Sent: Monday, July 23, 2012 3:36 PM
> To: yocto@yoctoproject.org; bruce.ashfield@windriver.com; Zanussi, Tom
> Subject: [yocto] [PATCH 1/6] emgd-driver-bin: upgrade from 1.10 to 1.14
> 
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> 1.14 is the latest released driver for emgd. This change is tested on crownbay
> machine.
> 
> Add runtime dependency to libxcb-dri2
> 
> Otherwise the libxcb-dri2.so is not getting installed, and video acceleration of
> emgd does not work. It is dynamic dependency of emgd_drv_video.so
> 
> emgd-driver-bin: add downloadfilename param to SRC_URI
> 
> As the url does not have the filename of the tarball, specify it here so that
> updated wget bitbake fetcher can save the downloaded file accordingly.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
>  1 files changed, 9 insertions(+), 8 deletions(-)  rename common/recipes-
> graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-
> bin_1.14.bb} (88%)
> 
> diff --git a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
> b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> similarity index 88%
> rename from common/recipes-graphics/xorg-xserver/emgd-driver-
> bin_1.10.bb
> rename to common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> index 5779e5d..b1ba1b8 100644
> --- a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
> +++ b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> @@ -1,9 +1,9 @@
> -SUMMARY = "EMGD 1.10 xserver binaries"
> -DESCRIPTION = "EMGD 1.10 includes some userspace binaries that use non-
> free \
> +SUMMARY = "EMGD 1.14 xserver binaries"
> +DESCRIPTION = "EMGD 1.14 includes some userspace binaries that use
> +non-free \
>  licensing, which are now available via a non-click-through downloadable \
> tarball, and is what this recipe now uses.  Since it is a non-free license, \ -this
> recipe is marked as 'License_emgd-driver-bin_1.10' and you need to add \ -to
> LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.10\" to your \
> +this recipe is marked as 'License_emgd-driver-bin_1.14' and you need to
> +add \ to LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.14\"
> to
> +your \
>  local.conf in order to enable it in a build."
>  LICENSE = "Intel-binary-only"
>  LICENSE_FLAGS = "license_${PN}_${PV}"
> @@ -16,17 +16,18 @@ EMGD_VIDEO_PLUGIN_DIR =
> "../common/video_plugin"
>  LIC_FILES_CHKSUM =
> "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=b54f01caaf8483b3cb
> 60c0c40f2bf22d"
> 
>  DEPENDS = "rpm-native xz-native"
> +RDEPENDS = "libxcb-dri2"
> 
> -SRC_URI =
> "https://edc.intel.com/App_Shared/Downloads/LIN_EMGD_1_10_RC_2209.
> tgz"
> +SRC_URI =
> "https://edc.intel.com/Download.aspx?id=6190;downloadfilename=LIN_IEM
> GD_1_14_GOLD_2443.tgz"
> 
> -SRC_URI[md5sum] = "e4a38d9efa0b086ae21b68145c4db4e9"
> -SRC_URI[sha256sum] =
> "acea5f0f93a31553553428623c007d7ed0c604cf715fd87dfe075751da4be548"
> +SRC_URI[md5sum] = "733a7f237ffce21238ce2c9956df4fd6"
> +SRC_URI[sha256sum] =
> "bcdc333b5edbda7c746a83ef821ded4a0ca55ead30980e4e3680cdb6469f45a2"
> 
>  # These are closed binaries generated elsewhere so don't check ldflags
> INSANE_SKIP_${PN} = "ldflags"
> 
>  FILES_${PN} += "${libdir}/dri ${libdir}/gstreamer-0.10
> ${libdir}/xorg/modules/drivers"
> -FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug
> ${libdir}/dri/.debug"
> +FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug
> ${libdir}/dri/.debug ${libdir}/gstreamer-0.10/.debug"
> 
>  S = "${WORKDIR}/${EMGD_RPM_DIR}"
> 
> --
> 1.7.3.4
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: [PATCH 0/6] commits to move crownbay BSP to v3.4 kernel I v1.14 EMGD driver.

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>


Hi Nitin,

Please include [meta-intel] in the subject of the cover letter for patch
series against the meta-intel repository.

--
Darren

> The following changes since commit 961f835e4f5dd2d02b34b7fce13316ec7b0bf1c4:
> 
>   emgd-driver-bin: remove FILES_${PN}-dev addition (2012-07-20 11:29:23 -0500)
> 
> are available in the git repository at:
>   git://git.yoctoproject.org/meta-intel-contrib nitin/work
>   http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/work
> 
> Nitin A Kamble (6):
>   emgd-driver-bin: upgrade from 1.10 to 1.14
>   crownbay: customize the xorg.conf for the flat panel on the corwnbay
>     kit
>   crownbay: update emgd driver version in the README
>   crownbay: add recipe extension for linux-yocto-3.4
>   crownbay: make v3.4 the default kernel
>   gnu-efi: fix whitespace usage
> 
>  common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb         |   10 +++++-----
>  ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
>  meta-crownbay/README                               |    8 ++++----
>  meta-crownbay/conf/machine/crownbay-noemgd.conf    |    2 +-
>  meta-crownbay/conf/machine/crownbay.conf           |    2 +-
>  .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
>  .../recipes-kernel/linux/linux-yocto_3.4.bbappend  |   20 ++++++++++++++++++++
>  7 files changed, 54 insertions(+), 19 deletions(-)
>  rename common/recipes-graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} (88%)
>  create mode 100644 meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 1/6] emgd-driver-bin: upgrade from 1.10 to 1.14

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> 1.14 is the latest released driver for emgd. This change is tested on crownbay machine.

Please limit your commit log messages to 72 characters in width. This
allows for some indentation without git log truncating the message. You
should be able to configure your editor to do this automatically.

> 
> Add runtime dependency to libxcb-dri2
> 
> Otherwise the libxcb-dri2.so is not getting installed, and video
> acceleration of emgd does not work. It is dynamic dependency of
> emgd_drv_video.so
> 
> emgd-driver-bin: add downloadfilename param to SRC_URI
> 
> As the url does not have the filename of the tarball, specify it here so that
> updated wget bitbake fetcher can save the downloaded file accordingly.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
>  1 files changed, 9 insertions(+), 8 deletions(-)
>  rename common/recipes-graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} (88%)
> 
> diff --git a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> similarity index 88%
> rename from common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
> rename to common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> index 5779e5d..b1ba1b8 100644
> --- a/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.10.bb
> +++ b/common/recipes-graphics/xorg-xserver/emgd-driver-bin_1.14.bb
> @@ -1,9 +1,9 @@
> -SUMMARY = "EMGD 1.10 xserver binaries"
> -DESCRIPTION = "EMGD 1.10 includes some userspace binaries that use non-free \
> +SUMMARY = "EMGD 1.14 xserver binaries"
> +DESCRIPTION = "EMGD 1.14 includes some userspace binaries that use non-free \
>  licensing, which are now available via a non-click-through downloadable \
>  tarball, and is what this recipe now uses.  Since it is a non-free license, \
> -this recipe is marked as 'License_emgd-driver-bin_1.10' and you need to add \
> -to LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.10\" to your \
> +this recipe is marked as 'License_emgd-driver-bin_1.14' and you need to add \
> +to LICENSE_FLAGS_WHITELIST += \"License_emgd-driver-bin_1.14\" to your \
>  local.conf in order to enable it in a build."
>  LICENSE = "Intel-binary-only"
>  LICENSE_FLAGS = "license_${PN}_${PV}"
> @@ -16,17 +16,18 @@ EMGD_VIDEO_PLUGIN_DIR = "../common/video_plugin"
>  LIC_FILES_CHKSUM = "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=b54f01caaf8483b3cb60c0c40f2bf22d"
>  
>  DEPENDS = "rpm-native xz-native"
> +RDEPENDS = "libxcb-dri2"
>  
> -SRC_URI = "https://edc.intel.com/App_Shared/Downloads/LIN_EMGD_1_10_RC_2209.tgz"
> +SRC_URI = "https://edc.intel.com/Download.aspx?id=6190;downloadfilename=LIN_IEMGD_1_14_GOLD_2443.tgz"
>  
> -SRC_URI[md5sum] = "e4a38d9efa0b086ae21b68145c4db4e9"
> -SRC_URI[sha256sum] = "acea5f0f93a31553553428623c007d7ed0c604cf715fd87dfe075751da4be548"
> +SRC_URI[md5sum] = "733a7f237ffce21238ce2c9956df4fd6"
> +SRC_URI[sha256sum] = "bcdc333b5edbda7c746a83ef821ded4a0ca55ead30980e4e3680cdb6469f45a2"
>  
>  # These are closed binaries generated elsewhere so don't check ldflags
>  INSANE_SKIP_${PN} = "ldflags"
>  
>  FILES_${PN} += "${libdir}/dri ${libdir}/gstreamer-0.10 ${libdir}/xorg/modules/drivers"
> -FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug ${libdir}/dri/.debug"
> +FILES_${PN}-dbg += "${libdir}/xorg/modules/drivers/.debug ${libdir}/dri/.debug ${libdir}/gstreamer-0.10/.debug"

This change is not covered in the change log.


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.

I presume the crownbay has additional display options? how does this
impact those?

--
Darren

> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
> index 662f60f..d71173c 100644
> --- a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
> +++ b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay/xorg.conf
> @@ -4,12 +4,26 @@
>  ## DriverVer=
>  ##
>  
> +# AUO G084SN05 V8 lcd flat panel
> +Section "Monitor"
> +    Identifier     "Monitor0"
> +    VendorName     "Auo"
> +#    HorizSync       33.6 - 48.3
> +#    VertRefresh     60.0 - 60.0
> +    Option         "DPMS"
> +EndSection
> +
>  Section "Screen"
>      Identifier    "Screen0"
>      Device        "IntelEMGD-0"
>      Monitor       "Monitor0"
> +
> +    # for the AUO flat screen
>      SubSection    "Display"
> +        Depth      24
> +        Modes      "800x600"
>      EndSubSection
> +
>  EndSection
>  
>  # Primary (First/only) display
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 3/6] crownbay: update emgd driver version in the README

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>

This should really be done in the patch that made the upgrade as they
are the same functional change. Otherwise the driver version and the
README are out of sync (if only momentarily). But there isn't a
compelling reason to do these separately that I can see.

--
Darren

> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta-crownbay/README |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-crownbay/README b/meta-crownbay/README
> index b56c79a..2521432 100644
> --- a/meta-crownbay/README
> +++ b/meta-crownbay/README
> @@ -6,7 +6,7 @@ The Crown Bay platform consists of the Intel Atom Z6xx processor,
>  plus the Intel EG20T Platform Controller Hub (Tunnel Creek + Topcliff).
>  
>  It also supports the E6xx embedded on-chip graphics via the Intel
> -Embedded Media and Graphics Driver (EMGD) 1.10 Driver.
> +Embedded Media and Graphics Driver (EMGD) 1.14 Driver.
>  
>  
>  Dependencies
> @@ -63,7 +63,7 @@ common metadata shared between BSPs) e.g.:
>  The meta-crownbay layer contains support for two different machine
>  configurations. These configurations are identical except for the fact
>  that the one prefixed with 'crownbay' makes use of the
> -Intel-proprietary EMGD 1.10 graphics driver, while the one prefixed
> +Intel-proprietary EMGD 1.14 graphics driver, while the one prefixed
>  with 'crownbay-noemgd' does not.
>  
>  If you want to enable the layer that supports EMGD graphics add the
> @@ -73,10 +73,10 @@ following to the local.conf file:
>  
>  The 'crownbay' machine includes the emgd-driver-bin package, which has
>  a proprietary license that must be whitelisted by adding the string
> -"license_emgd-driver-bin_1.10" to the LICENSE_FLAGS_WHITELIST variable
> +"license_emgd-driver-bin_1.14" to the LICENSE_FLAGS_WHITELIST variable
>  in your local.conf.  For example:
>  
> -  LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin_1.10"
> +  LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin_1.14"
>  
>  If you want to enable the layer that does not support EMGD graphics
>  add the following to the local.conf file:
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 4/6] crownbay: add recipe extension for linux-yocto-3.4

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> crownbay: linux-yocto v3.4 : add emgd branch info in git src_uri
> 
> At build time, the emgd-1.14 branch is merged with the crownbay bsp
> kernel source branch to get emgd kernel driver's support.
>   Refer it in the src_uri, & it's commit-id to be used, so that

    Reference                and its

> any changes in the emgd branch will not affect the build unknowingly.

This also adds the 3.4 kernel recipe for crownbay, which didn't exist
before. The commit subject should reflect this. This is the primary
function of this patch, the emgd change should be noted in the log, but
it is secondary.

--
Darren

> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  .../recipes-kernel/linux/linux-yocto_3.4.bbappend  |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
>  create mode 100644 meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
> 
> diff --git a/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend b/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
> new file mode 100644
> index 0000000..4f9dd70
> --- /dev/null
> +++ b/meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
> @@ -0,0 +1,20 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +COMPATIBLE_MACHINE_crownbay = "crownbay"
> +KMACHINE_crownbay  = "crownbay"
> +KBRANCH_crownbay  = "standard/default/crownbay"
> +
> +COMPATIBLE_MACHINE_crownbay-noemgd = "crownbay-noemgd"
> +KMACHINE_crownbay-noemgd  = "crownbay"
> +KBRANCH_crownbay-noemgd  = "standard/crownbay"
> +
> +SRCREV_machine_pn-linux-yocto_crownbay ?= "19f7e43b54aef08d58135ed2a897d77b624b320a"
> +SRCREV_meta_pn-linux-yocto_crownbay ?= "d7a96809a585e06933d8c08adb9b9f66b21efb4c"
> +SRCREV_emgd_pn-linux-yocto_crownbay ?= "86643bdd8cbad616a161ab91f51108cf0da827bc"
> +
> +SRCREV_machine_pn-linux-yocto_crownbay-noemgd ?= "19f7e43b54aef08d58135ed2a897d77b624b320a"
> +SRCREV_meta_pn-linux-yocto_crownbay-noemgd ?= "d7a96809a585e06933d8c08adb9b9f66b21efb4c"
> +
> +KSRC_linux_yocto_3_4 ?= "git.yoctoproject.org/linux-yocto-3.4.git"
> +SRC_URI_crownbay = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta,emgd-1.14;name=machine,meta,emgd"
> +SRC_URI_crownbay-noemgd = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 6/6] gnu-efi: fix whitespace usage

[Darren Hart]

On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> the use of tabs was causing bitbake warnings. TO avoid these warnings

  The                                           To                     ,

> converted tags into space which is also the recommended indenting for

  convert tabs        spaces

> python code.


Thanks for catching that!

--
Darren

> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb b/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
> index 252d49a..a0d5823 100644
> --- a/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
> +++ b/common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb
> @@ -17,11 +17,11 @@ SRC_URI[md5sum] = "d0a21125aee56c0c7291ad260e916cb3"
>  S = "${WORKDIR}/gnu-efi-3.0"
>  
>  def gnu_efi_arch(d):
> -	import re
> -	tarch = d.getVar("TARGET_ARCH", True)
> -	if re.match("i[3456789]86", tarch):
> -		return "ia32"
> -	return tarch
> +    import re
> +    tarch = d.getVar("TARGET_ARCH", True)
> +    if re.match("i[3456789]86", tarch):
> +        return "ia32"
> +    return tarch
>  
>  EXTRA_OEMAKE = "'ARCH=${@gnu_efi_arch(d)}' 'CC=${CC}' 'AS=${AS}' 'LD=${LD}' 'AR=${AR}' \
>                  'RANLIB=${RANLIB}' 'OBJCOPY=${OBJCOPY}' \
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 0/6] commits to move crownbay BSP to v3.4 kernel I v1.14 EMGD driver.

[Darren Hart]

On 07/26/2012 12:51 PM, Darren Hart wrote:
> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> 
> Hi Nitin,
> 
> Please include [meta-intel] in the subject of the cover letter for patch
> series against the meta-intel repository.

There were several minor issues with the series, but a few warrant a
resend. Please fixup the series and resend as:

[PATCH 0/5 V2][meta-intel] commits to move crownbay BSP to v3.4 kernel
v1.14 EMGD driver

Thanks,


> 
> --
> Darren
> 
>> The following changes since commit 961f835e4f5dd2d02b34b7fce13316ec7b0bf1c4:
>>
>>   emgd-driver-bin: remove FILES_${PN}-dev addition (2012-07-20 11:29:23 -0500)
>>
>> are available in the git repository at:
>>   git://git.yoctoproject.org/meta-intel-contrib nitin/work
>>   http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/work
>>
>> Nitin A Kamble (6):
>>   emgd-driver-bin: upgrade from 1.10 to 1.14
>>   crownbay: customize the xorg.conf for the flat panel on the corwnbay
>>     kit
>>   crownbay: update emgd driver version in the README
>>   crownbay: add recipe extension for linux-yocto-3.4
>>   crownbay: make v3.4 the default kernel
>>   gnu-efi: fix whitespace usage
>>
>>  common/recipes-bsp/gnu-efi/gnu-efi_3.0m.bb         |   10 +++++-----
>>  ...-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} |   17 +++++++++--------
>>  meta-crownbay/README                               |    8 ++++----
>>  meta-crownbay/conf/machine/crownbay-noemgd.conf    |    2 +-
>>  meta-crownbay/conf/machine/crownbay.conf           |    2 +-
>>  .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
>>  .../recipes-kernel/linux/linux-yocto_3.4.bbappend  |   20 ++++++++++++++++++++
>>  7 files changed, 54 insertions(+), 19 deletions(-)
>>  rename common/recipes-graphics/xorg-xserver/{emgd-driver-bin_1.10.bb => emgd-driver-bin_1.14.bb} (88%)
>>  create mode 100644 meta-crownbay/recipes-kernel/linux/linux-yocto_3.4.bbappend
>>
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Kamble, Nitin A]

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: Friday, July 27, 2012 1:41 AM
> To: Kamble, Nitin A
> Cc: yocto@yoctoproject.org; bruce.ashfield@windriver.com; Zanussi, Tom
> Subject: Re: [yocto] [PATCH 2/6] crownbay: customize the xorg.conf for the
> flat panel on the corwnbay kit
> 
> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
> 
> I presume the crownbay has additional display options? how does this impact
> those?
> 
This change sets the resolution of the screen to 800x600. And this is applicable to 
LCD screen on the kit as well as external monitor.
  I will add a note about it in the log.

Thanks,
Nitin


> --
> Darren
> 
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
> >  1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git
> > a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
> config/crow
> > nbay/xorg.conf
> > b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
> config/crow
> > nbay/xorg.conf
> > index 662f60f..d71173c 100644
> > ---
> > a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
> config/crow
> > nbay/xorg.conf
> > +++ b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/
> > +++ crownbay/xorg.conf
> > @@ -4,12 +4,26 @@
> >  ## DriverVer=
> >  ##
> >
> > +# AUO G084SN05 V8 lcd flat panel
> > +Section "Monitor"
> > +    Identifier     "Monitor0"
> > +    VendorName     "Auo"
> > +#    HorizSync       33.6 - 48.3
> > +#    VertRefresh     60.0 - 60.0
> > +    Option         "DPMS"
> > +EndSection
> > +
> >  Section "Screen"
> >      Identifier    "Screen0"
> >      Device        "IntelEMGD-0"
> >      Monitor       "Monitor0"
> > +
> > +    # for the AUO flat screen
> >      SubSection    "Display"
> > +        Depth      24
> > +        Modes      "800x600"
> >      EndSubSection
> > +
> >  EndSection
> >
> >  # Primary (First/only) display
> >
> 
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Darren Hart]

On 07/26/2012 09:00 PM, Kamble, Nitin A wrote:
> 
> 
>> -----Original Message-----
>> From: Darren Hart [mailto:dvhart@linux.intel.com]
>> Sent: Friday, July 27, 2012 1:41 AM
>> To: Kamble, Nitin A
>> Cc: yocto@yoctoproject.org; bruce.ashfield@windriver.com; Zanussi, Tom
>> Subject: Re: [yocto] [PATCH 2/6] crownbay: customize the xorg.conf for the
>> flat panel on the corwnbay kit
>>
>> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
>>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>>
>>> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
>>
>> I presume the crownbay has additional display options? how does this impact
>> those?
>>
> This change sets the resolution of the screen to 800x600. And this is applicable to 
> LCD screen on the kit as well as external monitor.
>   I will add a note about it in the log.

I presume that without this change it was able to detect the appropriate
resolution of the connected monitor, but not of the LCD?

If so, this change effectively breaks that autodetection and forces
everything to the 800x600 display which is arguably very low-resolution
by today's standards. Why should this be the default? When you refer to
"the kit", what exactly are you referring to?

Also, is this a discussion you have already had with Tom? I don't want
to contradict what he has said regarding this BSP.

--
Darren

> 
> Thanks,
> Nitin
> 
> 
>> --
>> Darren
>>
>>>
>>> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>>> ---
>>>  .../xserver-xf86-config/crownbay/xorg.conf         |   14 ++++++++++++++
>>>  1 files changed, 14 insertions(+), 0 deletions(-)
>>>
>>> diff --git
>>> a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
>> config/crow
>>> nbay/xorg.conf
>>> b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
>> config/crow
>>> nbay/xorg.conf
>>> index 662f60f..d71173c 100644
>>> ---
>>> a/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-
>> config/crow
>>> nbay/xorg.conf
>>> +++ b/meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/
>>> +++ crownbay/xorg.conf
>>> @@ -4,12 +4,26 @@
>>>  ## DriverVer=
>>>  ##
>>>
>>> +# AUO G084SN05 V8 lcd flat panel
>>> +Section "Monitor"
>>> +    Identifier     "Monitor0"
>>> +    VendorName     "Auo"
>>> +#    HorizSync       33.6 - 48.3
>>> +#    VertRefresh     60.0 - 60.0
>>> +    Option         "DPMS"
>>> +EndSection
>>> +
>>>  Section "Screen"
>>>      Identifier    "Screen0"
>>>      Device        "IntelEMGD-0"
>>>      Monitor       "Monitor0"
>>> +
>>> +    # for the AUO flat screen
>>>      SubSection    "Display"
>>> +        Depth      24
>>> +        Modes      "800x600"
>>>      EndSubSection
>>> +
>>>  EndSection
>>>
>>>  # Primary (First/only) display
>>>
>>
>> --
>> Darren Hart
>> Intel Open Source Technology Center
>> Yocto Project - Technical Lead - Linux Kernel

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Kamble, Nitin A]

> >> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> >>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >>>
> >>> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
> >>
> >> I presume the crownbay has additional display options? how does this
> >> impact those?
> >>
> > This change sets the resolution of the screen to 800x600. And this is
> > applicable to LCD screen on the kit as well as external monitor.
> >   I will add a note about it in the log.
> 
> I presume that without this change it was able to detect the appropriate
> resolution of the connected monitor, but not of the LCD?
> 
> If so, this change effectively breaks that autodetection and forces everything
> to the 800x600 display which is arguably very low-resolution by today's
> standards. Why should this be the default? When you refer to "the kit", what
> exactly are you referring to?
> 
> Also, is this a discussion you have already had with Tom? I don't want to
> contradict what he has said regarding this BSP.


EMGD driver on crownbay gives few resolutions as options. By default it tries to set 1366x768 resolution for both LCD and external monitor. 
The Crownbay kit is a suitcase kind of box, which has builtin LCD screen of resolution 800x600. This LCD screen shows only 800x600 of the default 1366x768 area. So The LCD is not able to show all the screen, and IMO it is a functional issue.

For my Dell 1704FPTi monitor which has 1280x1024 native resolution; When connected to the crownbay,  X cannot find a working mode for this monitor. But if I set 800x600 in the xorg.conf as this commit does, then both LCD & external monitor can show the X screen without any issues.

I guess if a 1366x768 resolution monitor is connected to crownbay, it will show the X screen fine, but I don't have such monitor now. And also I think a BSP should not have such resolution requirement for the attached monitor, and attached LCD screen of the kit work without issues.

So the point of this commit is, make default config such that it will work for the LCD screen on the kit as well as any monitor attached. And if someone wants to get better resolution with their external monitor then they need to adjust the xorg.conf accordingly.

BTW I did not have much discussion with Tom on this topic.

Thanks,
Nitin

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Kamble, Nitin A]

> -----Original Message-----
> From: yocto-bounces@yoctoproject.org [mailto:yocto-
> bounces@yoctoproject.org] On Behalf Of Kamble, Nitin A
> Sent: Friday, July 27, 2012 11:02 AM
> To: Darren Hart
> Cc: yocto@yoctoproject.org
> Subject: Re: [yocto] [PATCH 2/6] crownbay: customize the xorg.conf for the
> flat panel on the corwnbay kit
> 
> > >> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> > >>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >>>
> > >>> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
> > >>
> > >> I presume the crownbay has additional display options? how does
> > >> this impact those?
> > >>
> > > This change sets the resolution of the screen to 800x600. And this
> > > is applicable to LCD screen on the kit as well as external monitor.
> > >   I will add a note about it in the log.
> >
> > I presume that without this change it was able to detect the
> > appropriate resolution of the connected monitor, but not of the LCD?
> >
> > If so, this change effectively breaks that autodetection and forces
> > everything to the 800x600 display which is arguably very
> > low-resolution by today's standards. Why should this be the default?
> > When you refer to "the kit", what exactly are you referring to?
> >
> > Also, is this a discussion you have already had with Tom? I don't want
> > to contradict what he has said regarding this BSP.
> 
> 
> EMGD driver on crownbay gives few resolutions as options. By default it tries
> to set 1366x768 resolution for both LCD and external monitor.
> The Crownbay kit is a suitcase kind of box, which has builtin LCD screen of
> resolution 800x600. This LCD screen shows only 800x600 of the default
> 1366x768 area. So The LCD is not able to show all the screen, and IMO it is a
> functional issue.
> 
> For my Dell 1704FPTi monitor which has 1280x1024 native resolution; When
> connected to the crownbay,  X cannot find a working mode for this monitor.
> But if I set 800x600 in the xorg.conf as this commit does, then both LCD &
> external monitor can show the X screen without any issues.
> 
> I guess if a 1366x768 resolution monitor is connected to crownbay, it will
> show the X screen fine, but I don't have such monitor now. And also I think a
> BSP should not have such resolution requirement for the attached monitor,
> and attached LCD screen of the kit work without issues.
> 
> So the point of this commit is, make default config such that it will work for
> the LCD screen on the kit as well as any monitor attached. And if someone
> wants to get better resolution with their external monitor then they need to
> adjust the xorg.conf accordingly.
> 
> BTW I did not have much discussion with Tom on this topic.
> 

Correction: the Dell 1704FPTi monitor can work with 1280x1024 resolution with crownbay, only if I specify the HorizSync and VertRefresh & resolution mode parameters for monitor in the xorg.conf

Nitin

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Darren Hart]

On 07/26/2012 10:31 PM, Kamble, Nitin A wrote:
>>>> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
>>>>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>>>> 
>>>>> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
>>>> 
>>>> I presume the crownbay has additional display options? how does
>>>> this impact those?
>>>> 
>>> This change sets the resolution of the screen to 800x600. And
>>> this is applicable to LCD screen on the kit as well as external
>>> monitor. I will add a note about it in the log.
>> 
>> I presume that without this change it was able to detect the
>> appropriate resolution of the connected monitor, but not of the
>> LCD?
>> 
>> If so, this change effectively breaks that autodetection and forces
>> everything to the 800x600 display which is arguably very
>> low-resolution by today's standards. Why should this be the
>> default? When you refer to "the kit", what exactly are you
>> referring to?
>> 
>> Also, is this a discussion you have already had with Tom? I don't
>> want to contradict what he has said regarding this BSP.
> 
> 
> EMGD driver on crownbay gives few resolutions as options. By default
> it tries to set 1366x768 resolution for both LCD and external
> monitor. The Crownbay kit is a suitcase kind of box, which has
> builtin LCD screen of resolution 800x600. This LCD screen shows only
> 800x600 of the default 1366x768 area. So The LCD is not able to show
> all the screen, and IMO it is a functional issue.
> 
> For my Dell 1704FPTi monitor which has 1280x1024 native resolution;
> When connected to the crownbay,  X cannot find a working mode for
> this monitor. But if I set 800x600 in the xorg.conf as this commit
> does, then both LCD & external monitor can show the X screen without
> any issues.

This seems like a bug to me. The driver should be able to probe the
display and use the optimal resolution without it being specified in the
Xorg.conf. So far as I know we don't specify resolution in any of the
meta-intel BSPs:

dvhart@envy:~/source/poky/layers/meta-intel [denzil]
$ find . -name xorg.conf | xargs grep -i Modes

So while I agree the kit screen should work out of the box, the fact
that even your dell lcd monitor doesn't work is cause for concern. Is
there anything in the Xorg log that indicates why it isn't able to get
the EDID data?

--
Darren

> 
> I guess if a 1366x768 resolution monitor is connected to crownbay, it
> will show the X screen fine, but I don't have such monitor now. And
> also I think a BSP should not have such resolution requirement for
> the attached monitor, and attached LCD screen of the kit work without
> issues.
> 
> So the point of this commit is, make default config such that it will
> work for the LCD screen on the kit as well as any monitor attached.
> And if someone wants to get better resolution with their external
> monitor then they need to adjust the xorg.conf accordingly.
> 
> BTW I did not have much discussion with Tom on this topic.
> 
> Thanks, Nitin
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Kamble, Nitin A]

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: Saturday, July 28, 2012 3:27 AM
> To: Kamble, Nitin A
> Cc: yocto@yoctoproject.org; bruce.ashfield@windriver.com; Zanussi, Tom
> Subject: Re: [yocto] [PATCH 2/6] crownbay: customize the xorg.conf for the
> flat panel on the corwnbay kit
> 
> 
> 
> On 07/26/2012 10:31 PM, Kamble, Nitin A wrote:
> >>>> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> >>>>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >>>>>
> >>>>> The kit has Auo 800x600 LCD screen. Configuring Xorg for it.
> >>>>
> >>>> I presume the crownbay has additional display options? how does
> >>>> this impact those?
> >>>>
> >>> This change sets the resolution of the screen to 800x600. And this
> >>> is applicable to LCD screen on the kit as well as external monitor.
> >>> I will add a note about it in the log.
> >>
> >> I presume that without this change it was able to detect the
> >> appropriate resolution of the connected monitor, but not of the LCD?
> >>
> >> If so, this change effectively breaks that autodetection and forces
> >> everything to the 800x600 display which is arguably very
> >> low-resolution by today's standards. Why should this be the default?
> >> When you refer to "the kit", what exactly are you referring to?
> >>
> >> Also, is this a discussion you have already had with Tom? I don't
> >> want to contradict what he has said regarding this BSP.
> >
> >
> > EMGD driver on crownbay gives few resolutions as options. By default
> > it tries to set 1366x768 resolution for both LCD and external monitor.
> > The Crownbay kit is a suitcase kind of box, which has builtin LCD
> > screen of resolution 800x600. This LCD screen shows only
> > 800x600 of the default 1366x768 area. So The LCD is not able to show
> > all the screen, and IMO it is a functional issue.
> >
> > For my Dell 1704FPTi monitor which has 1280x1024 native resolution;
> > When connected to the crownbay,  X cannot find a working mode for this
> > monitor. But if I set 800x600 in the xorg.conf as this commit does,
> > then both LCD & external monitor can show the X screen without any
> > issues.
> 
> This seems like a bug to me. The driver should be able to probe the display
> and use the optimal resolution without it being specified in the Xorg.conf. So
> far as I know we don't specify resolution in any of the meta-intel BSPs:
> 
> dvhart@envy:~/source/poky/layers/meta-intel [denzil] $ find . -name
> xorg.conf | xargs grep -i Modes
> 
> So while I agree the kit screen should work out of the box, the fact that even
> your dell lcd monitor doesn't work is cause for concern. Is there anything in
> the Xorg log that indicates why it isn't able to get the EDID data?
> 
> --
> Darren
> 

In the xorg log I do not see any useful EDID information. Either these displays do not support EDID, or the EDID support in the EMGD driver is not working well with these devices. And the EMGD driver is closed source. So we can't fix it. So IMO keeping the resolution to 800x600 is the best possible solution for crownbay BSP.

Nitin

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Darren Hart]

On 07/30/2012 02:50 AM, Kamble, Nitin A wrote:
> 
> 
>> -----Original Message----- From: Darren Hart
>> [mailto:dvhart@linux.intel.com] Sent: Saturday, July 28, 2012 3:27
>> AM To: Kamble, Nitin A Cc: yocto@yoctoproject.org;
>> bruce.ashfield@windriver.com; Zanussi, Tom Subject: Re: [yocto]
>> [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on
>> the corwnbay kit
>> 
>> 
>> 
>> On 07/26/2012 10:31 PM, Kamble, Nitin A wrote:
>>>>>> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
>>>>>>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>>>>>> 
>>>>>>> The kit has Auo 800x600 LCD screen. Configuring Xorg for
>>>>>>> it.
>>>>>> 
>>>>>> I presume the crownbay has additional display options? how
>>>>>> does this impact those?
>>>>>> 
>>>>> This change sets the resolution of the screen to 800x600. And
>>>>> this is applicable to LCD screen on the kit as well as
>>>>> external monitor. I will add a note about it in the log.
>>>> 
>>>> I presume that without this change it was able to detect the 
>>>> appropriate resolution of the connected monitor, but not of the
>>>> LCD?
>>>> 
>>>> If so, this change effectively breaks that autodetection and
>>>> forces everything to the 800x600 display which is arguably
>>>> very low-resolution by today's standards. Why should this be
>>>> the default? When you refer to "the kit", what exactly are you
>>>> referring to?
>>>> 
>>>> Also, is this a discussion you have already had with Tom? I
>>>> don't want to contradict what he has said regarding this BSP.
>>> 
>>> 
>>> EMGD driver on crownbay gives few resolutions as options. By
>>> default it tries to set 1366x768 resolution for both LCD and
>>> external monitor. The Crownbay kit is a suitcase kind of box,
>>> which has builtin LCD screen of resolution 800x600. This LCD
>>> screen shows only 800x600 of the default 1366x768 area. So The
>>> LCD is not able to show all the screen, and IMO it is a
>>> functional issue.
>>> 
>>> For my Dell 1704FPTi monitor which has 1280x1024 native
>>> resolution; When connected to the crownbay,  X cannot find a
>>> working mode for this monitor. But if I set 800x600 in the
>>> xorg.conf as this commit does, then both LCD & external monitor
>>> can show the X screen without any issues.
>> 
>> This seems like a bug to me. The driver should be able to probe the
>> display and use the optimal resolution without it being specified
>> in the Xorg.conf. So far as I know we don't specify resolution in
>> any of the meta-intel BSPs:
>> 
>> dvhart@envy:~/source/poky/layers/meta-intel [denzil] $ find .
>> -name xorg.conf | xargs grep -i Modes
>> 
>> So while I agree the kit screen should work out of the box, the
>> fact that even your dell lcd monitor doesn't work is cause for
>> concern. Is there anything in the Xorg log that indicates why it
>> isn't able to get the EDID data?
>> 
>> -- Darren
>> 
> 
> In the xorg log I do not see any useful EDID information. Either
> these displays do not support EDID, or the EDID support in the EMGD
> driver is not working well with these devices. And the EMGD driver is
> closed source. So we can't fix it. So IMO keeping the resolution to
> 800x600 is the best possible solution for crownbay BSP.

Tom,

I've never booted a crownbay machine. What has your experience been with
the displays on this board?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on the corwnbay kit

[Tom Zanussi]

On Mon, 2012-07-30 at 08:28 -0700, Darren Hart wrote:
> 
> On 07/30/2012 02:50 AM, Kamble, Nitin A wrote:
> > 
> > 
> >> -----Original Message----- From: Darren Hart
> >> [mailto:dvhart@linux.intel.com] Sent: Saturday, July 28, 2012 3:27
> >> AM To: Kamble, Nitin A Cc: yocto@yoctoproject.org;
> >> bruce.ashfield@windriver.com; Zanussi, Tom Subject: Re: [yocto]
> >> [PATCH 2/6] crownbay: customize the xorg.conf for the flat panel on
> >> the corwnbay kit
> >> 
> >> 
> >> 
> >> On 07/26/2012 10:31 PM, Kamble, Nitin A wrote:
> >>>>>> On 07/23/2012 03:06 AM, nitin.a.kamble@intel.com wrote:
> >>>>>>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >>>>>>> 
> >>>>>>> The kit has Auo 800x600 LCD screen. Configuring Xorg for
> >>>>>>> it.
> >>>>>> 
> >>>>>> I presume the crownbay has additional display options? how
> >>>>>> does this impact those?
> >>>>>> 
> >>>>> This change sets the resolution of the screen to 800x600. And
> >>>>> this is applicable to LCD screen on the kit as well as
> >>>>> external monitor. I will add a note about it in the log.
> >>>> 
> >>>> I presume that without this change it was able to detect the 
> >>>> appropriate resolution of the connected monitor, but not of the
> >>>> LCD?
> >>>> 
> >>>> If so, this change effectively breaks that autodetection and
> >>>> forces everything to the 800x600 display which is arguably
> >>>> very low-resolution by today's standards. Why should this be
> >>>> the default? When you refer to "the kit", what exactly are you
> >>>> referring to?
> >>>> 
> >>>> Also, is this a discussion you have already had with Tom? I
> >>>> don't want to contradict what he has said regarding this BSP.
> >>> 
> >>> 
> >>> EMGD driver on crownbay gives few resolutions as options. By
> >>> default it tries to set 1366x768 resolution for both LCD and
> >>> external monitor. The Crownbay kit is a suitcase kind of box,
> >>> which has builtin LCD screen of resolution 800x600. This LCD
> >>> screen shows only 800x600 of the default 1366x768 area. So The
> >>> LCD is not able to show all the screen, and IMO it is a
> >>> functional issue.
> >>> 
> >>> For my Dell 1704FPTi monitor which has 1280x1024 native
> >>> resolution; When connected to the crownbay,  X cannot find a
> >>> working mode for this monitor. But if I set 800x600 in the
> >>> xorg.conf as this commit does, then both LCD & external monitor
> >>> can show the X screen without any issues.
> >> 
> >> This seems like a bug to me. The driver should be able to probe the
> >> display and use the optimal resolution without it being specified
> >> in the Xorg.conf. So far as I know we don't specify resolution in
> >> any of the meta-intel BSPs:
> >> 
> >> dvhart@envy:~/source/poky/layers/meta-intel [denzil] $ find .
> >> -name xorg.conf | xargs grep -i Modes
> >> 
> >> So while I agree the kit screen should work out of the box, the
> >> fact that even your dell lcd monitor doesn't work is cause for
> >> concern. Is there anything in the Xorg log that indicates why it
> >> isn't able to get the EDID data?
> >> 
> >> -- Darren
> >> 
> > 
> > In the xorg log I do not see any useful EDID information. Either
> > these displays do not support EDID, or the EDID support in the EMGD
> > driver is not working well with these devices. And the EMGD driver is
> > closed source. So we can't fix it. So IMO keeping the resolution to
> > 800x600 is the best possible solution for crownbay BSP.
> 
> Tom,
> 
> I've never booted a crownbay machine. What has your experience been with
> the displays on this board?
> 

I've never had any problems with X autodetecting the correct resolution
for either the LVDS or DVI output.  I actually had the unit Nitin has
now, but the first thing I did with that was unhook the dinky little
built-in panel and hook up a normal-sized LVDS screen that I could stand
up separately for testing.

In any case, I don't think it makes sense to hard-code a resolution for
a particular unusual screen in the default BSP - I'd suggest opening a
bug to find out why this screen can't be auto-detected if it's
important...

Tom