* PATCH: audit format mismatch for inode number
@ 2007-12-04 19:01 Todd C. Miller
2007-12-04 20:09 ` Stephen Smalley
0 siblings, 1 reply; 2+ messages in thread
From: Todd C. Miller @ 2007-12-04 19:01 UTC (permalink / raw)
To: selinux
i_ino is unsigned. We recently saw an audit message with a negative
inode number in procfs due to this.
- todd
Signed-off-by: Todd C. Miller <tmiller@tresys.com>
---
diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index e4396a8..e233a3d 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -586,7 +586,7 @@ void avc_audit(u32 ssid, u32 tsid,
}
}
if (inode)
- audit_log_format(ab, " dev=%s ino=%ld",
+ audit_log_format(ab, " dev=%s ino=%lu",
inode->i_sb->s_id,
inode->i_ino);
break;
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: PATCH: audit format mismatch for inode number
2007-12-04 19:01 PATCH: audit format mismatch for inode number Todd C. Miller
@ 2007-12-04 20:09 ` Stephen Smalley
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Smalley @ 2007-12-04 20:09 UTC (permalink / raw)
To: Todd C. Miller; +Cc: selinux
On Tue, 2007-12-04 at 14:01 -0500, Todd C. Miller wrote:
> i_ino is unsigned. We recently saw an audit message with a negative
> inode number in procfs due to this.
http://marc.info/?l=git-commits-head&m=118427505410046&w=2
> - todd
>
> Signed-off-by: Todd C. Miller <tmiller@tresys.com>
>
> ---
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index e4396a8..e233a3d 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -586,7 +586,7 @@ void avc_audit(u32 ssid, u32 tsid,
> }
> }
> if (inode)
> - audit_log_format(ab, " dev=%s ino=%ld",
> + audit_log_format(ab, " dev=%s ino=%lu",
> inode->i_sb->s_id,
> inode->i_ino);
> break;
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
--
Stephen Smalley
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-04 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-04 19:01 PATCH: audit format mismatch for inode number Todd C. Miller
2007-12-04 20:09 ` Stephen Smalley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.