[PATCH] Miscellaneous for Taco

[PATCH] Miscellaneous for Taco

[Sean MacLennan]

Last ones for now.

This patch allows you to turn off scsi_wait_scan.

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index a6676be..960dc78 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -248,7 +248,7 @@ config SCSI_SCAN_ASYNC
          or async on the kernel's command line.
 
 config SCSI_WAIT_SCAN
-       tristate
+       tristate "SCSI wait scan"
        default m
        depends on SCSI
        depends on MODULES

This patch allows you to use the USB with the taco. The taco does not 
have PCI so we must specifically add it.

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 7580aa5..480580c 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
        # PPC:
        default y if STB03xxx
        default y if PPC_MPC52xx
+       default y if TACO
        # MIPS:
        default y if SOC_AU1X00
        # more:


Cheers,
    Sean

Re: [PATCH] Miscellaneous for Taco

[Benjamin Herrenschmidt]

On Sat, 2008-01-05 at 00:21 -0500, Sean MacLennan wrote:
> Last ones for now.
> 
> This patch allows you to turn off scsi_wait_scan.

You'll have to run that one via the SCSI maintainers.

> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index a6676be..960dc78 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -248,7 +248,7 @@ config SCSI_SCAN_ASYNC
>           or async on the kernel's command line.
>  
>  config SCSI_WAIT_SCAN
> -       tristate
> +       tristate "SCSI wait scan"
>         default m
>         depends on SCSI
>         depends on MODULES
> 
> This patch allows you to use the USB with the taco. The taco does not 
> have PCI so we must specifically add it.
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 7580aa5..480580c 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
>         # PPC:
>         default y if STB03xxx
>         default y if PPC_MPC52xx
> +       default y if TACO
>         # MIPS:
>         default y if SOC_AU1X00
>         # more:

I think we should instead reference use the 440EP here, or select it
from your board code. I -hate- those long lists of board specific bits
hidden in driver Kconfig...

Cheers,
Ben.

Re: [PATCH] Miscellaneous for Taco

[Stefan Roese]

On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 7580aa5..480580c 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
> >         # PPC:
> >         default y if STB03xxx
> >         default y if PPC_MPC52xx
> > +       default y if TACO
> >         # MIPS:
> >         default y if SOC_AU1X00
> >         # more:
>
> I think we should instead reference use the 440EP here,

I vote for adding 440EP here.

Best regards,
Stefan

Re: [PATCH] Miscellaneous for Taco

[Sean MacLennan]

Stefan Roese wrote:
> On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
>   
>>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>>> index 7580aa5..480580c 100644
>>> --- a/drivers/usb/Kconfig
>>> +++ b/drivers/usb/Kconfig
>>> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
>>>         # PPC:
>>>         default y if STB03xxx
>>>         default y if PPC_MPC52xx
>>> +       default y if TACO
>>>         # MIPS:
>>>         default y if SOC_AU1X00
>>>         # more:
>>>       
>> I think we should instead reference use the 440EP here,
>>     
>
> I vote for adding 440EP here.
>
> Best regards,
> Stefan
>   
Ok. I thought of that, but most 440EP boards have PCI set and don't need 
the special option. I was worried if I put 440EP someone down the road 
might remove it as "extraneous". We are probably the only 440EP board 
with no PCI ;)

Cheers,
    Sean

Re: [PATCH] Miscellaneous for Taco

[Benjamin Herrenschmidt]

On Sat, 2008-01-05 at 13:22 -0500, Sean MacLennan wrote:
> Ok. I thought of that, but most 440EP boards have PCI set and don't need 
> the special option. I was worried if I put 440EP someone down the road 
> might remove it as "extraneous". We are probably the only 440EP board 
> with no PCI ;)

Well, it's different.... PCI is an option that can be enabled ... or
not by the board. In our case, the HAS_OHCI thing is just a switch to
indicate that an OHCI can exist, it's not actually adding code, so
it can be safely left ON whenever a 440EP processor is there, it has
no bloat and won't conflict with the PCI option.

Ben.

Re: [PATCH] Miscellaneous for Taco

[Sean MacLennan]

How about just 44x?

Cheers,
    Sean

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 7580aa5..682deae 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
        # PPC:
        default y if STB03xxx
        default y if PPC_MPC52xx
+       default y if 44x
        # MIPS:
        default y if SOC_AU1X00
        # more:

Re: [PATCH] Miscellaneous for Taco

[Stefan Roese]

On Tuesday 08 January 2008, Sean MacLennan wrote:
> How about just 44x?
>
> Cheers,
>     Sean
>
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 7580aa5..682deae 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
>         # PPC:
>         default y if STB03xxx
>         default y if PPC_MPC52xx
> +       default y if 44x

No. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. 
But since your patch only touches 440EP, you should just enable OHCI for 
exactly this platform.

Best regards,
Stefan

Re: [PATCH] Miscellaneous for Taco

[Benjamin Herrenschmidt]

On Tue, 2008-01-08 at 20:23 +0100, Stefan Roese wrote:
> On Tuesday 08 January 2008, Sean MacLennan wrote:
> > How about just 44x?
> >
> > Cheers,
> >     Sean
> >
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 7580aa5..682deae 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
> >         # PPC:
> >         default y if STB03xxx
> >         default y if PPC_MPC52xx
> > +       default y if 44x
> 
> No. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. 
> But since your patch only touches 440EP, you should just enable OHCI for 
> exactly this platform.

Note that the above Kconfig stuff just enabling the choice to enable
OHCI, it's not enabling build of OHCI per-se.

Ben.

Re: [PATCH] Miscellaneous for Taco

[Sean MacLennan]

Stefan Roese wrote:
> On Tuesday 08 January 2008, Sean MacLennan wrote:
>   
>> How about just 44x?
>>
>> Cheers,
>>     Sean
>>
>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>> index 7580aa5..682deae 100644
>> --- a/drivers/usb/Kconfig
>> +++ b/drivers/usb/Kconfig
>> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
>>         # PPC:
>>         default y if STB03xxx
>>         default y if PPC_MPC52xx
>> +       default y if 44x
>>     
>
> No. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. 
> But since your patch only touches 440EP, you should just enable OHCI for 
> exactly this platform.
>
> Best regards,
> Stefan
>   
Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
---
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 7580aa5..2660f30 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
        # PPC:
        default y if STB03xxx
        default y if PPC_MPC52xx
+       default y if 440EP
        # MIPS:
        default y if SOC_AU1X00
        # more:

Re: [PATCH] Miscellaneous for Taco

[Josh Boyer]

On Wed, 09 Jan 2008 12:26:14 -0500
Sean MacLennan <smaclennan@pikatech.com> wrote:

> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>

This one needs to go to the linux-usb list and David Brownell.

Although I'm not sure what the benefit here really is.  You can still
set this in the defconfig without adding this patch...  I don't see a
need to do a default.

josh

> ---
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 7580aa5..2660f30 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
>         # PPC:
>         default y if STB03xxx
>         default y if PPC_MPC52xx
> +       default y if 440EP
>         # MIPS:
>         default y if SOC_AU1X00
>         # more:
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Miscellaneous for Taco

[Sean MacLennan]

Josh Boyer wrote:
> On Wed, 09 Jan 2008 12:26:14 -0500
> Sean MacLennan <smaclennan@pikatech.com> wrote:
>
>   
>> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
>>     
>
> This one needs to go to the linux-usb list and David Brownell.
>
> Although I'm not sure what the benefit here really is.  You can still
> set this in the defconfig without adding this patch...  I don't see a
> need to do a default.
>   
Without the default, I was unable to select this option. I may have 
solved it the wrong way. It seems if there is no string after the 
tristate or boolean, you are not allowed to set the variable, it can 
only default. So with no default, I cannot enable this option and 
therefore cannot enable the ohci driver.

Again, I think the "default PCI" case catches most boards and all 
PCI-less, or possibly PCI-less, boards need a default.

Cheers,
   Sean

Re: [PATCH] Miscellaneous for Taco

[Josh Boyer]

On Wed, 09 Jan 2008 14:26:56 -0500
Sean MacLennan <smaclennan@pikatech.com> wrote:

> Josh Boyer wrote:
> > On Wed, 09 Jan 2008 12:26:14 -0500
> > Sean MacLennan <smaclennan@pikatech.com> wrote:
> >
> >   
> >> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
> >>     
> >
> > This one needs to go to the linux-usb list and David Brownell.
> >
> > Although I'm not sure what the benefit here really is.  You can still
> > set this in the defconfig without adding this patch...  I don't see a
> > need to do a default.
> >   
> Without the default, I was unable to select this option. I may have 
> solved it the wrong way. It seems if there is no string after the 
> tristate or boolean, you are not allowed to set the variable, it can 
> only default. So with no default, I cannot enable this option and 
> therefore cannot enable the ohci driver.
> 
> Again, I think the "default PCI" case catches most boards and all 
> PCI-less, or possibly PCI-less, boards need a default.

Ah, possibly.  Did you try doing a 'select USB_ARCH_HAS_OHCI' in the
config 440EP section of arch/powerpc/platforms/44x/Kconfig?

I'm just trying to save you some trouble.  There's nothing actually
wrong with your patch now, other than it has to be sent to the right
maintainer.

josh

Re: [PATCH] Miscellaneous for Taco

[Sean MacLennan]

Josh Boyer wrote:
>
> Ah, possibly.  Did you try doing a 'select USB_ARCH_HAS_OHCI' in the
> config 440EP section of arch/powerpc/platforms/44x/Kconfig?
>
> I'm just trying to save you some trouble.  There's nothing actually
> wrong with your patch now, other than it has to be sent to the right
> maintainer.
>
> josh
>   

That works. Thanks!

Cheers,
   Sean