All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Defining package env variables in external.mk
@ 2022-11-09  8:29 Wolfgang Grandegger
  2022-11-10 10:50 ` Juan Carrano
  0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Grandegger @ 2022-11-09  8:29 UTC (permalink / raw)
  To: buildroot

Hello,

I discovered that it's possible to define environment variable for 
certain packages in "external,mk":

   $ cd buildroot-my-external-tree
   $ cat external.mk
   ...
   UDISKS_CONF_OPTS += "--enable-fhs-media"

This works for UDISKS. Is it a legal simple way to set package variables 
for the mainline tree in the external tree?

Sorry for my ignorance.

Wolfgang

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Buildroot] Defining package env variables in external.mk
  2022-11-09  8:29 [Buildroot] Defining package env variables in external.mk Wolfgang Grandegger
@ 2022-11-10 10:50 ` Juan Carrano
  0 siblings, 0 replies; 2+ messages in thread
From: Juan Carrano @ 2022-11-10 10:50 UTC (permalink / raw)
  To: Wolfgang Grandegger; +Cc: buildroot

Hi Wolfgang,

This works because Make variables are lazily evaluated by default so
this sort of monkey-patching works.

Now, not being a BR dev myself I'd also like to know whether the devs
condone this sort of hack. I have used it myself too and helps to keep
down the number of modifications in the main tree and in the external.
The thing is that it can break if the original MK file changes too
much, but from what I see that is not so usual.

Regards,

Juan.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-10 10:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09  8:29 [Buildroot] Defining package env variables in external.mk Wolfgang Grandegger
2022-11-10 10:50 ` Juan Carrano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.