All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>, "John Snow" <jsnow@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines
Date: Fri, 10 May 2019 10:30:23 +0200	[thread overview]
Message-ID: <11e209d5-047a-d066-5995-18f46ff5382e@redhat.com> (raw)
In-Reply-To: <CAFEAcA8RoJ-ZSsn3Lhzj5hd3oYOE7Uxy8MvUUWrzhNfBmD=AWQ@mail.gmail.com>

On 09/05/2019 18.54, Peter Maydell wrote:
> On Wed, 8 May 2019 at 16:33, Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 08/05/2019 17.09, Peter Maydell wrote:
>>> On Tue, 7 May 2019 at 14:45, Thomas Huth <thuth@redhat.com> wrote:
>>>> ----------------------------------------------------------------
>>>> Kconfig settings for the Arm machines
>>>> (v2: Fix the dependency of q35 to AHCI_ICH9 in the second patch)
>>>> ----------------------------------------------------------------
>>>
>>> Hi -- this is still failing in the build test where I 'make clean'
>>
>> Very weird. What is running before the "make clean"? Could you provide
>> me with the content of i386-softmmu/config-devices.mak please?
> 
> Nothing runs before make clean -- my scripts effectively just do
> a git merge, then make clean, then make, then make check.

By the way, I think you should do "make clean" first, before the merge,
in case something changed in the "clean" rules.

> Further, if I "touch hw/i386/Kconfig" and then run make, nothing
> is rebuilt at all, so something seems to be wrong with our
> makefile dependencies somewhere.

I've sent a patch now, please have a look at "Makefile: Fix inclusion of
the config-devices.mak.d Kconfig dependencies".

 Thomas


      parent reply	other threads:[~2019-05-10  8:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:45 [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines Thomas Huth
2019-05-07 13:45 ` [Qemu-devel] [PULL v2 02/28] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device Thomas Huth
2019-05-08 15:09 ` [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines Peter Maydell
2019-05-08 15:33   ` Thomas Huth
2019-05-08 16:43     ` Philippe Mathieu-Daudé
2019-05-08 16:45       ` Philippe Mathieu-Daudé
2019-05-09  5:34         ` Thomas Huth
2019-05-09  9:32           ` Philippe Mathieu-Daudé
2019-05-09 16:54     ` Peter Maydell
2019-05-09 17:44       ` Philippe Mathieu-Daudé
2019-05-10  7:52       ` Thomas Huth
2019-05-10  9:05         ` Peter Maydell
2019-05-10  8:30       ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11e209d5-047a-d066-5995-18f46ff5382e@redhat.com \
    --to=thuth@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.