All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>, "John Snow" <jsnow@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines
Date: Fri, 10 May 2019 10:05:00 +0100	[thread overview]
Message-ID: <CAFEAcA8dfNqyWrJZEL-h70s6feHtzfaz+cR6toO42UjvDA8O4Q@mail.gmail.com> (raw)
In-Reply-To: <a5711506-3f6a-bc5e-f991-9d730d2f7dee@redhat.com>

On Fri, 10 May 2019 at 08:52, Thomas Huth <thuth@redhat.com> wrote:
>
> On 09/05/2019 18.54, Peter Maydell wrote:
> > Further, if I "touch hw/i386/Kconfig" and then run make, nothing
> > is rebuilt at all, so something seems to be wrong with our
> > makefile dependencies somewhere.
>
> Now that's a good hint. There is definitely something wrong with the
> dependencies here. I can see that I've got a file called
> "x86_64-softmmu-config.devices.mak.d" in my build directory, but
> apparently the Makefile tries to include
> x86_64-softmmu/config-devices.mak.d via the SUBDIR_DEVICES_MAK_DEP
> variable instead. Since that file does not exist, the dependencies are
> completely ignored... Paolo, what was the intention here? Should the
> dependencies always be generated in the *softmmu folders instead?

I think the .mak.d files should live in the foo-softmmu/
subdirectories, because that puts them next to the .mak
files that they're the dependencies for (it also avoids
the slightly aesthetically unpleasing very long filenames
in the root of the build directory).

thanks
-- PMM


  reply	other threads:[~2019-05-10  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:45 [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines Thomas Huth
2019-05-07 13:45 ` [Qemu-devel] [PULL v2 02/28] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device Thomas Huth
2019-05-08 15:09 ` [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines Peter Maydell
2019-05-08 15:33   ` Thomas Huth
2019-05-08 16:43     ` Philippe Mathieu-Daudé
2019-05-08 16:45       ` Philippe Mathieu-Daudé
2019-05-09  5:34         ` Thomas Huth
2019-05-09  9:32           ` Philippe Mathieu-Daudé
2019-05-09 16:54     ` Peter Maydell
2019-05-09 17:44       ` Philippe Mathieu-Daudé
2019-05-10  7:52       ` Thomas Huth
2019-05-10  9:05         ` Peter Maydell [this message]
2019-05-10  8:30       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8dfNqyWrJZEL-h70s6feHtzfaz+cR6toO42UjvDA8O4Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.