All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic
Date: Mon, 25 Mar 2019 16:07:11 +0000	[thread overview]
Message-ID: <120740997b8dab076d17f91625de73b40ae54b48.camel@toradex.com> (raw)
In-Reply-To: <20190313082845.70B83C21FAB@lists.denx.de>

Hi Stefano

On Wed, 2019-03-13 at 08:28 +0000, sbabic at denx.de wrote:
> > The phy_connect_dev(...) function from phy.c does all the handling
> > (inclusive catching fixed-link).
> > So we drop here the single steps and call just
> > phy_connect_dev(...).
> > Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com
> > >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> Applied to u-boot-imx, master, thanks !
> 
> Best regards,
> Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing 
my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device
tree enablement and driver model conversion") I noticed that Ethernet
no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000
Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx # 

Bisecting points to this commit and reverting it indeed makes it work
again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Cheers

Marcel

  reply	other threads:[~2019-03-25 16:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13  8:28 [U-Boot] [PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic sbabic at denx.de
2019-03-25 16:07 ` Marcel Ziswiler [this message]
2019-03-25 22:13   ` [U-Boot] [REGRESSION: PATCH " Lukasz Majewski
2019-03-28 10:47     ` Lukasz Majewski
2019-03-28 11:04       ` [U-Boot] Antwort: " Hannes Schmelzer
2019-03-26  9:02   ` [U-Boot] " Hannes Schmelzer
2019-03-26  9:15   ` Hannes Schmelzer
2019-03-26 10:34     ` Marcel Ziswiler
     [not found]       ` <a15ae90f-044f-e3d7-97d4-e80f00c8f713@schmelzer.or.at>
     [not found]         ` <a1322b72c77a87656157799dd1f48600cbb36c55.camel@toradex.com>
     [not found]           ` <697EBFC1-D953-45F7-A781-732BB79AD510@schmelzer.or.at>
     [not found]             ` <371b0c7b1f460192931715bbb1479174f0d13389.camel@toradex.com>
2019-03-27 13:21               ` Hannes Schmelzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=120740997b8dab076d17f91625de73b40ae54b48.camel@toradex.com \
    --to=marcel.ziswiler@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.