* [PATCH net] net: phy: phylink: fix uninitialized variable in phy_resolve
@ 2019-02-26 7:23 Heiner Kallweit
0 siblings, 0 replies; only message in thread
From: Heiner Kallweit @ 2019-02-26 7:23 UTC (permalink / raw)
To: Russell King - ARM Linux, David Miller, Andrew Lunn, Florian Fainelli
Cc: netdev
When debugging an issue I found implausible values in state->pause.
Reason in that state->pause isn't initialized and later only single
bits are changed. Also the struct itself isn't initialized in
phylink_resolve(). So better initialize state->pause.
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/phylink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 59d175a5b..a9954c205 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -324,6 +324,7 @@ static int phylink_get_mac_state(struct phylink *pl, struct phylink_link_state *
linkmode_zero(state->lp_advertising);
state->interface = pl->link_config.interface;
state->an_enabled = pl->link_config.an_enabled;
+ state->pause = MLO_PAUSE_NONE;
state->link = 1;
return pl->ops->mac_link_state(ndev, state);
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-26 7:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 7:23 [PATCH net] net: phy: phylink: fix uninitialized variable in phy_resolve Heiner Kallweit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.