From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Richardson,
Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf
Date: Wed, 25 Jun 2014 10:33:04 +0200 [thread overview]
Message-ID: <12214985.ClK2CaJOyY@xps13> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE3359-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-24 17:39, Richardson, Bruce:
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen Hemminger
> > The function rte_snprintf serves no useful purpose. It is the
> > same as snprintf() for all valid inputs. Just remove it and
> > replace all uses in current code.
>
> NAK to this as is.
> Approve of replacing all instance of the rte_snprintf function with the
> standard version in all our code and libraries. However, rather than just
> removing the function completely, I think we should just flag the function
> as deprecated initially, and then later on look to remove it completely.
I agree we should try to use the "deprecated" attribute when possible.
So application porting effort will be smoother.
But in this case, there is something different: as Stephen wrote, rte_snprintf
is useless. It's useless inside the DPDK so it's even more useless for user
applications.
As it's really useless, it has no sense to keep it as deprecated.
Please, let's simply remove it.
--
Thomas
next prev parent reply other threads:[~2014-06-25 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 16:02 [PATCH 1/3] stringfns: remove rte_snprintf Stephen Hemminger
[not found] ` <20140624090253.140206a7-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-24 16:03 ` [PATCH 2/3] test: remove no longer valid tests Stephen Hemminger
2014-06-24 16:05 ` [PATCH 3/3] fix incorrect snprintf usage Stephen Hemminger
2014-06-24 17:39 ` [PATCH 1/3] stringfns: remove rte_snprintf Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B02CEE3359-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-24 17:54 ` Stephen Hemminger
[not found] ` <20140624105427.166c21bf-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-24 18:00 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B02CEE345B-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-25 7:55 ` Olivier MATZ
2014-06-25 8:33 ` Thomas Monjalon [this message]
2014-06-26 15:09 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B02CEF87D2-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-26 16:20 ` Aaron Campbell
[not found] ` <5590E373-EC37-4544-A983-52156CFA81E2-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
2014-06-27 0:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12214985.ClK2CaJOyY@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.