All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>,
	"Richardson,
	Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf
Date: Fri, 27 Jun 2014 02:37:09 +0200	[thread overview]
Message-ID: <1844098.FugtUsePJs@xps13> (raw)
In-Reply-To: <5590E373-EC37-4544-A983-52156CFA81E2-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>

2014-06-26 13:20, Aaron Campbell:
> On Jun 26, 2014, at 12:09 PM, Richardson, Bruce <bruce.richardson@intel.com> 
wrote:
> >> I agree we should try to use the "deprecated" attribute when possible.
> >> So application porting effort will be smoother.
> >> 
> >> But in this case, there is something different: as Stephen wrote,
> >> rte_snprintf is useless. It's useless inside the DPDK so it's even more
> >> useless for user applications.
> >> As it's really useless, it has no sense to keep it as deprecated.
> >> Please, let's simply remove it.
> > 
> > The reason to keep it as deprecated is so that those customers who don't
> > want to do a huge amount of search-replace immediately can get things
> > working again temporarily using -Wno-deprecated. It provides a simple
> > temporary fallback cushion, and then we can completely remove the
> > function later. So, I'd like to see us remove all our usage of the
> > function internally in 1.7, along with marking as deprecated, and then
> > completely remove in 1.8, (i.e. in a week's time or so) :-)
> 
> As a DPDK user, I’d vote to kill it now.  I doubt it is widely used in any
> external applications.  Such usage would be mostly from copy/pasting the
> sample code, is my guess.

I think everybody understood the idea: we'll try to use deprecation model when 
possible.
In this case, it's probably useless but we close the discussion by deprecating 
it. We'll remove it soon, don't worry :)

-- 
Thomas

      parent reply	other threads:[~2014-06-27  0:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 16:02 [PATCH 1/3] stringfns: remove rte_snprintf Stephen Hemminger
     [not found] ` <20140624090253.140206a7-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-24 16:03   ` [PATCH 2/3] test: remove no longer valid tests Stephen Hemminger
2014-06-24 16:05   ` [PATCH 3/3] fix incorrect snprintf usage Stephen Hemminger
2014-06-24 17:39   ` [PATCH 1/3] stringfns: remove rte_snprintf Richardson, Bruce
     [not found]     ` <59AF69C657FD0841A61C55336867B5B02CEE3359-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-24 17:54       ` Stephen Hemminger
     [not found]         ` <20140624105427.166c21bf-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-24 18:00           ` Richardson, Bruce
     [not found]             ` <59AF69C657FD0841A61C55336867B5B02CEE345B-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-25  7:55               ` Olivier MATZ
2014-06-25  8:33       ` Thomas Monjalon
2014-06-26 15:09         ` Richardson, Bruce
     [not found]           ` <59AF69C657FD0841A61C55336867B5B02CEF87D2-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-26 16:20             ` Aaron Campbell
     [not found]               ` <5590E373-EC37-4544-A983-52156CFA81E2-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
2014-06-27  0:37                 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1844098.FugtUsePJs@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org \
    --cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.