* Re: [PATCH] KVM: x86: enable -Werror
@ 2020-02-13 1:40 linmiaohe
2020-02-13 3:31 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: linmiaohe @ 2020-02-13 1:40 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, kvm
Paolo Bonzini <pbonzini@redhat.com> wrote:
>Avoid more embarrassing mistakes. At least those that the compiler can catch.
>
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>---
Never mind. It is said that "Not everybody is a sage. Who can be entirely free from error?" :)
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: x86: enable -Werror
2020-02-13 1:40 [PATCH] KVM: x86: enable -Werror linmiaohe
@ 2020-02-13 3:31 ` Joe Perches
2020-02-13 9:54 ` Paolo Bonzini
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2020-02-13 3:31 UTC (permalink / raw)
To: linmiaohe, Paolo Bonzini, Linus Walleij; +Cc: linux-kernel, kvm
On Thu, 2020-02-13 at 01:40 +0000, linmiaohe wrote:
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Avoid more embarrassing mistakes. At least those that the compiler can catch.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
I think adding -Werror is a bad idea as
new versions of compilers can create
additional compilation warnings and
break builds in the future.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: x86: enable -Werror
2020-02-13 3:31 ` Joe Perches
@ 2020-02-13 9:54 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2020-02-13 9:54 UTC (permalink / raw)
To: Joe Perches, linmiaohe, Linus Walleij; +Cc: linux-kernel, kvm
On 13/02/20 04:31, Joe Perches wrote:
> On Thu, 2020-02-13 at 01:40 +0000, linmiaohe wrote:
>> Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Avoid more embarrassing mistakes. At least those that the compiler can catch.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>
> I think adding -Werror is a bad idea as new versions of compilers can
> create additional compilation warnings and break builds in the
> future.
Seems like cargo culting (in the reverse) to me. We can cross the
bridge when we get there.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] KVM: x86: enable -Werror
@ 2020-02-12 19:20 Paolo Bonzini
2020-02-20 13:44 ` Vitaly Kuznetsov
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2020-02-12 19:20 UTC (permalink / raw)
To: linux-kernel, kvm
Avoid more embarrassing mistakes. At least those that the compiler
can catch.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
index b19ef421084d..4654e97a05cc 100644
--- a/arch/x86/kvm/Makefile
+++ b/arch/x86/kvm/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
ccflags-y += -Iarch/x86/kvm
+ccflags-y += -Werror
KVM := ../../../virt/kvm
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: x86: enable -Werror
2020-02-12 19:20 Paolo Bonzini
@ 2020-02-20 13:44 ` Vitaly Kuznetsov
2020-02-20 19:39 ` Sean Christopherson
0 siblings, 1 reply; 6+ messages in thread
From: Vitaly Kuznetsov @ 2020-02-20 13:44 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, kvm
Paolo Bonzini <pbonzini@redhat.com> writes:
> Avoid more embarrassing mistakes.
"avoid more" != "make less" :-)
> At least those that the compiler can catch.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/kvm/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index b19ef421084d..4654e97a05cc 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -1,6 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
>
> ccflags-y += -Iarch/x86/kvm
> +ccflags-y += -Werror
>
> KVM := ../../../virt/kvm
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: x86: enable -Werror
2020-02-20 13:44 ` Vitaly Kuznetsov
@ 2020-02-20 19:39 ` Sean Christopherson
0 siblings, 0 replies; 6+ messages in thread
From: Sean Christopherson @ 2020-02-20 19:39 UTC (permalink / raw)
To: Vitaly Kuznetsov; +Cc: Paolo Bonzini, linux-kernel, kvm
On Thu, Feb 20, 2020 at 02:44:00PM +0100, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > Avoid more embarrassing mistakes.
>
> "avoid more" != "make less" :-)
Ha! "Fail the build so embarrassing mistakes are *really* emabarrassing".
Where there's a will, there's a way. :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-20 19:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 1:40 [PATCH] KVM: x86: enable -Werror linmiaohe
2020-02-13 3:31 ` Joe Perches
2020-02-13 9:54 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2020-02-12 19:20 Paolo Bonzini
2020-02-20 13:44 ` Vitaly Kuznetsov
2020-02-20 19:39 ` Sean Christopherson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.