All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: remove ieee80211_notify_mac
Date: Mon, 17 Nov 2008 18:28:07 +0100	[thread overview]
Message-ID: <1226942887.3902.30.camel@johannes.berg> (raw)
In-Reply-To: <1ba2fa240811170714j7d0daf5xe718ffa1d4de8f40@mail.gmail.com> (sfid-20081117_161447_403583_F9BC9E33)

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

On Mon, 2008-11-17 at 17:14 +0200, Tomas Winkler wrote:

> > The point is that the whole thing about disassociation is already the
> > wrong assumption. As I've outlined, it only works in STA mode, and thus
> > the function is generally not very useful.
> >
> >> I agree that resume/suspend shell be handled properly in the mac80211
> >> regardless of this issue.
> >
> > And it will handle the "firmware crashed" case perfectly too.
> 
> You may have a case, anyhow, please show us some RFC before you remove
> of mac notify.

I don't have any, but given the current deficiencies, I don't think the
notify callback is worth keeping especially in light of the locking
nightmare it's creating. What does it fix anyway? No user ever
complained about slow re-association at resume time that I've heard, and
no driver but iwlwifi tries to speed it up.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-11-17 17:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  9:59 [RFC] mac80211: remove ieee80211_notify_mac Johannes Berg
2008-11-17 14:32 ` Tomas Winkler
2008-11-17 14:45   ` Johannes Berg
2008-11-17 15:14     ` Tomas Winkler
2008-11-17 17:28       ` Johannes Berg [this message]
     [not found]         ` <1ba2fa240811170934u34fa6e28m1411715690fd24b9@mail.gmail.com>
2008-11-17 17:59           ` Johannes Berg
2008-11-17 18:12             ` Tomas Winkler
2008-11-17 19:46               ` Johannes Berg
2008-11-18 14:20                 ` Tomas Winkler
2008-11-18 19:46             ` John W. Linville
2008-11-18 23:08               ` Tomas Winkler
2008-12-05 23:53                 ` mohamed salim abbas
2008-12-06  3:27                   ` John W. Linville
2008-12-06  9:05                   ` Johannes Berg
2008-12-07  5:16                     ` mohamed salim abbas
2008-12-07 14:19                       ` Bob Copeland
2008-12-08  5:55                         ` mohamed salim abbas
2008-12-11 23:00                           ` mohamed salim abbas
2008-12-12 17:37                             ` Bob Copeland
2008-12-13  0:28                               ` mohamed salim abbas
2008-11-18  8:40         ` Marcel Holtmann
2008-11-17 17:08 ` Bob Copeland
2008-11-17 17:26   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226942887.3902.30.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.