From: Oren Laadan <orenl@cs.columbia.edu> To: Oren Laadan <orenl@cs.columbia.edu> Cc: containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, Linux Torvalds <torvalds@osdl.org>, Thomas Gleixner <tglx@linutronix.de>, Serge Hallyn <serue@us.ibm.com>, Dave Hansen <dave@linux.vnet.ibm.com>, Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>, Alexander Viro <viro@zeniv.linux.org.uk>, MinChan Kim <minchan.kim@gmail.com>, arnd@arndb.de, jeremy@goop.org, Oren Laadan <orenl@cs.columbia.edu> Subject: [RFC v11][PATCH 10/13] External checkpoint of a task other than ourself Date: Fri, 5 Dec 2008 12:31:19 -0500 [thread overview] Message-ID: <1228498282-11804-11-git-send-email-orenl@cs.columbia.edu> (raw) In-Reply-To: <1228498282-11804-1-git-send-email-orenl@cs.columbia.edu> Now we can do "external" checkpoint, i.e. act on another task. sys_checkpoint() now looks up the target pid (in our namespace) and checkpoints that corresponding task. That task should be the root of a container. sys_restart() remains the same, as the restart is always done in the context of the restarting task. Changelog[v11]: - Copy contents of 'init->fs->root' instead of pointing to them Changelog[v10]: - Grab vfs root of container init, rather than current process Signed-off-by: Oren Laadan <orenl@cs.columbia.edu> Acked-by: Serge Hallyn <serue@us.ibm.com> --- checkpoint/checkpoint.c | 72 ++++++++++++++++++++++++++++++++++++++++++- checkpoint/restart.c | 4 +- checkpoint/sys.c | 6 ++++ include/linux/checkpoint.h | 2 + 4 files changed, 80 insertions(+), 4 deletions(-) diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c index 75c7cd3..f2d91f8 100644 --- a/checkpoint/checkpoint.c +++ b/checkpoint/checkpoint.c @@ -10,6 +10,7 @@ #include <linux/version.h> #include <linux/sched.h> +#include <linux/ptrace.h> #include <linux/time.h> #include <linux/fs.h> #include <linux/file.h> @@ -225,6 +226,13 @@ static int cr_write_task(struct cr_ctx *ctx, struct task_struct *t) { int ret; + /* TODO: verity that the task is frozen (unless self) */ + + if (t->state == TASK_DEAD) { + pr_warning("c/r: task may not be in state TASK_DEAD\n"); + return -EAGAIN; + } + ret = cr_write_task_struct(ctx, t); cr_debug("task_struct: ret %d\n", ret); if (ret < 0) @@ -247,22 +255,82 @@ static int cr_write_task(struct cr_ctx *ctx, struct task_struct *t) return ret; } +static int cr_get_container(struct cr_ctx *ctx, pid_t pid) +{ + struct task_struct *task = NULL; + struct nsproxy *nsproxy = NULL; + int err = -ESRCH; + + ctx->root_pid = pid; + + read_lock(&tasklist_lock); + task = find_task_by_vpid(pid); + if (task) + get_task_struct(task); + read_unlock(&tasklist_lock); + + if (!task) + goto out; + +#if 0 /* enable to use containers */ + if (!is_container_init(task)) { + err = -EINVAL; + goto out; + } +#endif + + if (!ptrace_may_access(task, PTRACE_MODE_READ)) { + err = -EPERM; + goto out; + } + + rcu_read_lock(); + if (task_nsproxy(task)) { + nsproxy = task_nsproxy(task); + get_nsproxy(nsproxy); + } + rcu_read_unlock(); + + if (!nsproxy) + goto out; + + /* TODO: verify that the container is frozen */ + + ctx->root_task = task; + ctx->root_nsproxy = nsproxy; + + return 0; + + out: + if (task) + put_task_struct(task); + return err; +} + +/* setup checkpoint-specific parts of ctx */ static int cr_ctx_checkpoint(struct cr_ctx *ctx, pid_t pid) { struct fs_struct *fs; + int ret; ctx->root_pid = pid; + ret = cr_get_container(ctx, pid); + if (ret < 0) + return ret; + /* * assume checkpointer is in container's root vfs * FIXME: this works for now, but will change with real containers */ - fs = current->fs; + task_lock(ctx->root_task); + fs = ctx->root_task->fs; read_lock(&fs->lock); ctx->fs_mnt = fs->root; path_get(&ctx->fs_mnt); read_unlock(&fs->lock); + task_unlock(ctx->root_task); return 0; } @@ -277,7 +345,7 @@ int do_checkpoint(struct cr_ctx *ctx, pid_t pid) ret = cr_write_head(ctx); if (ret < 0) goto out; - ret = cr_write_task(ctx, current); + ret = cr_write_task(ctx, ctx->root_task); if (ret < 0) goto out; ret = cr_write_tail(ctx); diff --git a/checkpoint/restart.c b/checkpoint/restart.c index 22e7995..f4f737d 100644 --- a/checkpoint/restart.c +++ b/checkpoint/restart.c @@ -277,7 +277,7 @@ static int cr_read_task(struct cr_ctx *ctx) } /* setup restart-specific parts of ctx */ -static int cr_ctx_restart(struct cr_ctx *ctx) +static int cr_ctx_restart(struct cr_ctx *ctx, pid_t pid) { return 0; } @@ -286,7 +286,7 @@ int do_restart(struct cr_ctx *ctx, pid_t pid) { int ret; - ret = cr_ctx_restart(ctx); + ret = cr_ctx_restart(ctx, pid); if (ret < 0) goto out; ret = cr_read_head(ctx); diff --git a/checkpoint/sys.c b/checkpoint/sys.c index c077cd9..7083fff 100644 --- a/checkpoint/sys.c +++ b/checkpoint/sys.c @@ -9,6 +9,7 @@ */ #include <linux/sched.h> +#include <linux/nsproxy.h> #include <linux/kernel.h> #include <linux/fs.h> #include <linux/file.h> @@ -141,6 +142,11 @@ static void cr_ctx_free(struct cr_ctx *ctx) cr_pgarr_free(ctx); cr_objhash_free(ctx); + if (ctx->root_nsproxy) + put_nsproxy(ctx->root_nsproxy); + if (ctx->root_task) + put_task_struct(ctx->root_task); + kfree(ctx); } diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h index 3649f9c..3c29f8e 100644 --- a/include/linux/checkpoint.h +++ b/include/linux/checkpoint.h @@ -19,6 +19,8 @@ struct cr_ctx { int crid; /* unique checkpoint id */ pid_t root_pid; /* container identifier */ + struct task_struct *root_task; /* container root task */ + struct nsproxy *root_nsproxy; /* container root nsproxy */ unsigned long flags; unsigned long oflags; /* restart: old flags */ -- 1.5.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Oren Laadan <orenl@cs.columbia.edu> To: Oren Laadan <orenl@cs.columbia.edu> Cc: containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, Linux Torvalds <torvalds@osdl.org>, Thomas Gleixner <tglx@linutronix.de>, Serge Hallyn <serue@us.ibm.com>, Dave Hansen <dave@linux.vnet.ibm.com>, Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>, Alexander Viro <viro@zeniv.linux.org.uk>, MinChan Kim <minchan.kim@gmail.com>, arnd@arndb.de, jeremy@goop.org Subject: [RFC v11][PATCH 10/13] External checkpoint of a task other than ourself Date: Fri, 5 Dec 2008 12:31:19 -0500 [thread overview] Message-ID: <1228498282-11804-11-git-send-email-orenl@cs.columbia.edu> (raw) In-Reply-To: <1228498282-11804-1-git-send-email-orenl@cs.columbia.edu> Now we can do "external" checkpoint, i.e. act on another task. sys_checkpoint() now looks up the target pid (in our namespace) and checkpoints that corresponding task. That task should be the root of a container. sys_restart() remains the same, as the restart is always done in the context of the restarting task. Changelog[v11]: - Copy contents of 'init->fs->root' instead of pointing to them Changelog[v10]: - Grab vfs root of container init, rather than current process Signed-off-by: Oren Laadan <orenl@cs.columbia.edu> Acked-by: Serge Hallyn <serue@us.ibm.com> --- checkpoint/checkpoint.c | 72 ++++++++++++++++++++++++++++++++++++++++++- checkpoint/restart.c | 4 +- checkpoint/sys.c | 6 ++++ include/linux/checkpoint.h | 2 + 4 files changed, 80 insertions(+), 4 deletions(-) diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c index 75c7cd3..f2d91f8 100644 --- a/checkpoint/checkpoint.c +++ b/checkpoint/checkpoint.c @@ -10,6 +10,7 @@ #include <linux/version.h> #include <linux/sched.h> +#include <linux/ptrace.h> #include <linux/time.h> #include <linux/fs.h> #include <linux/file.h> @@ -225,6 +226,13 @@ static int cr_write_task(struct cr_ctx *ctx, struct task_struct *t) { int ret; + /* TODO: verity that the task is frozen (unless self) */ + + if (t->state == TASK_DEAD) { + pr_warning("c/r: task may not be in state TASK_DEAD\n"); + return -EAGAIN; + } + ret = cr_write_task_struct(ctx, t); cr_debug("task_struct: ret %d\n", ret); if (ret < 0) @@ -247,22 +255,82 @@ static int cr_write_task(struct cr_ctx *ctx, struct task_struct *t) return ret; } +static int cr_get_container(struct cr_ctx *ctx, pid_t pid) +{ + struct task_struct *task = NULL; + struct nsproxy *nsproxy = NULL; + int err = -ESRCH; + + ctx->root_pid = pid; + + read_lock(&tasklist_lock); + task = find_task_by_vpid(pid); + if (task) + get_task_struct(task); + read_unlock(&tasklist_lock); + + if (!task) + goto out; + +#if 0 /* enable to use containers */ + if (!is_container_init(task)) { + err = -EINVAL; + goto out; + } +#endif + + if (!ptrace_may_access(task, PTRACE_MODE_READ)) { + err = -EPERM; + goto out; + } + + rcu_read_lock(); + if (task_nsproxy(task)) { + nsproxy = task_nsproxy(task); + get_nsproxy(nsproxy); + } + rcu_read_unlock(); + + if (!nsproxy) + goto out; + + /* TODO: verify that the container is frozen */ + + ctx->root_task = task; + ctx->root_nsproxy = nsproxy; + + return 0; + + out: + if (task) + put_task_struct(task); + return err; +} + +/* setup checkpoint-specific parts of ctx */ static int cr_ctx_checkpoint(struct cr_ctx *ctx, pid_t pid) { struct fs_struct *fs; + int ret; ctx->root_pid = pid; + ret = cr_get_container(ctx, pid); + if (ret < 0) + return ret; + /* * assume checkpointer is in container's root vfs * FIXME: this works for now, but will change with real containers */ - fs = current->fs; + task_lock(ctx->root_task); + fs = ctx->root_task->fs; read_lock(&fs->lock); ctx->fs_mnt = fs->root; path_get(&ctx->fs_mnt); read_unlock(&fs->lock); + task_unlock(ctx->root_task); return 0; } @@ -277,7 +345,7 @@ int do_checkpoint(struct cr_ctx *ctx, pid_t pid) ret = cr_write_head(ctx); if (ret < 0) goto out; - ret = cr_write_task(ctx, current); + ret = cr_write_task(ctx, ctx->root_task); if (ret < 0) goto out; ret = cr_write_tail(ctx); diff --git a/checkpoint/restart.c b/checkpoint/restart.c index 22e7995..f4f737d 100644 --- a/checkpoint/restart.c +++ b/checkpoint/restart.c @@ -277,7 +277,7 @@ static int cr_read_task(struct cr_ctx *ctx) } /* setup restart-specific parts of ctx */ -static int cr_ctx_restart(struct cr_ctx *ctx) +static int cr_ctx_restart(struct cr_ctx *ctx, pid_t pid) { return 0; } @@ -286,7 +286,7 @@ int do_restart(struct cr_ctx *ctx, pid_t pid) { int ret; - ret = cr_ctx_restart(ctx); + ret = cr_ctx_restart(ctx, pid); if (ret < 0) goto out; ret = cr_read_head(ctx); diff --git a/checkpoint/sys.c b/checkpoint/sys.c index c077cd9..7083fff 100644 --- a/checkpoint/sys.c +++ b/checkpoint/sys.c @@ -9,6 +9,7 @@ */ #include <linux/sched.h> +#include <linux/nsproxy.h> #include <linux/kernel.h> #include <linux/fs.h> #include <linux/file.h> @@ -141,6 +142,11 @@ static void cr_ctx_free(struct cr_ctx *ctx) cr_pgarr_free(ctx); cr_objhash_free(ctx); + if (ctx->root_nsproxy) + put_nsproxy(ctx->root_nsproxy); + if (ctx->root_task) + put_task_struct(ctx->root_task); + kfree(ctx); } diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h index 3649f9c..3c29f8e 100644 --- a/include/linux/checkpoint.h +++ b/include/linux/checkpoint.h @@ -19,6 +19,8 @@ struct cr_ctx { int crid; /* unique checkpoint id */ pid_t root_pid; /* container identifier */ + struct task_struct *root_task; /* container root task */ + struct nsproxy *root_nsproxy; /* container root nsproxy */ unsigned long flags; unsigned long oflags; /* restart: old flags */ -- 1.5.4.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-05 17:42 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-12-05 17:31 [RFC v11][PATCH 00/13] Kernel based checkpoint/restart Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 01/13] Create syscalls: sys_checkpoint, sys_restart Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 02/13] Checkpoint/restart: initial documentation Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 03/13] General infrastructure for checkpoint restart Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-06 7:26 ` Joe Perches 2008-12-06 7:26 ` Joe Perches 2008-12-06 7:26 ` Joe Perches [not found] ` <1228498282-11804-4-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-06 7:26 ` Joe Perches 2008-12-16 19:04 ` Mike Waychison 2008-12-16 21:54 ` Mike Waychison 2008-12-16 19:04 ` Mike Waychison 2008-12-16 19:04 ` Mike Waychison 2008-12-16 19:28 ` Linus Torvalds 2008-12-16 19:28 ` Linus Torvalds [not found] ` <4947FBC8.2000601-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-16 19:28 ` Linus Torvalds 2008-12-16 21:54 ` Mike Waychison 2008-12-16 21:54 ` Mike Waychison 2008-12-16 22:14 ` Dave Hansen 2008-12-16 22:14 ` Dave Hansen 2008-12-16 22:43 ` Mike Waychison 2008-12-16 22:43 ` Mike Waychison 2008-12-16 22:43 ` Mike Waychison 2008-12-17 0:13 ` Dave Hansen 2008-12-17 0:13 ` Dave Hansen [not found] ` <49482F14.1040407-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-17 0:13 ` Dave Hansen 2008-12-16 23:42 ` Oren Laadan 2008-12-16 23:42 ` Oren Laadan [not found] ` <49483D01.1050603-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-17 0:42 ` Mike Waychison 2008-12-17 0:42 ` Mike Waychison 2008-12-17 0:42 ` Mike Waychison [not found] ` <49484AE2.3000007-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-17 2:08 ` Oren Laadan 2008-12-17 2:08 ` Oren Laadan 2008-12-17 2:08 ` Oren Laadan 2008-12-16 23:42 ` Oren Laadan [not found] ` <49482394.10006-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-16 22:14 ` Dave Hansen 2008-12-05 17:31 ` [RFC v11][PATCH 04/13] x86 support for checkpoint/restart Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-17 2:19 ` Mike Waychison 2008-12-17 2:19 ` Mike Waychison 2008-12-17 15:23 ` Oren Laadan 2008-12-17 15:23 ` Oren Laadan [not found] ` <494861CA.8000403-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-17 15:23 ` Oren Laadan [not found] ` <1228498282-11804-5-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-17 2:19 ` Mike Waychison 2008-12-05 17:31 ` [RFC v11][PATCH 05/13] Dump memory address space Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan [not found] ` <1228498282-11804-6-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-18 2:26 ` Mike Waychison 2008-12-18 2:26 ` Mike Waychison 2008-12-18 2:26 ` Mike Waychison 2008-12-18 11:10 ` Oren Laadan 2008-12-18 11:10 ` Oren Laadan 2008-12-18 15:05 ` Dave Hansen 2008-12-18 15:05 ` Dave Hansen 2008-12-18 15:05 ` Dave Hansen 2008-12-18 15:54 ` Dave Hansen 2008-12-18 15:54 ` Dave Hansen 2008-12-18 15:54 ` Dave Hansen 2008-12-18 20:00 ` Oren Laadan 2008-12-18 20:00 ` Oren Laadan 2008-12-18 20:00 ` Oren Laadan [not found] ` <494A2F94.2090800-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-18 15:05 ` Dave Hansen 2008-12-18 15:54 ` Dave Hansen 2008-12-18 18:15 ` Mike Waychison 2008-12-18 18:15 ` Mike Waychison 2008-12-18 18:15 ` Mike Waychison 2008-12-18 18:21 ` Dave Hansen 2008-12-18 18:21 ` Dave Hansen 2008-12-18 18:21 ` Dave Hansen [not found] ` <494A9350.1060309-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-18 18:21 ` Dave Hansen 2008-12-18 20:11 ` Oren Laadan 2008-12-18 20:11 ` Oren Laadan 2008-12-18 20:11 ` Oren Laadan [not found] ` <4949B4ED.9060805-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2008-12-18 11:10 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 06/13] Restore " Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 07/13] Infrastructure for shared objects Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 08/13] Dump open file descriptors Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 09/13] Restore open file descriprtors Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 10/13] External checkpoint of a task other than ourself Oren Laadan 2008-12-05 17:31 ` Oren Laadan [this message] 2008-12-05 17:31 ` Oren Laadan [not found] ` <1228498282-11804-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> 2008-12-05 17:31 ` [RFC v11][PATCH 01/13] Create syscalls: sys_checkpoint, sys_restart Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 02/13] Checkpoint/restart: initial documentation Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 03/13] General infrastructure for checkpoint restart Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 04/13] x86 support for checkpoint/restart Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 05/13] Dump memory address space Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 06/13] Restore " Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 07/13] Infrastructure for shared objects Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 08/13] Dump open file descriptors Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 09/13] Restore open file descriprtors Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 10/13] External checkpoint of a task other than ourself Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 11/13] Track in-kernel when we expect checkpoint/restart to work Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 12/13] Checkpoint multiple processes Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 13/13] Restart " Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-06 0:19 ` [RFC v11][PATCH 00/13] Kernel based checkpoint/restart Serge E. Hallyn 2008-12-09 19:42 ` Serge E. Hallyn 2008-12-16 18:43 ` Dave Hansen 2008-12-05 17:31 ` [RFC v11][PATCH 11/13] Track in-kernel when we expect checkpoint/restart to work Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 12/13] Checkpoint multiple processes Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` [RFC v11][PATCH 13/13] Restart " Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-05 17:31 ` Oren Laadan 2008-12-06 0:19 ` [RFC v11][PATCH 00/13] Kernel based checkpoint/restart Serge E. Hallyn 2008-12-06 0:19 ` Serge E. Hallyn 2008-12-06 0:19 ` Serge E. Hallyn 2008-12-09 19:42 ` Serge E. Hallyn 2008-12-09 19:42 ` Serge E. Hallyn 2008-12-09 19:42 ` Serge E. Hallyn 2008-12-16 18:43 ` Dave Hansen 2008-12-16 18:43 ` Dave Hansen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1228498282-11804-11-git-send-email-orenl@cs.columbia.edu \ --to=orenl@cs.columbia.edu \ --cc=arnd@arndb.de \ --cc=containers@lists.linux-foundation.org \ --cc=dave@linux.vnet.ibm.com \ --cc=hpa@zytor.com \ --cc=jeremy@goop.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan.kim@gmail.com \ --cc=mingo@elte.hu \ --cc=serue@us.ibm.com \ --cc=tglx@linutronix.de \ --cc=torvalds@osdl.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.