All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Glendinning <steve.glendinning@smsc.com>
To: netdev@vger.kernel.org
Cc: Ian Saturley <ian.saturley@smsc.com>,
	Steve Glendinning <steve.glendinning@smsc.com>
Subject: [RFC PATCH 0/2] unify full duplex flow control resolution
Date: Sun, 14 Dec 2008 12:38:19 +0000	[thread overview]
Message-ID: <1229258301-5073-1-git-send-email-steve.glendinning@smsc.com> (raw)

4 drivers (tg3, smsc911x, smsc9420 & smsc9500) have identical full 
duplex flow control resolution functions (primarily because I re-used
tg3's implementation for the 3 SMSC drivers).  This patchset moves this 
to an inline function in mii.h and changes the 4 drivers to use it.

It's a small enough function, and it's only used once in each driver,
but I'm still not completely sure inline is right.  These drivers 
don't all have a dependency on mii.c though, and I wanted to avoid 
adding this to the SMSC drivers that have been converted to phylib.

--
Steve Glendinning (2):
  move flow control definitions to mii.h
  refactor full duplex flow control resolution

 drivers/net/smsc911x.c     |   24 +-------------
 drivers/net/smsc911x.h     |    3 --
 drivers/net/smsc9420.c     |   24 +-------------
 drivers/net/smsc9420.h     |    3 --
 drivers/net/tg3.c          |   74 +++++++++++++++----------------------------
 drivers/net/tg3.h          |    2 -
 drivers/net/usb/smsc95xx.c |   26 +---------------
 include/linux/mii.h        |   33 +++++++++++++++++++
 8 files changed, 62 insertions(+), 127 deletions(-)


             reply	other threads:[~2008-12-14 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-14 12:38 Steve Glendinning [this message]
2008-12-14 12:38 ` [RFC PATCH 1/2] move flow control definitions to mii.h Steve Glendinning
2008-12-14 12:38   ` [RFC PATCH 2/2] refactor full duplex flow control resolution Steve Glendinning
2008-12-16 10:00     ` David Miller
2008-12-23 17:45     ` Ben Hutchings
2008-12-29 17:12       ` Steve.Glendinning
2008-12-16 10:00   ` [RFC PATCH 1/2] move flow control definitions to mii.h David Miller
2008-12-18  0:17   ` Andrew Morton
2008-12-18  0:27     ` David Miller
2008-12-23 17:47   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229258301-5073-1-git-send-email-steve.glendinning@smsc.com \
    --to=steve.glendinning@smsc.com \
    --cc=ian.saturley@smsc.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.