All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Steve Glendinning <steve.glendinning@smsc.com>
Cc: netdev@vger.kernel.org, Ian Saturley <ian.saturley@smsc.com>
Subject: Re: [RFC PATCH 1/2] move flow control definitions to mii.h
Date: Tue, 23 Dec 2008 17:47:30 +0000	[thread overview]
Message-ID: <1230054450.3402.31.camel@deadeye.i.decadent.org.uk> (raw)
In-Reply-To: <1229258301-5073-2-git-send-email-steve.glendinning@smsc.com>

On Sun, 2008-12-14 at 12:38 +0000, Steve Glendinning wrote:
[...]
> diff --git a/include/linux/mii.h b/include/linux/mii.h
> index 151b7e0..4a376e0 100644
> --- a/include/linux/mii.h
> +++ b/include/linux/mii.h
> @@ -135,6 +135,10 @@
>  #define LPA_1000FULL            0x0800  /* Link partner 1000BASE-T full duplex */
>  #define LPA_1000HALF            0x0400  /* Link partner 1000BASE-T half duplex */
>  
> +/* Flow control flags */
> +#define FLOW_CTRL_TX		0x01
> +#define FLOW_CTRL_RX		0x02
> +
>  /* This structure is used in all SIOCxMIIxxx ioctl calls */
>  struct mii_ioctl_data {
>  	__u16		phy_id;

How about a FLOW_CTRL_AUTO flag to represent whether auto-negotiation of
FC is enabled (or inversely FLOW_CTRL_FORCE)?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

      parent reply	other threads:[~2008-12-23 17:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-14 12:38 [RFC PATCH 0/2] unify full duplex flow control resolution Steve Glendinning
2008-12-14 12:38 ` [RFC PATCH 1/2] move flow control definitions to mii.h Steve Glendinning
2008-12-14 12:38   ` [RFC PATCH 2/2] refactor full duplex flow control resolution Steve Glendinning
2008-12-16 10:00     ` David Miller
2008-12-23 17:45     ` Ben Hutchings
2008-12-29 17:12       ` Steve.Glendinning
2008-12-16 10:00   ` [RFC PATCH 1/2] move flow control definitions to mii.h David Miller
2008-12-18  0:17   ` Andrew Morton
2008-12-18  0:27     ` David Miller
2008-12-23 17:47   ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230054450.3402.31.camel@deadeye.i.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=ian.saturley@smsc.com \
    --cc=netdev@vger.kernel.org \
    --cc=steve.glendinning@smsc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.