Re: [SPDK] perf vs spdk_app_start()

Re: [SPDK] perf vs spdk_app_start()

[Szwed, Maciej]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

This is actually the case. I need to register poller for event handler and that is way I would like to use spdk_app_start. Creating own thread for poller is a bit overkill for example application.

-----Original Message-----
From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Stojaczyk, Dariusz
Sent: Tuesday, October 30, 2018 10:47 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] perf vs spdk_app_start()

Nvme perf example doesn't use the app framework by design. It doesn't use reactors, pollers, events, bdevs, or so. It's just a low-level app for benchmarking the NVMe driver directly. Refactoring it to use the app framework would add some extra overhead, which is not the way to go here.

Maybe you could try exposing some low level NVMe event handler API and then use it directly in perf?

D.

> -----Original Message-----
> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Szwed, 
> Maciej
> Sent: Tuesday, October 30, 2018 10:26 AM
> To: Storage Performance Development Kit <spdk(a)lists.01.org>
> Subject: [SPDK] perf vs spdk_app_start()
> 
> Hi,
> I'm implementing NVMf event handler for initiator and I noticed that 
> perf
> (spdk\examples\nvme\perf) does not use spdk_app_start(). I'd like to 
> know if this was done on purpose? Or can I modify it so that it will 
> use spdk_app_start()?
> 
> Regards,
> Maciek
> 
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

Re: [SPDK] perf vs spdk_app_start()

[Szwed, Maciej]

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

I can leave it as it is and do it on main thread. The question is how much X is in ' every X number of I/O' to make it reasonable? Any suggestions here?

Thanks,
Maciek 

-----Original Message-----
From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Lance Hartmann ORACLE
Sent: Tuesday, October 30, 2018 7:44 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] perf vs spdk_app_start()


> On Oct 30, 2018, at 12:55 PM, Walker, Benjamin <benjamin.walker(a)intel.com> wrote:
> 
> On Tue, 2018-10-30 at 09:59 +0000, Szwed, Maciej wrote:
>> This is actually the case. I need to register poller for event 
>> handler and that is way I would like to use spdk_app_start. Creating 
>> own thread for poller is a bit overkill for example application.
> 
> The primary reason NVMe perf does not use the application framework is 
> because NVMe perf was written before the application framework 
> existed. You could definitely do a port to use it, but I kind of like 
> the independence. Any API you create in the NVMe driver should be 
> consumable without the application framework. Maybe just poll for events every X number of I/O?


I'd like to cast a vote for retaining nvme/perf as-is as well.  I found it very useful in learning the use of the SPDK nvme driver API without having to wade through the additional complexity of the app framework.

--
Lance Hartmann
lance.hartmann(a)oracle.com



_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

Re: [SPDK] perf vs spdk_app_start()

[Lance Hartmann ORACLE]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]


> On Oct 30, 2018, at 12:55 PM, Walker, Benjamin <benjamin.walker(a)intel.com> wrote:
> 
> On Tue, 2018-10-30 at 09:59 +0000, Szwed, Maciej wrote:
>> This is actually the case. I need to register poller for event handler and
>> that is way I would like to use spdk_app_start. Creating own thread for poller
>> is a bit overkill for example application.
> 
> The primary reason NVMe perf does not use the application framework is because
> NVMe perf was written before the application framework existed. You could
> definitely do a port to use it, but I kind of like the independence. Any API you
> create in the NVMe driver should be consumable without the application
> framework. Maybe just poll for events every X number of I/O?


I'd like to cast a vote for retaining nvme/perf as-is as well.  I found it very useful in learning the use of the SPDK nvme driver API without having to wade through the additional complexity of the app framework.

--
Lance Hartmann
lance.hartmann(a)oracle.com

Re: [SPDK] perf vs spdk_app_start()

[Walker, Benjamin]

[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]

On Tue, 2018-10-30 at 09:59 +0000, Szwed, Maciej wrote:
> This is actually the case. I need to register poller for event handler and
> that is way I would like to use spdk_app_start. Creating own thread for poller
> is a bit overkill for example application.

The primary reason NVMe perf does not use the application framework is because
NVMe perf was written before the application framework existed. You could
definitely do a port to use it, but I kind of like the independence. Any API you
create in the NVMe driver should be consumable without the application
framework. Maybe just poll for events every X number of I/O?


> 
> -----Original Message-----
> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Stojaczyk, Dariusz
> Sent: Tuesday, October 30, 2018 10:47 AM
> To: Storage Performance Development Kit <spdk(a)lists.01.org>
> Subject: Re: [SPDK] perf vs spdk_app_start()
> 
> Nvme perf example doesn't use the app framework by design. It doesn't use
> reactors, pollers, events, bdevs, or so. It's just a low-level app for
> benchmarking the NVMe driver directly. Refactoring it to use the app framework
> would add some extra overhead, which is not the way to go here.
> 
> Maybe you could try exposing some low level NVMe event handler API and then
> use it directly in perf?
> 
> D.
> 
> > -----Original Message-----
> > From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Szwed, 
> > Maciej
> > Sent: Tuesday, October 30, 2018 10:26 AM
> > To: Storage Performance Development Kit <spdk(a)lists.01.org>
> > Subject: [SPDK] perf vs spdk_app_start()
> > 
> > Hi,
> > I'm implementing NVMf event handler for initiator and I noticed that 
> > perf
> > (spdk\examples\nvme\perf) does not use spdk_app_start(). I'd like to 
> > know if this was done on purpose? Or can I modify it so that it will 
> > use spdk_app_start()?
> > 
> > Regards,
> > Maciek
> > 
> > _______________________________________________
> > SPDK mailing list
> > SPDK(a)lists.01.org
> > https://lists.01.org/mailman/listinfo/spdk
> 
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk

Re: [SPDK] perf vs spdk_app_start()

[Stojaczyk, Dariusz]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Nvme perf example doesn't use the app framework by design. It doesn't use reactors, pollers, events, bdevs, or so. It's just a low-level app for benchmarking the NVMe driver directly. Refactoring it to use the app framework would add some extra overhead, which is not the way to go here.

Maybe you could try exposing some low level NVMe event handler API and then use it directly in perf?

D.

> -----Original Message-----
> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Szwed, Maciej
> Sent: Tuesday, October 30, 2018 10:26 AM
> To: Storage Performance Development Kit <spdk(a)lists.01.org>
> Subject: [SPDK] perf vs spdk_app_start()
> 
> Hi,
> I'm implementing NVMf event handler for initiator and I noticed that perf
> (spdk\examples\nvme\perf) does not use spdk_app_start(). I'd like to know
> if this was done on purpose? Or can I modify it so that it will use
> spdk_app_start()?
> 
> Regards,
> Maciek
> 
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk

[SPDK] perf vs spdk_app_start()

[Szwed, Maciej]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Hi,
I'm implementing NVMf event handler for initiator and I noticed that perf (spdk\examples\nvme\perf) does not use spdk_app_start(). I'd like to know if this was done on purpose? Or can I modify it so that it will use spdk_app_start()?

Regards,
Maciek