All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Janitor fixes for net/ipv4/Kconfig
@ 2009-02-20 14:59 ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 14:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Here is two janitor documentation fixes for net/ipv4/Kconfig.

-- 
Med venlig hilsen / Best regards
  Jesper Brouer
  ComX Networks A/S
  Linux Network developer
  Cand. Scient Datalog / MSc.
  Author of http://adsl-optimizer.dk
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 0/2] Janitor fixes for net/ipv4/Kconfig
@ 2009-02-20 14:59 ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 14:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Here is two janitor documentation fixes for net/ipv4/Kconfig.

-- 
Med venlig hilsen / Best regards
  Jesper Brouer
  ComX Networks A/S
  Linux Network developer
  Cand. Scient Datalog / MSc.
  Author of http://adsl-optimizer.dk
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 1/2] Doc: Fix rp_filter description in net/ipv4/Kconfig.
  2009-02-20 14:59 ` Jesper Dangaard Brouer
@ 2009-02-20 15:03   ` Jesper Dangaard Brouer
  -1 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 15:03 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Author: Jesper Dangaard Brouer <hawk@comx.dk>
Date:   Fri Feb 20 15:20:57 2009 +0100

    Doc: Fix rp_filter description in net/ipv4/Kconfig.
    
    The reverse path filter (rp_filter) will NOT get enabled
    when enabling forwarding.  Read the code and tested in
    in practice.
    
    Most distributions does enable it in startup scripts.
    
    Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 691268f..10c944d 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -35,7 +35,7 @@ config IP_ADVANCED_ROUTER
 
 	  at boot time after the /proc file system has been mounted.
 
-	  If you turn on IP forwarding, you will also get the rp_filter, which
+	  If you turn on IP forwarding, you should consider the rp_filter, which
 	  automatically rejects incoming packets if the routing table entry
 	  for their source address doesn't match the network interface they're
 	  arriving on. This has security advantages because it prevents the
@@ -46,9 +46,11 @@ config IP_ADVANCED_ROUTER
 	  rp_filter on use:
 
 	  echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
-	  or
+	   and
 	  echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
 
+	  Note that some distributions enable it in startup scripts.
+
 	  If unsure, say N here.
 
 choice 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 1/2] Doc: Fix rp_filter description in net/ipv4/Kconfig.
@ 2009-02-20 15:03   ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 15:03 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Author: Jesper Dangaard Brouer <hawk@comx.dk>
Date:   Fri Feb 20 15:20:57 2009 +0100

    Doc: Fix rp_filter description in net/ipv4/Kconfig.
    
    The reverse path filter (rp_filter) will NOT get enabled
    when enabling forwarding.  Read the code and tested in
    in practice.
    
    Most distributions does enable it in startup scripts.
    
    Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 691268f..10c944d 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -35,7 +35,7 @@ config IP_ADVANCED_ROUTER
 
 	  at boot time after the /proc file system has been mounted.
 
-	  If you turn on IP forwarding, you will also get the rp_filter, which
+	  If you turn on IP forwarding, you should consider the rp_filter, which
 	  automatically rejects incoming packets if the routing table entry
 	  for their source address doesn't match the network interface they're
 	  arriving on. This has security advantages because it prevents the
@@ -46,9 +46,11 @@ config IP_ADVANCED_ROUTER
 	  rp_filter on use:
 
 	  echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
-	  or
+	   and
 	  echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
 
+	  Note that some distributions enable it in startup scripts.
+
 	  If unsure, say N here.
 
 choice 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 2/2] Doc: Clean whitespaces in net/ipv4/Kconfig.
  2009-02-20 14:59 ` Jesper Dangaard Brouer
@ 2009-02-20 15:04   ` Jesper Dangaard Brouer
  -1 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 15:04 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Author: Jesper Dangaard Brouer <hawk@comx.dk>
Date:   Fri Feb 20 15:35:40 2009 +0100

    Doc: Clean whitespaces in net/ipv4/Kconfig.
    
    While going through net/ipv4/Kconfig cleanup whitespaces.
    
    Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 10c944d..c7a8148 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -53,7 +53,7 @@ config IP_ADVANCED_ROUTER
 
 	  If unsure, say N here.
 
-choice 
+choice
 	prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)"
 	depends on IP_ADVANCED_ROUTER
 	default ASK_IP_FIB_HASH
@@ -61,27 +61,29 @@ choice
 config ASK_IP_FIB_HASH
 	bool "FIB_HASH"
 	---help---
-	Current FIB is very proven and good enough for most users.
+	  Current FIB is very proven and good enough for most users.
 
 config IP_FIB_TRIE
 	bool "FIB_TRIE"
 	---help---
-	Use new experimental LC-trie as FIB lookup algorithm. 
-        This improves lookup performance if you have a large
-	number of routes.
-
-	LC-trie is a longest matching prefix lookup algorithm which
-	performs better than FIB_HASH for large routing tables.
-	But, it consumes more memory and is more complex.
-	
-	LC-trie is described in:
-	
- 	IP-address lookup using LC-tries. Stefan Nilsson and Gunnar Karlsson
- 	IEEE Journal on Selected Areas in Communications, 17(6):1083-1092, June 1999
-	An experimental study of compression methods for dynamic tries
- 	Stefan Nilsson and Matti Tikkanen. Algorithmica, 33(1):19-33, 2002.
- 	http://www.nada.kth.se/~snilsson/public/papers/dyntrie2/
-       
+	  Use new experimental LC-trie as FIB lookup algorithm.
+	  This improves lookup performance if you have a large
+	  number of routes.
+
+	  LC-trie is a longest matching prefix lookup algorithm which
+	  performs better than FIB_HASH for large routing tables.
+	  But, it consumes more memory and is more complex.
+
+	  LC-trie is described in:
+
+	  IP-address lookup using LC-tries. Stefan Nilsson and Gunnar Karlsson
+	  IEEE Journal on Selected Areas in Communications, 17(6):1083-1092,
+	  June 1999
+
+	  An experimental study of compression methods for dynamic tries
+	  Stefan Nilsson and Matti Tikkanen. Algorithmica, 33(1):19-33, 2002.
+	  http://www.nada.kth.se/~snilsson/public/papers/dyntrie2/
+
 endchoice
 
 config IP_FIB_HASH
@@ -193,7 +195,7 @@ config IP_PNP_RARP
 	  <file:Documentation/filesystems/nfsroot.txt> for details.
 
 # not yet ready..
-#   bool '    IP: ARP support' CONFIG_IP_PNP_ARP		
+#   bool '    IP: ARP support' CONFIG_IP_PNP_ARP
 config NET_IPIP
 	tristate "IP: tunneling"
 	select INET_TUNNEL
@@ -363,7 +365,7 @@ config INET_IPCOMP
 	---help---
 	  Support for IP Payload Compression Protocol (IPComp) (RFC3173),
 	  typically needed for IPsec.
-	  
+
 	  If unsure, say Y.
 
 config INET_XFRM_TUNNEL
@@ -417,7 +419,7 @@ config INET_DIAG
 	  Support for INET (TCP, DCCP, etc) socket monitoring interface used by
 	  native Linux tools such as ss. ss is included in iproute2, currently
 	  downloadable at <http://linux-net.osdl.org/index.php/Iproute2>.
-	  
+
 	  If unsure, say Y.
 
 config INET_TCP_DIAG


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 2/2] Doc: Clean whitespaces in net/ipv4/Kconfig.
@ 2009-02-20 15:04   ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-20 15:04 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Kernel Janitors

Author: Jesper Dangaard Brouer <hawk@comx.dk>
Date:   Fri Feb 20 15:35:40 2009 +0100

    Doc: Clean whitespaces in net/ipv4/Kconfig.
    
    While going through net/ipv4/Kconfig cleanup whitespaces.
    
    Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 10c944d..c7a8148 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -53,7 +53,7 @@ config IP_ADVANCED_ROUTER
 
 	  If unsure, say N here.
 
-choice 
+choice
 	prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)"
 	depends on IP_ADVANCED_ROUTER
 	default ASK_IP_FIB_HASH
@@ -61,27 +61,29 @@ choice
 config ASK_IP_FIB_HASH
 	bool "FIB_HASH"
 	---help---
-	Current FIB is very proven and good enough for most users.
+	  Current FIB is very proven and good enough for most users.
 
 config IP_FIB_TRIE
 	bool "FIB_TRIE"
 	---help---
-	Use new experimental LC-trie as FIB lookup algorithm. 
-        This improves lookup performance if you have a large
-	number of routes.
-
-	LC-trie is a longest matching prefix lookup algorithm which
-	performs better than FIB_HASH for large routing tables.
-	But, it consumes more memory and is more complex.
-	
-	LC-trie is described in:
-	
- 	IP-address lookup using LC-tries. Stefan Nilsson and Gunnar Karlsson
- 	IEEE Journal on Selected Areas in Communications, 17(6):1083-1092, June 1999
-	An experimental study of compression methods for dynamic tries
- 	Stefan Nilsson and Matti Tikkanen. Algorithmica, 33(1):19-33, 2002.
- 	http://www.nada.kth.se/~snilsson/public/papers/dyntrie2/
-       
+	  Use new experimental LC-trie as FIB lookup algorithm.
+	  This improves lookup performance if you have a large
+	  number of routes.
+
+	  LC-trie is a longest matching prefix lookup algorithm which
+	  performs better than FIB_HASH for large routing tables.
+	  But, it consumes more memory and is more complex.
+
+	  LC-trie is described in:
+
+	  IP-address lookup using LC-tries. Stefan Nilsson and Gunnar Karlsson
+	  IEEE Journal on Selected Areas in Communications, 17(6):1083-1092,
+	  June 1999
+
+	  An experimental study of compression methods for dynamic tries
+	  Stefan Nilsson and Matti Tikkanen. Algorithmica, 33(1):19-33, 2002.
+	  http://www.nada.kth.se/~snilsson/public/papers/dyntrie2/
+
 endchoice
 
 config IP_FIB_HASH
@@ -193,7 +195,7 @@ config IP_PNP_RARP
 	  <file:Documentation/filesystems/nfsroot.txt> for details.
 
 # not yet ready..
-#   bool '    IP: ARP support' CONFIG_IP_PNP_ARP		
+#   bool '    IP: ARP support' CONFIG_IP_PNP_ARP
 config NET_IPIP
 	tristate "IP: tunneling"
 	select INET_TUNNEL
@@ -363,7 +365,7 @@ config INET_IPCOMP
 	---help---
 	  Support for IP Payload Compression Protocol (IPComp) (RFC3173),
 	  typically needed for IPsec.
-	  
+
 	  If unsure, say Y.
 
 config INET_XFRM_TUNNEL
@@ -417,7 +419,7 @@ config INET_DIAG
 	  Support for INET (TCP, DCCP, etc) socket monitoring interface used by
 	  native Linux tools such as ss. ss is included in iproute2, currently
 	  downloadable at <http://linux-net.osdl.org/index.php/Iproute2>.
-	  
+
 	  If unsure, say Y.
 
 config INET_TCP_DIAG


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 1/2] Doc: Fix rp_filter description in net/ipv4/Kconfig.
  2009-02-20 15:03   ` Jesper Dangaard Brouer
@ 2009-02-22  8:06     ` David Miller
  -1 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-22  8:06 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Fri, 20 Feb 2009 16:03:13 +0100

> Author: Jesper Dangaard Brouer <hawk@comx.dk>
> Date:   Fri Feb 20 15:20:57 2009 +0100
> 
>     Doc: Fix rp_filter description in net/ipv4/Kconfig.
>     
>     The reverse path filter (rp_filter) will NOT get enabled
>     when enabling forwarding.  Read the code and tested in
>     in practice.
>     
>     Most distributions does enable it in startup scripts.
>     
>     Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied, thanks Jesper.

Could you write a follow-on patch that accounts for the change Stephen
just made in net-next-2.6 which allows strong vs. weak rp filtering?

Thanks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 1/2] Doc: Fix rp_filter description in net/ipv4/Kconfig.
@ 2009-02-22  8:06     ` David Miller
  0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-22  8:06 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Fri, 20 Feb 2009 16:03:13 +0100

> Author: Jesper Dangaard Brouer <hawk@comx.dk>
> Date:   Fri Feb 20 15:20:57 2009 +0100
> 
>     Doc: Fix rp_filter description in net/ipv4/Kconfig.
>     
>     The reverse path filter (rp_filter) will NOT get enabled
>     when enabling forwarding.  Read the code and tested in
>     in practice.
>     
>     Most distributions does enable it in startup scripts.
>     
>     Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied, thanks Jesper.

Could you write a follow-on patch that accounts for the change Stephen
just made in net-next-2.6 which allows strong vs. weak rp filtering?

Thanks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 2/2] Doc: Clean whitespaces in net/ipv4/Kconfig.
  2009-02-20 15:04   ` Jesper Dangaard Brouer
@ 2009-02-22  8:07     ` David Miller
  -1 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-22  8:07 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Fri, 20 Feb 2009 16:04:26 +0100

>     Doc: Clean whitespaces in net/ipv4/Kconfig.
>     
>     While going through net/ipv4/Kconfig cleanup whitespaces.
>     
>     Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Also applied, thanks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 2/2] Doc: Clean whitespaces in net/ipv4/Kconfig.
@ 2009-02-22  8:07     ` David Miller
  0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-22  8:07 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Fri, 20 Feb 2009 16:04:26 +0100

>     Doc: Clean whitespaces in net/ipv4/Kconfig.
>     
>     While going through net/ipv4/Kconfig cleanup whitespaces.
>     
>     Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Also applied, thanks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp_filter.
  2009-02-22  8:06     ` David Miller
@ 2009-02-23 14:37       ` Jesper Dangaard Brouer
  -1 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:37 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


First fix a typo in Stephens patch ;-)

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 Documentation/networking/ip-sysctl.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 71041c2..e0b8c2c 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -711,8 +711,8 @@ rp_filter - INTEGER
 	    the packet check will fail.
 
         Current recommended practice in RFC3704 is to enable strict mode
-	to prevent IP spoofin from DDos attacks. If using asymmetric routing
-        or other complicated routing,t hen loose mode is recommended.
+	to prevent IP spoofing from DDos attacks. If using asymmetric routing
+        or other complicated routing, then loose mode is recommended.
 
 	conf/all/rp_filter must also be set to non-zero to do source validation
 	on the interface


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp_filter.
@ 2009-02-23 14:37       ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:37 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


First fix a typo in Stephens patch ;-)

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 Documentation/networking/ip-sysctl.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 71041c2..e0b8c2c 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -711,8 +711,8 @@ rp_filter - INTEGER
 	    the packet check will fail.
 
         Current recommended practice in RFC3704 is to enable strict mode
-	to prevent IP spoofin from DDos attacks. If using asymmetric routing
-        or other complicated routing,t hen loose mode is recommended.
+	to prevent IP spoofing from DDos attacks. If using asymmetric routing
+        or other complicated routing, then loose mode is recommended.
 
 	conf/all/rp_filter must also be set to non-zero to do source validation
 	on the interface


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt
  2009-02-22  8:06     ` David Miller
@ 2009-02-23 14:39       ` Jesper Dangaard Brouer
  -1 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:39 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


Fix up whitespaces while going though ip-sysctl.txt anyway.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 Documentation/networking/ip-sysctl.txt |  118 ++++++++++++++++----------------
 1 files changed, 59 insertions(+), 59 deletions(-)


diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index e0b8c2c..7185e4c 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -2,7 +2,7 @@
 
 ip_forward - BOOLEAN
 	0 - disabled (default)
-	not 0 - enabled 
+	not 0 - enabled
 
 	Forward Packets between interfaces.
 
@@ -36,49 +36,49 @@ rt_cache_rebuild_count - INTEGER
 IP Fragmentation:
 
 ipfrag_high_thresh - INTEGER
-	Maximum memory used to reassemble IP fragments. When 
+	Maximum memory used to reassemble IP fragments. When
 	ipfrag_high_thresh bytes of memory is allocated for this purpose,
 	the fragment handler will toss packets until ipfrag_low_thresh
 	is reached.
-	
+
 ipfrag_low_thresh - INTEGER
-	See ipfrag_high_thresh	
+	See ipfrag_high_thresh
 
 ipfrag_time - INTEGER
-	Time in seconds to keep an IP fragment in memory.	
+	Time in seconds to keep an IP fragment in memory.
 
 ipfrag_secret_interval - INTEGER
-	Regeneration interval (in seconds) of the hash secret (or lifetime 
+	Regeneration interval (in seconds) of the hash secret (or lifetime
 	for the hash secret) for IP fragments.
 	Default: 600
 
 ipfrag_max_dist - INTEGER
-	ipfrag_max_dist is a non-negative integer value which defines the 
-	maximum "disorder" which is allowed among fragments which share a 
-	common IP source address. Note that reordering of packets is 
-	not unusual, but if a large number of fragments arrive from a source 
-	IP address while a particular fragment queue remains incomplete, it 
-	probably indicates that one or more fragments belonging to that queue 
-	have been lost. When ipfrag_max_dist is positive, an additional check 
-	is done on fragments before they are added to a reassembly queue - if 
-	ipfrag_max_dist (or more) fragments have arrived from a particular IP 
-	address between additions to any IP fragment queue using that source 
-	address, it's presumed that one or more fragments in the queue are 
-	lost. The existing fragment queue will be dropped, and a new one 
+	ipfrag_max_dist is a non-negative integer value which defines the
+	maximum "disorder" which is allowed among fragments which share a
+	common IP source address. Note that reordering of packets is
+	not unusual, but if a large number of fragments arrive from a source
+	IP address while a particular fragment queue remains incomplete, it
+	probably indicates that one or more fragments belonging to that queue
+	have been lost. When ipfrag_max_dist is positive, an additional check
+	is done on fragments before they are added to a reassembly queue - if
+	ipfrag_max_dist (or more) fragments have arrived from a particular IP
+	address between additions to any IP fragment queue using that source
+	address, it's presumed that one or more fragments in the queue are
+	lost. The existing fragment queue will be dropped, and a new one
 	started. An ipfrag_max_dist value of zero disables this check.
 
 	Using a very small value, e.g. 1 or 2, for ipfrag_max_dist can
 	result in unnecessarily dropping fragment queues when normal
-	reordering of packets occurs, which could lead to poor application 
-	performance. Using a very large value, e.g. 50000, increases the 
-	likelihood of incorrectly reassembling IP fragments that originate 
+	reordering of packets occurs, which could lead to poor application
+	performance. Using a very large value, e.g. 50000, increases the
+	likelihood of incorrectly reassembling IP fragments that originate
 	from different IP datagrams, which could result in data corruption.
 	Default: 64
 
 INET peer storage:
 
 inet_peer_threshold - INTEGER
-	The approximate size of the storage.  Starting from this threshold	
+	The approximate size of the storage.  Starting from this threshold
 	entries will be thrown aggressively.  This threshold also determines
 	entries' time-to-live and time intervals between garbage collection
 	passes.  More entries, less time-to-live, less GC interval.
@@ -105,7 +105,7 @@ inet_peer_gc_maxtime - INTEGER
 	in effect under low (or absent) memory pressure on the pool.
 	Measured in seconds.
 
-TCP variables: 
+TCP variables:
 
 somaxconn - INTEGER
 	Limit of socket listen() backlog, known in userspace as SOMAXCONN.
@@ -310,7 +310,7 @@ tcp_orphan_retries - INTEGER
 
 tcp_reordering - INTEGER
 	Maximal reordering of packets in a TCP stream.
-	Default: 3	
+	Default: 3
 
 tcp_retrans_collapse - BOOLEAN
 	Bug-to-bug compatibility with some broken printers.
@@ -521,7 +521,7 @@ IP Variables:
 
 ip_local_port_range - 2 INTEGERS
 	Defines the local port range that is used by TCP and UDP to
-	choose the local port. The first number is the first, the 
+	choose the local port. The first number is the first, the
 	second the last local port number. Default value depends on
 	amount of memory available on the system:
 	> 128Mb 32768-61000
@@ -594,12 +594,12 @@ icmp_errors_use_inbound_ifaddr - BOOLEAN
 
 	If zero, icmp error messages are sent with the primary address of
 	the exiting interface.
- 
+
 	If non-zero, the message will be sent with the primary address of
 	the interface that received the packet that caused the icmp error.
 	This is the behaviour network many administrators will expect from
 	a router. And it can make debugging complicated network layouts
-	much easier. 
+	much easier.
 
 	Note that if no primary address exists for the interface selected,
 	then the primary address of the first non-loopback interface that
@@ -611,7 +611,7 @@ igmp_max_memberships - INTEGER
 	Change the maximum number of multicast groups we can subscribe to.
 	Default: 20
 
-conf/interface/*  changes special settings per interface (where "interface" is 
+conf/interface/*  changes special settings per interface (where "interface" is
 		  the name of your network interface)
 conf/all/*	  is special, changes the settings for all interfaces
 
@@ -625,11 +625,11 @@ log_martians - BOOLEAN
 accept_redirects - BOOLEAN
 	Accept ICMP redirect messages.
 	accept_redirects for the interface will be enabled if:
-	- both conf/{all,interface}/accept_redirects are TRUE in the case forwarding
-	  for the interface is enabled
+	- both conf/{all,interface}/accept_redirects are TRUE in the case
+	  forwarding for the interface is enabled
 	or
-	- at least one of conf/{all,interface}/accept_redirects is TRUE in the case
-	  forwarding for the interface is disabled
+	- at least one of conf/{all,interface}/accept_redirects is TRUE in the
+	  case forwarding for the interface is disabled
 	accept_redirects for the interface will be disabled otherwise
 	default TRUE (host)
 		FALSE (router)
@@ -640,8 +640,8 @@ forwarding - BOOLEAN
 mc_forwarding - BOOLEAN
 	Do multicast routing. The kernel needs to be compiled with CONFIG_MROUTE
 	and a multicast routing daemon is required.
-	conf/all/mc_forwarding must also be set to TRUE to enable multicast routing
-	for the interface
+	conf/all/mc_forwarding must also be set to TRUE to enable multicast
+	routing	for the interface
 
 medium_id - INTEGER
 	Integer value used to differentiate the devices by the medium they
@@ -649,7 +649,7 @@ medium_id - INTEGER
 	the broadcast packets are received only on one of them.
 	The default value 0 means that the device is the only interface
 	to its medium, value of -1 means that medium is not known.
-	
+
 	Currently, it is used to change the proxy_arp behavior:
 	the proxy_arp feature is enabled for packets forwarded between
 	two devices attached to different media.
@@ -710,9 +710,9 @@ rp_filter - INTEGER
 	    and if the source address is not reachable via any interface
 	    the packet check will fail.
 
-        Current recommended practice in RFC3704 is to enable strict mode
+	Current recommended practice in RFC3704 is to enable strict mode
 	to prevent IP spoofing from DDos attacks. If using asymmetric routing
-        or other complicated routing, then loose mode is recommended.
+	or other complicated routing, then loose mode is recommended.
 
 	conf/all/rp_filter must also be set to non-zero to do source validation
 	on the interface
@@ -835,7 +835,7 @@ apply to IPv6 [XXX?].
 
 bindv6only - BOOLEAN
 	Default value for IPV6_V6ONLY socket option,
-	which restricts use of the IPv6 socket to IPv6 communication 
+	which restricts use of the IPv6 socket to IPv6 communication
 	only.
 		TRUE: disable IPv4-mapped address feature
 		FALSE: enable IPv4-mapped address feature
@@ -845,19 +845,19 @@ bindv6only - BOOLEAN
 IPv6 Fragmentation:
 
 ip6frag_high_thresh - INTEGER
-	Maximum memory used to reassemble IPv6 fragments. When 
+	Maximum memory used to reassemble IPv6 fragments. When
 	ip6frag_high_thresh bytes of memory is allocated for this purpose,
 	the fragment handler will toss packets until ip6frag_low_thresh
 	is reached.
-	
+
 ip6frag_low_thresh - INTEGER
-	See ip6frag_high_thresh	
+	See ip6frag_high_thresh
 
 ip6frag_time - INTEGER
 	Time in seconds to keep an IPv6 fragment in memory.
 
 ip6frag_secret_interval - INTEGER
-	Regeneration interval (in seconds) of the hash secret (or lifetime 
+	Regeneration interval (in seconds) of the hash secret (or lifetime
 	for the hash secret) for IPv6 fragments.
 	Default: 600
 
@@ -866,17 +866,17 @@ conf/default/*:
 
 
 conf/all/*:
-	Change all the interface-specific settings.  
+	Change all the interface-specific settings.
 
 	[XXX:  Other special features than forwarding?]
 
 conf/all/forwarding - BOOLEAN
-	Enable global IPv6 forwarding between all interfaces.  
+	Enable global IPv6 forwarding between all interfaces.
 
-	IPv4 and IPv6 work differently here; e.g. netfilter must be used 
+	IPv4 and IPv6 work differently here; e.g. netfilter must be used
 	to control which interfaces may forward packets and which not.
 
-	This also sets all interfaces' Host/Router setting 
+	This also sets all interfaces' Host/Router setting
 	'forwarding' to the specified value.  See below for details.
 
 	This referred to as global forwarding.
@@ -887,12 +887,12 @@ proxy_ndp - BOOLEAN
 conf/interface/*:
 	Change special settings per interface.
 
-	The functional behaviour for certain settings is different 
+	The functional behaviour for certain settings is different
 	depending on whether local forwarding is enabled or not.
 
 accept_ra - BOOLEAN
 	Accept Router Advertisements; autoconfigure using them.
-	
+
 	Functional default: enabled if local forwarding is disabled.
 			    disabled if local forwarding is enabled.
 
@@ -938,7 +938,7 @@ accept_source_route - INTEGER
 	Default: 0
 
 autoconf - BOOLEAN
-	Autoconfigure addresses using Prefix Information in Router 
+	Autoconfigure addresses using Prefix Information in Router
 	Advertisements.
 
 	Functional default: enabled if accept_ra_pinfo is enabled.
@@ -947,11 +947,11 @@ autoconf - BOOLEAN
 dad_transmits - INTEGER
 	The amount of Duplicate Address Detection probes to send.
 	Default: 1
-	
+
 forwarding - BOOLEAN
-	Configure interface-specific Host/Router behaviour.  
+	Configure interface-specific Host/Router behaviour.
 
-	Note: It is recommended to have the same setting on all 
+	Note: It is recommended to have the same setting on all
 	interfaces; mixed router/host scenarios are rather uncommon.
 
 	FALSE:
@@ -960,13 +960,13 @@ forwarding - BOOLEAN
 
 	1. IsRouter flag is not set in Neighbour Advertisements.
 	2. Router Solicitations are being sent when necessary.
-	3. If accept_ra is TRUE (default), accept Router 
+	3. If accept_ra is TRUE (default), accept Router
 	   Advertisements (and do autoconfiguration).
 	4. If accept_redirects is TRUE (default), accept Redirects.
 
 	TRUE:
 
-	If local forwarding is enabled, Router behaviour is assumed. 
+	If local forwarding is enabled, Router behaviour is assumed.
 	This means exactly the reverse from the above:
 
 	1. IsRouter flag is set in Neighbour Advertisements.
@@ -1001,7 +1001,7 @@ router_solicitation_interval - INTEGER
 	Default: 4
 
 router_solicitations - INTEGER
-	Number of Router Solicitations to send until assuming no 
+	Number of Router Solicitations to send until assuming no
 	routers are present.
 	Default: 3
 
@@ -1025,11 +1025,11 @@ temp_prefered_lft - INTEGER
 
 max_desync_factor - INTEGER
 	Maximum value for DESYNC_FACTOR, which is a random value
-	that ensures that clients don't synchronize with each 
+	that ensures that clients don't synchronize with each
 	other and generate new addresses at exactly the same time.
 	value is in seconds.
 	Default: 600
-	
+
 regen_max_retry - INTEGER
 	Number of attempts before give up attempting to generate
 	valid temporary addresses.
@@ -1037,8 +1037,8 @@ regen_max_retry - INTEGER
 
 max_addresses - INTEGER
 	Number of maximum addresses per interface.  0 disables limitation.
-	It is recommended not set too large value (or 0) because it would 
-	be too easy way to crash kernel to allow to create too much of 
+	It is recommended not set too large value (or 0) because it would
+	be too easy way to crash kernel to allow to create too much of
 	autoconfigured addresses.
 	Default: 16
 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt
@ 2009-02-23 14:39       ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:39 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


Fix up whitespaces while going though ip-sysctl.txt anyway.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 Documentation/networking/ip-sysctl.txt |  118 ++++++++++++++++----------------
 1 files changed, 59 insertions(+), 59 deletions(-)


diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index e0b8c2c..7185e4c 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -2,7 +2,7 @@
 
 ip_forward - BOOLEAN
 	0 - disabled (default)
-	not 0 - enabled 
+	not 0 - enabled
 
 	Forward Packets between interfaces.
 
@@ -36,49 +36,49 @@ rt_cache_rebuild_count - INTEGER
 IP Fragmentation:
 
 ipfrag_high_thresh - INTEGER
-	Maximum memory used to reassemble IP fragments. When 
+	Maximum memory used to reassemble IP fragments. When
 	ipfrag_high_thresh bytes of memory is allocated for this purpose,
 	the fragment handler will toss packets until ipfrag_low_thresh
 	is reached.
-	
+
 ipfrag_low_thresh - INTEGER
-	See ipfrag_high_thresh	
+	See ipfrag_high_thresh
 
 ipfrag_time - INTEGER
-	Time in seconds to keep an IP fragment in memory.	
+	Time in seconds to keep an IP fragment in memory.
 
 ipfrag_secret_interval - INTEGER
-	Regeneration interval (in seconds) of the hash secret (or lifetime 
+	Regeneration interval (in seconds) of the hash secret (or lifetime
 	for the hash secret) for IP fragments.
 	Default: 600
 
 ipfrag_max_dist - INTEGER
-	ipfrag_max_dist is a non-negative integer value which defines the 
-	maximum "disorder" which is allowed among fragments which share a 
-	common IP source address. Note that reordering of packets is 
-	not unusual, but if a large number of fragments arrive from a source 
-	IP address while a particular fragment queue remains incomplete, it 
-	probably indicates that one or more fragments belonging to that queue 
-	have been lost. When ipfrag_max_dist is positive, an additional check 
-	is done on fragments before they are added to a reassembly queue - if 
-	ipfrag_max_dist (or more) fragments have arrived from a particular IP 
-	address between additions to any IP fragment queue using that source 
-	address, it's presumed that one or more fragments in the queue are 
-	lost. The existing fragment queue will be dropped, and a new one 
+	ipfrag_max_dist is a non-negative integer value which defines the
+	maximum "disorder" which is allowed among fragments which share a
+	common IP source address. Note that reordering of packets is
+	not unusual, but if a large number of fragments arrive from a source
+	IP address while a particular fragment queue remains incomplete, it
+	probably indicates that one or more fragments belonging to that queue
+	have been lost. When ipfrag_max_dist is positive, an additional check
+	is done on fragments before they are added to a reassembly queue - if
+	ipfrag_max_dist (or more) fragments have arrived from a particular IP
+	address between additions to any IP fragment queue using that source
+	address, it's presumed that one or more fragments in the queue are
+	lost. The existing fragment queue will be dropped, and a new one
 	started. An ipfrag_max_dist value of zero disables this check.
 
 	Using a very small value, e.g. 1 or 2, for ipfrag_max_dist can
 	result in unnecessarily dropping fragment queues when normal
-	reordering of packets occurs, which could lead to poor application 
-	performance. Using a very large value, e.g. 50000, increases the 
-	likelihood of incorrectly reassembling IP fragments that originate 
+	reordering of packets occurs, which could lead to poor application
+	performance. Using a very large value, e.g. 50000, increases the
+	likelihood of incorrectly reassembling IP fragments that originate
 	from different IP datagrams, which could result in data corruption.
 	Default: 64
 
 INET peer storage:
 
 inet_peer_threshold - INTEGER
-	The approximate size of the storage.  Starting from this threshold	
+	The approximate size of the storage.  Starting from this threshold
 	entries will be thrown aggressively.  This threshold also determines
 	entries' time-to-live and time intervals between garbage collection
 	passes.  More entries, less time-to-live, less GC interval.
@@ -105,7 +105,7 @@ inet_peer_gc_maxtime - INTEGER
 	in effect under low (or absent) memory pressure on the pool.
 	Measured in seconds.
 
-TCP variables: 
+TCP variables:
 
 somaxconn - INTEGER
 	Limit of socket listen() backlog, known in userspace as SOMAXCONN.
@@ -310,7 +310,7 @@ tcp_orphan_retries - INTEGER
 
 tcp_reordering - INTEGER
 	Maximal reordering of packets in a TCP stream.
-	Default: 3	
+	Default: 3
 
 tcp_retrans_collapse - BOOLEAN
 	Bug-to-bug compatibility with some broken printers.
@@ -521,7 +521,7 @@ IP Variables:
 
 ip_local_port_range - 2 INTEGERS
 	Defines the local port range that is used by TCP and UDP to
-	choose the local port. The first number is the first, the 
+	choose the local port. The first number is the first, the
 	second the last local port number. Default value depends on
 	amount of memory available on the system:
 	> 128Mb 32768-61000
@@ -594,12 +594,12 @@ icmp_errors_use_inbound_ifaddr - BOOLEAN
 
 	If zero, icmp error messages are sent with the primary address of
 	the exiting interface.
- 
+
 	If non-zero, the message will be sent with the primary address of
 	the interface that received the packet that caused the icmp error.
 	This is the behaviour network many administrators will expect from
 	a router. And it can make debugging complicated network layouts
-	much easier. 
+	much easier.
 
 	Note that if no primary address exists for the interface selected,
 	then the primary address of the first non-loopback interface that
@@ -611,7 +611,7 @@ igmp_max_memberships - INTEGER
 	Change the maximum number of multicast groups we can subscribe to.
 	Default: 20
 
-conf/interface/*  changes special settings per interface (where "interface" is 
+conf/interface/*  changes special settings per interface (where "interface" is
 		  the name of your network interface)
 conf/all/*	  is special, changes the settings for all interfaces
 
@@ -625,11 +625,11 @@ log_martians - BOOLEAN
 accept_redirects - BOOLEAN
 	Accept ICMP redirect messages.
 	accept_redirects for the interface will be enabled if:
-	- both conf/{all,interface}/accept_redirects are TRUE in the case forwarding
-	  for the interface is enabled
+	- both conf/{all,interface}/accept_redirects are TRUE in the case
+	  forwarding for the interface is enabled
 	or
-	- at least one of conf/{all,interface}/accept_redirects is TRUE in the case
-	  forwarding for the interface is disabled
+	- at least one of conf/{all,interface}/accept_redirects is TRUE in the
+	  case forwarding for the interface is disabled
 	accept_redirects for the interface will be disabled otherwise
 	default TRUE (host)
 		FALSE (router)
@@ -640,8 +640,8 @@ forwarding - BOOLEAN
 mc_forwarding - BOOLEAN
 	Do multicast routing. The kernel needs to be compiled with CONFIG_MROUTE
 	and a multicast routing daemon is required.
-	conf/all/mc_forwarding must also be set to TRUE to enable multicast routing
-	for the interface
+	conf/all/mc_forwarding must also be set to TRUE to enable multicast
+	routing	for the interface
 
 medium_id - INTEGER
 	Integer value used to differentiate the devices by the medium they
@@ -649,7 +649,7 @@ medium_id - INTEGER
 	the broadcast packets are received only on one of them.
 	The default value 0 means that the device is the only interface
 	to its medium, value of -1 means that medium is not known.
-	
+
 	Currently, it is used to change the proxy_arp behavior:
 	the proxy_arp feature is enabled for packets forwarded between
 	two devices attached to different media.
@@ -710,9 +710,9 @@ rp_filter - INTEGER
 	    and if the source address is not reachable via any interface
 	    the packet check will fail.
 
-        Current recommended practice in RFC3704 is to enable strict mode
+	Current recommended practice in RFC3704 is to enable strict mode
 	to prevent IP spoofing from DDos attacks. If using asymmetric routing
-        or other complicated routing, then loose mode is recommended.
+	or other complicated routing, then loose mode is recommended.
 
 	conf/all/rp_filter must also be set to non-zero to do source validation
 	on the interface
@@ -835,7 +835,7 @@ apply to IPv6 [XXX?].
 
 bindv6only - BOOLEAN
 	Default value for IPV6_V6ONLY socket option,
-	which restricts use of the IPv6 socket to IPv6 communication 
+	which restricts use of the IPv6 socket to IPv6 communication
 	only.
 		TRUE: disable IPv4-mapped address feature
 		FALSE: enable IPv4-mapped address feature
@@ -845,19 +845,19 @@ bindv6only - BOOLEAN
 IPv6 Fragmentation:
 
 ip6frag_high_thresh - INTEGER
-	Maximum memory used to reassemble IPv6 fragments. When 
+	Maximum memory used to reassemble IPv6 fragments. When
 	ip6frag_high_thresh bytes of memory is allocated for this purpose,
 	the fragment handler will toss packets until ip6frag_low_thresh
 	is reached.
-	
+
 ip6frag_low_thresh - INTEGER
-	See ip6frag_high_thresh	
+	See ip6frag_high_thresh
 
 ip6frag_time - INTEGER
 	Time in seconds to keep an IPv6 fragment in memory.
 
 ip6frag_secret_interval - INTEGER
-	Regeneration interval (in seconds) of the hash secret (or lifetime 
+	Regeneration interval (in seconds) of the hash secret (or lifetime
 	for the hash secret) for IPv6 fragments.
 	Default: 600
 
@@ -866,17 +866,17 @@ conf/default/*:
 
 
 conf/all/*:
-	Change all the interface-specific settings.  
+	Change all the interface-specific settings.
 
 	[XXX:  Other special features than forwarding?]
 
 conf/all/forwarding - BOOLEAN
-	Enable global IPv6 forwarding between all interfaces.  
+	Enable global IPv6 forwarding between all interfaces.
 
-	IPv4 and IPv6 work differently here; e.g. netfilter must be used 
+	IPv4 and IPv6 work differently here; e.g. netfilter must be used
 	to control which interfaces may forward packets and which not.
 
-	This also sets all interfaces' Host/Router setting 
+	This also sets all interfaces' Host/Router setting
 	'forwarding' to the specified value.  See below for details.
 
 	This referred to as global forwarding.
@@ -887,12 +887,12 @@ proxy_ndp - BOOLEAN
 conf/interface/*:
 	Change special settings per interface.
 
-	The functional behaviour for certain settings is different 
+	The functional behaviour for certain settings is different
 	depending on whether local forwarding is enabled or not.
 
 accept_ra - BOOLEAN
 	Accept Router Advertisements; autoconfigure using them.
-	
+
 	Functional default: enabled if local forwarding is disabled.
 			    disabled if local forwarding is enabled.
 
@@ -938,7 +938,7 @@ accept_source_route - INTEGER
 	Default: 0
 
 autoconf - BOOLEAN
-	Autoconfigure addresses using Prefix Information in Router 
+	Autoconfigure addresses using Prefix Information in Router
 	Advertisements.
 
 	Functional default: enabled if accept_ra_pinfo is enabled.
@@ -947,11 +947,11 @@ autoconf - BOOLEAN
 dad_transmits - INTEGER
 	The amount of Duplicate Address Detection probes to send.
 	Default: 1
-	
+
 forwarding - BOOLEAN
-	Configure interface-specific Host/Router behaviour.  
+	Configure interface-specific Host/Router behaviour.
 
-	Note: It is recommended to have the same setting on all 
+	Note: It is recommended to have the same setting on all
 	interfaces; mixed router/host scenarios are rather uncommon.
 
 	FALSE:
@@ -960,13 +960,13 @@ forwarding - BOOLEAN
 
 	1. IsRouter flag is not set in Neighbour Advertisements.
 	2. Router Solicitations are being sent when necessary.
-	3. If accept_ra is TRUE (default), accept Router 
+	3. If accept_ra is TRUE (default), accept Router
 	   Advertisements (and do autoconfiguration).
 	4. If accept_redirects is TRUE (default), accept Redirects.
 
 	TRUE:
 
-	If local forwarding is enabled, Router behaviour is assumed. 
+	If local forwarding is enabled, Router behaviour is assumed.
 	This means exactly the reverse from the above:
 
 	1. IsRouter flag is set in Neighbour Advertisements.
@@ -1001,7 +1001,7 @@ router_solicitation_interval - INTEGER
 	Default: 4
 
 router_solicitations - INTEGER
-	Number of Router Solicitations to send until assuming no 
+	Number of Router Solicitations to send until assuming no
 	routers are present.
 	Default: 3
 
@@ -1025,11 +1025,11 @@ temp_prefered_lft - INTEGER
 
 max_desync_factor - INTEGER
 	Maximum value for DESYNC_FACTOR, which is a random value
-	that ensures that clients don't synchronize with each 
+	that ensures that clients don't synchronize with each
 	other and generate new addresses at exactly the same time.
 	value is in seconds.
 	Default: 600
-	
+
 regen_max_retry - INTEGER
 	Number of attempts before give up attempting to generate
 	valid temporary addresses.
@@ -1037,8 +1037,8 @@ regen_max_retry - INTEGER
 
 max_addresses - INTEGER
 	Number of maximum addresses per interface.  0 disables limitation.
-	It is recommended not set too large value (or 0) because it would 
-	be too easy way to crash kernel to allow to create too much of 
+	It is recommended not set too large value (or 0) because it would
+	be too easy way to crash kernel to allow to create too much of
 	autoconfigured addresses.
 	Default: 16
 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose rp_filter mode
  2009-02-22  8:06     ` David Miller
@ 2009-02-23 14:40       ` Jesper Dangaard Brouer
  -1 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:40 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


The IP_ADVANCED_ROUTER Kconfig describes the rp_filter
proc option.  Recent changes added a loose mode.
Instead of documenting this change too places, refer to
the document describing it:
 Documentation/networking/ip-sysctl.txt

I'm considering moving the rp_filter description away
from the Kconfig file into ip-sysctl.txt.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 net/ipv4/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index c7a8148..b2cf91e 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -50,6 +50,8 @@ config IP_ADVANCED_ROUTER
 	  echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
 
 	  Note that some distributions enable it in startup scripts.
+	  For details about rp_filter strict and loose mode read
+	  <file:Documentation/networking/ip-sysctl.txt>.
 
 	  If unsure, say N here.
 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose
@ 2009-02-23 14:40       ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 22+ messages in thread
From: Jesper Dangaard Brouer @ 2009-02-23 14:40 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, kernel-janitors


The IP_ADVANCED_ROUTER Kconfig describes the rp_filter
proc option.  Recent changes added a loose mode.
Instead of documenting this change too places, refer to
the document describing it:
 Documentation/networking/ip-sysctl.txt

I'm considering moving the rp_filter description away
from the Kconfig file into ip-sysctl.txt.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 net/ipv4/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index c7a8148..b2cf91e 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -50,6 +50,8 @@ config IP_ADVANCED_ROUTER
 	  echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
 
 	  Note that some distributions enable it in startup scripts.
+	  For details about rp_filter strict and loose mode read
+	  <file:Documentation/networking/ip-sysctl.txt>.
 
 	  If unsure, say N here.
 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp_filter.
  2009-02-23 14:37       ` Jesper Dangaard Brouer
@ 2009-02-24 11:48         ` David Miller
  -1 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:37:55 +0100

> 
> First fix a typo in Stephens patch ;-)
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp_filter.
@ 2009-02-24 11:48         ` David Miller
  0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:37:55 +0100

> 
> First fix a typo in Stephens patch ;-)
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt
  2009-02-23 14:39       ` Jesper Dangaard Brouer
@ 2009-02-24 11:48         ` David Miller
  -1 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:39:04 +0100

> 
> Fix up whitespaces while going though ip-sysctl.txt anyway.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt
@ 2009-02-24 11:48         ` David Miller
  0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:39:04 +0100

> 
> Fix up whitespaces while going though ip-sysctl.txt anyway.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose rp_filter mode
  2009-02-23 14:40       ` [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose Jesper Dangaard Brouer
@ 2009-02-24 11:48         ` David Miller
  -1 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:40:43 +0100

> 
> The IP_ADVANCED_ROUTER Kconfig describes the rp_filter
> proc option.  Recent changes added a loose mode.
> Instead of documenting this change too places, refer to
> the document describing it:
>  Documentation/networking/ip-sysctl.txt
> 
> I'm considering moving the rp_filter description away
> from the Kconfig file into ip-sysctl.txt.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Also applied, thanks a lot Jesper.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose
@ 2009-02-24 11:48         ` David Miller
  0 siblings, 0 replies; 22+ messages in thread
From: David Miller @ 2009-02-24 11:48 UTC (permalink / raw)
  To: jdb; +Cc: netdev, kernel-janitors

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Mon, 23 Feb 2009 15:40:43 +0100

> 
> The IP_ADVANCED_ROUTER Kconfig describes the rp_filter
> proc option.  Recent changes added a loose mode.
> Instead of documenting this change too places, refer to
> the document describing it:
>  Documentation/networking/ip-sysctl.txt
> 
> I'm considering moving the rp_filter description away
> from the Kconfig file into ip-sysctl.txt.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Also applied, thanks a lot Jesper.

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2009-02-24 11:48 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-20 14:59 [PATCH 0/2] Janitor fixes for net/ipv4/Kconfig Jesper Dangaard Brouer
2009-02-20 14:59 ` Jesper Dangaard Brouer
2009-02-20 15:03 ` [PATCH 1/2] Doc: Fix rp_filter description in net/ipv4/Kconfig Jesper Dangaard Brouer
2009-02-20 15:03   ` Jesper Dangaard Brouer
2009-02-22  8:06   ` David Miller
2009-02-22  8:06     ` David Miller
2009-02-23 14:37     ` [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp_filter Jesper Dangaard Brouer
2009-02-23 14:37       ` Jesper Dangaard Brouer
2009-02-24 11:48       ` David Miller
2009-02-24 11:48         ` David Miller
2009-02-23 14:39     ` [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt Jesper Dangaard Brouer
2009-02-23 14:39       ` Jesper Dangaard Brouer
2009-02-24 11:48       ` David Miller
2009-02-24 11:48         ` David Miller
2009-02-23 14:40     ` [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose rp_filter mode Jesper Dangaard Brouer
2009-02-23 14:40       ` [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose Jesper Dangaard Brouer
2009-02-24 11:48       ` [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose rp_filter mode David Miller
2009-02-24 11:48         ` [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict vs. loose David Miller
2009-02-20 15:04 ` [PATCH 2/2] Doc: Clean whitespaces in net/ipv4/Kconfig Jesper Dangaard Brouer
2009-02-20 15:04   ` Jesper Dangaard Brouer
2009-02-22  8:07   ` David Miller
2009-02-22  8:07     ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.