[refpolicy] kernel_devices.patch

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch


labels for

/dev/3dfx
/dev/autofs
/dev/gfx
/dev/graphics
...


Java wants to attempt to append to the rand device.  Dontaudit for now

interface to manage device_t directories

interfaces to handle new null devices
usb devices

kvm

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmu82AACgkQrlYvE4MpobNYFACeN9Eh2IQy62hkLo7do8QMUiCX
/kcAniuwaoIL3/J0CfBHa9FlHi3U2x+l
=nfTV
-----END PGP SIGNATURE-----

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Wed, 2009-03-04 at 16:32 -0500, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch
> 
> 
> labels for
> 
> /dev/3dfx
> /dev/autofs
> /dev/gfx
> /dev/graphics
> ...
> 
> 
> Java wants to attempt to append to the rand device.  Dontaudit for now
> 
> interface to manage device_t directories
> 
> interfaces to handle new null devices
> usb devices
> 
> kvm

Merged with a bunch of reorganization.

Is this right?

+/dev/bometric/sensor.*	-c gen_context(system_u:object_r:event_device_t,s0)

should it be /dev/biometric instead of /dev/bometric?

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christopher J. PeBenito wrote:
> On Wed, 2009-03-04 at 16:32 -0500, Daniel J Walsh wrote:
>> http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch
>>
>>
>> labels for
>>
>> /dev/3dfx
>> /dev/autofs
>> /dev/gfx
>> /dev/graphics
>> ...
>>
>>
>> Java wants to attempt to append to the rand device.  Dontaudit for now
>>
>> interface to manage device_t directories
>>
>> interfaces to handle new null devices
>> usb devices
>>
>> kvm
> 
> Merged with a bunch of reorganization.
> 
> Is this right?
> 
> +/dev/bometric/sensor.*	-c gen_context(system_u:object_r:event_device_t,s0)
> 
> should it be /dev/biometric instead of /dev/bometric?
> 
Yes that is a bug.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmwC3oACgkQrlYvE4MpobMBegCfVnXHv1NkzDitODwITaCWnspV
yF4AoIlwB7F2WdDP2f4KUEkcCnolJFom
=uvPy
-----END PGP SIGNATURE-----

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch

Lots of new devices.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx27q0ACgkQrlYvE4MpobP0mACfWFFnrlVhkBGTIjljxBZpKTnb
GaAAnivq3u0tObRS7L/4Q1ArHewon2Le
=uOPL
-----END PGP SIGNATURE-----

[refpolicy] kernel_devices.patch

[Stephen Smalley]

On Mon, 2010-06-07 at 14:00 -0400, Christopher J. PeBenito wrote:
> On Mon, 2010-06-07 at 11:52 -0400, Daniel J Walsh wrote:
> > On 06/07/2010 09:39 AM, Christopher J. PeBenito wrote:
> > > On Mon, 2010-06-07 at 09:23 -0400, Daniel J Walsh wrote:
> > >> On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
> > >>> On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
> > >>>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
> > >>>>
> > >>>> Added default label for /sys so libvirt could relabel to it.
> > >>>
> > >>> I don't understand this.  There should be no files labeled sysfs_t,
> > >>> except for the entries created by the kernel on the fs itself, which get
> > >>> the right label already.
> > >>>
> > >> libvirt currently does the equivalent of
> > >>
> > >> chcon svirt_t:MCS1 DEVICE
> > >> Run QEMU
> > >> restorecon DEVICE
> > >>
> > >> If /sys is<<none>>  then it does not have a label to change the context
> > >> back to.  And leaves the context with a label svirt_t:MCS1.  If it later
> > >> picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.
> > >
> > > I still don't understand.  There are no device nodes in sysfs.
> > >
> > sysfs supports labeling now.  Certain objects need to have a 
> > svirt_image_t:MCS label associated with them under /sys (Usb devices?) 
> > When libvirt needs to changes these labels back to the default it asks 
> > matchpathcon and it returns sysfs_t.
> 
> Why doesn't it save the previous label and then restore it? That is much
> more sane, in case the previous label was not sysfs_t.  I don't know if
> thats likely to happen, but it seems safer too.

I suggested that as well, and they said the problem is tracking the
state across libvirtd restarts, although they hope to migrate to that
approach long term.

-- 
Stephen Smalley
National Security Agency

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Mon, 2010-06-07 at 11:52 -0400, Daniel J Walsh wrote:
> On 06/07/2010 09:39 AM, Christopher J. PeBenito wrote:
> > On Mon, 2010-06-07 at 09:23 -0400, Daniel J Walsh wrote:
> >> On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
> >>> On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
> >>>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
> >>>>
> >>>> Added default label for /sys so libvirt could relabel to it.
> >>>
> >>> I don't understand this.  There should be no files labeled sysfs_t,
> >>> except for the entries created by the kernel on the fs itself, which get
> >>> the right label already.
> >>>
> >> libvirt currently does the equivalent of
> >>
> >> chcon svirt_t:MCS1 DEVICE
> >> Run QEMU
> >> restorecon DEVICE
> >>
> >> If /sys is<<none>>  then it does not have a label to change the context
> >> back to.  And leaves the context with a label svirt_t:MCS1.  If it later
> >> picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.
> >
> > I still don't understand.  There are no device nodes in sysfs.
> >
> sysfs supports labeling now.  Certain objects need to have a 
> svirt_image_t:MCS label associated with them under /sys (Usb devices?) 
> When libvirt needs to changes these labels back to the default it asks 
> matchpathcon and it returns sysfs_t.

Why doesn't it save the previous label and then restore it? That is much
more sane, in case the previous label was not sysfs_t.  I don't know if
thats likely to happen, but it seems safer too.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

[refpolicy] kernel_devices.patch

[Stephen Smalley]

On Mon, 2010-06-07 at 11:52 -0400, Daniel J Walsh wrote:
> On 06/07/2010 09:39 AM, Christopher J. PeBenito wrote:
> > On Mon, 2010-06-07 at 09:23 -0400, Daniel J Walsh wrote:
> >> On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
> >>> On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
> >>>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
> >>>>
> >>>> Added default label for /sys so libvirt could relabel to it.
> >>>
> >>> I don't understand this.  There should be no files labeled sysfs_t,
> >>> except for the entries created by the kernel on the fs itself, which get
> >>> the right label already.
> >>>
> >> libvirt currently does the equivalent of
> >>
> >> chcon svirt_t:MCS1 DEVICE
> >> Run QEMU
> >> restorecon DEVICE
> >>
> >> If /sys is<<none>>  then it does not have a label to change the context
> >> back to.  And leaves the context with a label svirt_t:MCS1.  If it later
> >> picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.
> >
> > I still don't understand.  There are no device nodes in sysfs.
> >
> sysfs supports labeling now.  Certain objects need to have a 
> svirt_image_t:MCS label associated with them under /sys (Usb devices?) 
> When libvirt needs to changes these labels back to the default it asks 
> matchpathcon and it returns sysfs_t.

This is to support access to PCI device resources via sysfs.
See Documentation/sysfs-pci.txt.

-- 
Stephen Smalley
National Security Agency

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

On 06/07/2010 09:39 AM, Christopher J. PeBenito wrote:
> On Mon, 2010-06-07 at 09:23 -0400, Daniel J Walsh wrote:
>> On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
>>> On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
>>>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
>>>>
>>>> Added default label for /sys so libvirt could relabel to it.
>>>
>>> I don't understand this.  There should be no files labeled sysfs_t,
>>> except for the entries created by the kernel on the fs itself, which get
>>> the right label already.
>>>
>> libvirt currently does the equivalent of
>>
>> chcon svirt_t:MCS1 DEVICE
>> Run QEMU
>> restorecon DEVICE
>>
>> If /sys is<<none>>  then it does not have a label to change the context
>> back to.  And leaves the context with a label svirt_t:MCS1.  If it later
>> picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.
>
> I still don't understand.  There are no device nodes in sysfs.
>
sysfs supports labeling now.  Certain objects need to have a 
svirt_image_t:MCS label associated with them under /sys (Usb devices?) 
When libvirt needs to changes these labels back to the default it asks 
matchpathcon and it returns sysfs_t.

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Mon, 2010-06-07 at 09:23 -0400, Daniel J Walsh wrote:
> On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
> > On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
> >> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
> >>
> >> Added default label for /sys so libvirt could relabel to it.
> >
> > I don't understand this.  There should be no files labeled sysfs_t,
> > except for the entries created by the kernel on the fs itself, which get
> > the right label already.
> >
> libvirt currently does the equivalent of
> 
> chcon svirt_t:MCS1 DEVICE
> Run QEMU
> restorecon DEVICE
> 
> If /sys is <<none>> then it does not have a label to change the context 
> back to.  And leaves the context with a label svirt_t:MCS1.  If it later 
> picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.

I still don't understand.  There are no device nodes in sysfs.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

On 06/07/2010 09:20 AM, Christopher J. PeBenito wrote:
> On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
>>
>> vhost_device_t added for libvirt/qemu
>>
>> /dev/usbmon device added
>>
>> Added default label for /sys so libvirt could relabel to it.
>
> I don't understand this.  There should be no files labeled sysfs_t,
> except for the entries created by the kernel on the fs itself, which get
> the right label already.
>
>> lots of new interfaces.
>
> Otherwise merged.
>
libvirt currently does the equivalent of

chcon svirt_t:MCS1 DEVICE
Run QEMU
restorecon DEVICE

If /sys is <<none>> then it does not have a label to change the context 
back to.  And leaves the context with a label svirt_t:MCS1.  If it later 
picks an svirt_t:MCS1 for a different image, this /sys device is vulnerable.

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Wed, 2010-06-02 at 16:19 -0400, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch
> 
> vhost_device_t added for libvirt/qemu
> 
> /dev/usbmon device added
> 
> Added default label for /sys so libvirt could relabel to it.

I don't understand this.  There should be no files labeled sysfs_t,
except for the entries created by the kernel on the fs itself, which get
the right label already.

> lots of new interfaces.

Otherwise merged.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

http://people.fedoraproject.org/~dwalsh/SELinux/F14/kernel_devices.patch

vhost_device_t added for libvirt/qemu

/dev/usbmon device added

Added default label for /sys so libvirt could relabel to it.

lots of new interfaces.

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

On 03/04/2010 03:30 PM, Christopher J. PeBenito wrote:
> On Tue, 2010-02-23 at 17:07 -0500, Daniel J Walsh wrote:
>    
>> http://people.fedoraproject.org/~dwalsh/SELinux/F13/kernel_devices.patch
>>
>> New devices
>> btrfs-control
>> dahdi
>> etherd
>> misc/dlm
>> pps
>> usbmon
>> uinput
>> uio
>>      
> Merged, except for usbmod, only because I wonder if it should be
> debugfs_t, since the same info is available
> under /sys/kernel/debug/usb/usbmon/* on a per-device basis.
>
>    
>> +dev_rw_generic_chr_files(devicekit_power_t)
>> +    dev_dontaudit_write_all_chr_files(abrt_helper_t)
>> +    dev_dontaudit_write_all_blk_files(abrt_helper_t)
>> +    dev_dontaudit_write_mtrr(iptables_t)
>> +dev_rw_all_inherited_chr_files(sandbox_domain)
>> +dev_rw_all_inherited_blk_files(sandbox_domain)
>> +dev_setattr_dlm_control(rgmanager_t)
>> +dev_setattr_dlm_control(gfs_controld_t
>> +dev_rw_dlm_control(dlm_controld_t)
>> +dev_write_kmsg(initrc_t)
>>
>>      

Should we label both usbmon_dev_t? usmonfs_t?

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Tue, 2010-02-23 at 17:07 -0500, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F13/kernel_devices.patch
> 
> New devices
> btrfs-control
> dahdi
> etherd
> misc/dlm
> pps
> usbmon
> uinput
> uio

Merged, except for usbmod, only because I wonder if it should be
debugfs_t, since the same info is available
under /sys/kernel/debug/usb/usbmon/* on a per-device basis.

> +dev_rw_generic_chr_files(devicekit_power_t)
> +    dev_dontaudit_write_all_chr_files(abrt_helper_t)
> +    dev_dontaudit_write_all_blk_files(abrt_helper_t)
> +    dev_dontaudit_write_mtrr(iptables_t)
> +dev_rw_all_inherited_chr_files(sandbox_domain)
> +dev_rw_all_inherited_blk_files(sandbox_domain)
> +dev_setattr_dlm_control(rgmanager_t)
> +dev_setattr_dlm_control(gfs_controld_t
> +dev_rw_dlm_control(dlm_controld_t)
> +dev_write_kmsg(initrc_t)
> 

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

http://people.fedoraproject.org/~dwalsh/SELinux/F13/kernel_devices.patch

New devices
btrfs-control
dahdi
etherd
misc/dlm
pps
usbmon
uinput
uio

+dev_rw_generic_chr_files(devicekit_power_t)
+    dev_dontaudit_write_all_chr_files(abrt_helper_t)
+    dev_dontaudit_write_all_blk_files(abrt_helper_t)
+    dev_dontaudit_write_mtrr(iptables_t)
+dev_rw_all_inherited_chr_files(sandbox_domain)
+dev_rw_all_inherited_blk_files(sandbox_domain)
+dev_setattr_dlm_control(rgmanager_t)
+dev_setattr_dlm_control(gfs_controld_t
+dev_rw_dlm_control(dlm_controld_t)
+dev_write_kmsg(initrc_t)

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Thu, 2009-11-12 at 15:58 -0500, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F12/kernel_devices.patch
> 
> New devices and interfaces to access them

Merged, with some rearrangement.

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

http://people.fedoraproject.org/~dwalsh/SELinux/F12/kernel_devices.patch

New devices and interfaces to access them

[refpolicy] kernel_devices.patch

[Christopher J. PeBenito]

On Thu, 2009-05-21 at 11:17 -0400, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch
> 
> Add /dev/card, /dev/controlD64, /dev/tpm
> 
> Add interface to delete the null device
> 
> Fix interface type requires in dev_rw_generic_usb_dev
> 
> Add tpp_device_t type

Merged.

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch

Add /dev/card, /dev/controlD64, /dev/tpm

Add interface to delete the null device

Fix interface type requires in dev_rw_generic_usb_dev

Add tpp_device_t type

[refpolicy] kernel_devices.patch

[Daniel J Walsh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

http://people.fedoraproject.org/~dwalsh/SELinux/F11/kernel_devices.patch

Add lots of device file context

Allow the relabeling ofr lnk_files from device_t to a device node

add interface for manageing device_t directories


Dontaudit device_t:blk_file as well as device_node:blk_file

Interfaces to handle cpu_dev, null_dev, generic usb_device, usb_pipes,
kvm_device, autofs_device, netcontrol, qemu_device

Add types for  null_dev, generic usb_device, usb_pipes, kvm_device,
autofs_device, netcontrol, qemu_device
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkksczoACgkQrlYvE4MpobNGuwCgwy4hCH956IHQKvfg1EDynttn
NoAAn22qekw7D5t5lhQQW69fWkmt9s7N
=hJkC
-----END PGP SIGNATURE-----