All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 1/7]: Fix sparc64 setjmp implementation.
Date: Fri, 06 Mar 2009 14:03:57 -0500	[thread overview]
Message-ID: <1236366237.7680.2.camel@mj> (raw)
In-Reply-To: <20090306185553.GA28703@thorin>

On Fri, 2009-03-06 at 19:55 +0100, Robert Millan wrote:
> On Thu, Mar 05, 2009 at 08:04:07AM -0500, Isaac Dupree wrote:
> > > We've been using "unsigned long" for storing virtual addresses in the
> > > Linux kernel for 10+ years and it works just fine.  :-)
> > 
> > and Linux kernel uses GCC compiler in precise ways
> > 
> > I believe that ptrdiff_t is the proper standardized type for an integer the 
> > size of a pointer.  except... it's always signed :-)
> > 
> > Can you just use pointer types and pointer arithmetic?
> > 
> > also, standards aside, a common way to get such a type, is "configure" script 
> > testing various possibilities like "unsigned long" and "unsigned long long" 
> > and seeing which one is the right size for the target architecture. (not sure 
> > if that works when cross-compiling though)
> 
> I think we're already using longs this way in quite a few places.  It's not
> such a big deal IMHO.

I was considering making grub_size_t long and grub_ssize_t unsigned
long.  I remember that it required many changes in string formats, so I
didn't feel it would be justified.  But we could try it again.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-03-06 19:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  2:15 [PATCH 1/7]: Fix sparc64 setjmp implementation David Miller
2009-03-04 10:59 ` Vesa Jääskeläinen
2009-03-04 11:05   ` David Miller
2009-03-04 11:34 ` Vesa Jääskeläinen
2009-03-04 11:36   ` David Miller
2009-03-04 15:58     ` Javier Martín
2009-03-04 21:02       ` David Miller
2009-03-05 13:04         ` Isaac Dupree
2009-03-05 13:24           ` David Miller
2009-03-06 18:55           ` Robert Millan
2009-03-06 19:03             ` Pavel Roskin [this message]
2009-03-07  0:39               ` David Miller
2009-03-07  5:56                 ` Pavel Roskin
2009-03-07 10:38                   ` Robert Millan
2009-03-07 14:29                     ` David Miller
2009-03-07  0:34             ` David Miller
2009-03-07 10:39               ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236366237.7680.2.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.