All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: grub-devel@gnu.org, chaac@nic.fi
Subject: Re: [PATCH 1/7]: Fix sparc64 setjmp implementation.
Date: Wed, 04 Mar 2009 03:36:05 -0800 (PST)	[thread overview]
Message-ID: <20090304.033605.238092958.davem@davemloft.net> (raw)
In-Reply-To: <49AE6756.10404@nic.fi>

From: Vesa Jääskeläinen <chaac@nic.fi>
Date: Wed, 04 Mar 2009 13:34:46 +0200

> David Miller wrote:
> > diff --git a/include/grub/sparc64/setjmp.h b/include/grub/sparc64/setjmp.h
> > index 12d8e01..183a820 100644
> > --- a/include/grub/sparc64/setjmp.h
> > +++ b/include/grub/sparc64/setjmp.h
> > @@ -19,8 +19,7 @@
> >  #ifndef GRUB_SETJMP_CPU_HEADER
> >  #define GRUB_SETJMP_CPU_HEADER	1
> >  
> > -/* FIXME (sparc64).  */
> > -typedef unsigned long grub_jmp_buf[20];
> > +typedef unsigned long grub_jmp_buf[3];
> 
> I assume unsigned long is 64bit in sparc?

Yes, for sparc64 long is always 64-bit, no exceptions.

> Would it be more practical to use grub_uint64_t?

This is a "sparc64" file, so I don't think so.

> Are there any other registers that needs to be preserved ?

Not for GRUB, no.



  reply	other threads:[~2009-03-04 11:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  2:15 [PATCH 1/7]: Fix sparc64 setjmp implementation David Miller
2009-03-04 10:59 ` Vesa Jääskeläinen
2009-03-04 11:05   ` David Miller
2009-03-04 11:34 ` Vesa Jääskeläinen
2009-03-04 11:36   ` David Miller [this message]
2009-03-04 15:58     ` Javier Martín
2009-03-04 21:02       ` David Miller
2009-03-05 13:04         ` Isaac Dupree
2009-03-05 13:24           ` David Miller
2009-03-06 18:55           ` Robert Millan
2009-03-06 19:03             ` Pavel Roskin
2009-03-07  0:39               ` David Miller
2009-03-07  5:56                 ` Pavel Roskin
2009-03-07 10:38                   ` Robert Millan
2009-03-07 14:29                     ` David Miller
2009-03-07  0:34             ` David Miller
2009-03-07 10:39               ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090304.033605.238092958.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.