All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] radio-rtrack2: fix double mutex_unlock
@ 2009-03-10  8:14 Alexey Klimov
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Klimov @ 2009-03-10  8:14 UTC (permalink / raw)
  To: linux-media; +Cc: Mauro Carvalho Chehab, Douglas Schilling Landgraf

Patch fixes double mutex unlocking.

Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

--
diff -r 615fb8f01610 linux/drivers/media/radio/radio-rtrack2.c
--- a/linux/drivers/media/radio/radio-rtrack2.c	Tue Mar 10 02:33:02 2009 -0300
+++ b/linux/drivers/media/radio/radio-rtrack2.c	Tue Mar 10 09:28:27 2009 +0300
@@ -60,7 +60,6 @@
 		return;
 	mutex_lock(&dev->lock);
 	outb(1, dev->io);
-	mutex_unlock(&dev->lock);
 	mutex_unlock(&dev->lock);
 	dev->muted = 1;
 }


-- 
Best regards, Klimov Alexey


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] radio-rtrack2: fix double mutex_unlock
@ 2009-03-10  8:27 Hans Verkuil
  0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2009-03-10  8:27 UTC (permalink / raw)
  To: Alexey Klimov
  Cc: linux-media, Mauro Carvalho Chehab, Douglas Schilling Landgraf


> Patch fixes double mutex unlocking.
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

Ouch.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

Thanks!

       Hans

>
> --
> diff -r 615fb8f01610 linux/drivers/media/radio/radio-rtrack2.c
> --- a/linux/drivers/media/radio/radio-rtrack2.c	Tue Mar 10 02:33:02 2009
> -0300
> +++ b/linux/drivers/media/radio/radio-rtrack2.c	Tue Mar 10 09:28:27 2009
> +0300
> @@ -60,7 +60,6 @@
>  		return;
>  	mutex_lock(&dev->lock);
>  	outb(1, dev->io);
> -	mutex_unlock(&dev->lock);
>  	mutex_unlock(&dev->lock);
>  	dev->muted = 1;
>  }
>
>
> --
> Best regards, Klimov Alexey
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-10  8:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-10  8:14 [patch] radio-rtrack2: fix double mutex_unlock Alexey Klimov
2009-03-10  8:27 Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.