* [PATCH] iwlwifi: notify on scan completion even when shutting down
@ 2009-04-23 8:45 Johannes Berg
2009-04-23 17:23 ` reinette chatre
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-04-23 8:45 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Reinette Chatre
Under certain circumstances iwlwifi can get stuck and will no
longer accept scan requests, because the core code (cfg80211)
thinks that it's still processing one. This fixes one of the
points where it can happen, but I've still seen it (although
only with my radio-off-when-idle patch).
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl-scan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-scan.c 2009-04-21 23:36:10.000000000 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-scan.c 2009-04-23 10:43:08.000000000 +0200
@@ -814,12 +814,12 @@ void iwl_bg_scan_completed(struct work_s
IWL_DEBUG_SCAN(priv, "SCAN complete scan\n");
- if (test_bit(STATUS_EXIT_PENDING, &priv->status))
- return;
-
priv->scan_request = NULL;
ieee80211_scan_completed(priv->hw, false);
+ if (test_bit(STATUS_EXIT_PENDING, &priv->status))
+ return;
+
/* Since setting the TXPOWER may have been deferred while
* performing the scan, fire one off */
mutex_lock(&priv->mutex);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: notify on scan completion even when shutting down
2009-04-23 8:45 [PATCH] iwlwifi: notify on scan completion even when shutting down Johannes Berg
@ 2009-04-23 17:23 ` reinette chatre
0 siblings, 0 replies; 2+ messages in thread
From: reinette chatre @ 2009-04-23 17:23 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
On Thu, 2009-04-23 at 01:45 -0700, Johannes Berg wrote:
> Under certain circumstances iwlwifi can get stuck and will no
> longer accept scan requests, because the core code (cfg80211)
> thinks that it's still processing one. This fixes one of the
> points where it can happen, but I've still seen it (although
> only with my radio-off-when-idle patch).
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-scan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-scan.c 2009-04-21 23:36:10.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-scan.c 2009-04-23 10:43:08.000000000 +0200
> @@ -814,12 +814,12 @@ void iwl_bg_scan_completed(struct work_s
>
> IWL_DEBUG_SCAN(priv, "SCAN complete scan\n");
>
> - if (test_bit(STATUS_EXIT_PENDING, &priv->status))
> - return;
> -
> priv->scan_request = NULL;
> ieee80211_scan_completed(priv->hw, false);
>
> + if (test_bit(STATUS_EXIT_PENDING, &priv->status))
> + return;
> +
> /* Since setting the TXPOWER may have been deferred while
> * performing the scan, fire one off */
> mutex_lock(&priv->mutex);
>
>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-23 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-23 8:45 [PATCH] iwlwifi: notify on scan completion even when shutting down Johannes Berg
2009-04-23 17:23 ` reinette chatre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.