From: Dave Hansen <dave@linux.vnet.ibm.com> To: Mel Gorman <mel@csn.ul.ie> Cc: Linux Memory Management List <linux-mm@kvack.org>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Christoph Lameter <cl@linux-foundation.org>, Nick Piggin <npiggin@suse.de>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Lin Ming <ming.m.lin@intel.com>, Zhang Yanmin <yanmin_zhang@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, Pekka Enberg <penberg@cs.helsinki.fi>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 02/22] Do not sanity check order in the fast path Date: Thu, 23 Apr 2009 10:36:50 -0700 [thread overview] Message-ID: <1240508211.10627.139.camel@nimitz> (raw) In-Reply-To: <20090423095821.GA25102@csn.ul.ie> On Thu, 2009-04-23 at 10:58 +0100, Mel Gorman wrote: > > How about this: I'll go and audit the use of order in page_alloc.c to > > make sure that having an order>MAX_ORDER-1 floating around is OK and > > won't break anything. > > Great. Right now, I think it's ok but I haven't audited for this > explicily and a second set of eyes never hurts. OK, after looking through this, I have a couple of ideas. One is that we do the MAX_ORDER check in __alloc_pages_internal(), but *after* the first call to get_page_from_freelist(). That's because I'm worried if we ever got into the reclaim code with a >MAX_ORDER 'order'. Such as: void wakeup_kswapd(struct zone *zone, int order) { ... if (pgdat->kswapd_max_order < order) pgdat->kswapd_max_order = order; if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) return; if (!waitqueue_active(&pgdat->kswapd_wait)) return; wake_up_interruptible(&pgdat->kswapd_wait); } unsigned long try_to_free_pages(struct zonelist *zonelist, int order, gfp_t gfp_mask, nodemask_t *nodemask) { struct scan_control sc = { ... .order = order, .mem_cgroup = NULL, .isolate_pages = isolate_pages_global, .nodemask = nodemask, }; return do_try_to_free_pages(zonelist, &sc); } This will keep us only checking 'order' once for each alloc_pages_internal() call. It is an extra branch, but it is out of the really, really hot path since we're about to start reclaim here anyway. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e2f2699..1e3a01e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1498,6 +1498,13 @@ restart: zonelist, high_zoneidx, ALLOC_WMARK_LOW|ALLOC_CPUSET); if (page) goto got_pg; + /* + * We're out of the rocket-hot area above, so do a quick sanity + * check. We do this here to avoid ever trying to do any reclaim + * of >=MAX_ORDER areas which can never succeed, of course. + */ + if (order >= MAX_ORDER) + goto nopage; /* * GFP_THISNODE (meaning __GFP_THISNODE, __GFP_NORETRY and -- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com> To: Mel Gorman <mel@csn.ul.ie> Cc: Linux Memory Management List <linux-mm@kvack.org>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Christoph Lameter <cl@linux-foundation.org>, Nick Piggin <npiggin@suse.de>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Lin Ming <ming.m.lin@intel.com>, Zhang Yanmin <yanmin_zhang@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, Pekka Enberg <penberg@cs.helsinki.fi>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 02/22] Do not sanity check order in the fast path Date: Thu, 23 Apr 2009 10:36:50 -0700 [thread overview] Message-ID: <1240508211.10627.139.camel@nimitz> (raw) In-Reply-To: <20090423095821.GA25102@csn.ul.ie> On Thu, 2009-04-23 at 10:58 +0100, Mel Gorman wrote: > > How about this: I'll go and audit the use of order in page_alloc.c to > > make sure that having an order>MAX_ORDER-1 floating around is OK and > > won't break anything. > > Great. Right now, I think it's ok but I haven't audited for this > explicily and a second set of eyes never hurts. OK, after looking through this, I have a couple of ideas. One is that we do the MAX_ORDER check in __alloc_pages_internal(), but *after* the first call to get_page_from_freelist(). That's because I'm worried if we ever got into the reclaim code with a >MAX_ORDER 'order'. Such as: void wakeup_kswapd(struct zone *zone, int order) { ... if (pgdat->kswapd_max_order < order) pgdat->kswapd_max_order = order; if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) return; if (!waitqueue_active(&pgdat->kswapd_wait)) return; wake_up_interruptible(&pgdat->kswapd_wait); } unsigned long try_to_free_pages(struct zonelist *zonelist, int order, gfp_t gfp_mask, nodemask_t *nodemask) { struct scan_control sc = { ... .order = order, .mem_cgroup = NULL, .isolate_pages = isolate_pages_global, .nodemask = nodemask, }; return do_try_to_free_pages(zonelist, &sc); } This will keep us only checking 'order' once for each alloc_pages_internal() call. It is an extra branch, but it is out of the really, really hot path since we're about to start reclaim here anyway. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e2f2699..1e3a01e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1498,6 +1498,13 @@ restart: zonelist, high_zoneidx, ALLOC_WMARK_LOW|ALLOC_CPUSET); if (page) goto got_pg; + /* + * We're out of the rocket-hot area above, so do a quick sanity + * check. We do this here to avoid ever trying to do any reclaim + * of >=MAX_ORDER areas which can never succeed, of course. + */ + if (order >= MAX_ORDER) + goto nopage; /* * GFP_THISNODE (meaning __GFP_THISNODE, __GFP_NORETRY and -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-23 17:37 UTC|newest] Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-22 13:53 [PATCH 00/22] Cleanup and optimise the page allocator V7 Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 01/22] Replace __alloc_pages_internal() with __alloc_pages_nodemask() Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 02/22] Do not sanity check order in the fast path Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 16:13 ` Dave Hansen 2009-04-22 16:13 ` Dave Hansen 2009-04-22 17:11 ` Mel Gorman 2009-04-22 17:11 ` Mel Gorman 2009-04-22 17:30 ` Dave Hansen 2009-04-22 17:30 ` Dave Hansen 2009-04-23 0:13 ` Mel Gorman 2009-04-23 0:13 ` Mel Gorman 2009-04-23 1:34 ` Dave Hansen 2009-04-23 1:34 ` Dave Hansen 2009-04-23 9:58 ` Mel Gorman 2009-04-23 9:58 ` Mel Gorman 2009-04-23 17:36 ` Dave Hansen [this message] 2009-04-23 17:36 ` Dave Hansen 2009-04-24 2:57 ` KOSAKI Motohiro 2009-04-24 2:57 ` KOSAKI Motohiro 2009-04-24 10:34 ` Mel Gorman 2009-04-24 10:34 ` Mel Gorman 2009-04-24 14:16 ` Dave Hansen 2009-04-24 14:16 ` Dave Hansen 2009-04-23 19:26 ` Dave Hansen 2009-04-23 19:26 ` Dave Hansen 2009-04-23 19:45 ` Dave Hansen 2009-04-23 19:45 ` Dave Hansen 2009-04-24 9:21 ` Mel Gorman 2009-04-24 9:21 ` Mel Gorman 2009-04-24 14:25 ` Dave Hansen 2009-04-24 14:25 ` Dave Hansen 2009-04-22 20:11 ` David Rientjes 2009-04-22 20:11 ` David Rientjes 2009-04-22 20:20 ` Christoph Lameter 2009-04-22 20:20 ` Christoph Lameter 2009-04-23 7:44 ` Pekka Enberg 2009-04-23 7:44 ` Pekka Enberg 2009-04-23 22:44 ` Andrew Morton 2009-04-23 22:44 ` Andrew Morton 2009-04-22 13:53 ` [PATCH 03/22] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 04/22] Check only once if the zonelist is suitable for the allocation Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 05/22] Break up the allocator entry point into fast and slow paths Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 06/22] Move check for disabled anti-fragmentation out of fastpath Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 07/22] Calculate the preferred zone for allocation only once Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-23 22:48 ` Andrew Morton 2009-04-23 22:48 ` Andrew Morton 2009-04-22 13:53 ` [PATCH 08/22] Calculate the migratetype " Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 09/22] Calculate the alloc_flags " Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-23 22:52 ` Andrew Morton 2009-04-23 22:52 ` Andrew Morton 2009-04-24 10:47 ` Mel Gorman 2009-04-24 10:47 ` Mel Gorman 2009-04-24 17:51 ` Andrew Morton 2009-04-24 17:51 ` Andrew Morton 2009-04-22 13:53 ` [PATCH 10/22] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 11/22] Inline __rmqueue_smallest() Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 12/22] Inline buffered_rmqueue() Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 13/22] Inline __rmqueue_fallback() Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 14/22] Do not call get_pageblock_migratetype() more than necessary Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 15/22] Do not disable interrupts in free_page_mlock() Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-23 22:59 ` Andrew Morton 2009-04-23 22:59 ` Andrew Morton 2009-04-24 0:07 ` KOSAKI Motohiro 2009-04-24 0:07 ` KOSAKI Motohiro 2009-04-24 0:33 ` KOSAKI Motohiro 2009-04-24 0:33 ` KOSAKI Motohiro 2009-04-24 11:33 ` Mel Gorman 2009-04-24 11:33 ` Mel Gorman 2009-04-24 11:52 ` Lee Schermerhorn 2009-04-24 11:52 ` Lee Schermerhorn 2009-04-24 11:18 ` Mel Gorman 2009-04-24 11:18 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 16/22] Do not setup zonelist cache when there is only one node Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 20:24 ` David Rientjes 2009-04-22 20:24 ` David Rientjes 2009-04-22 20:32 ` Lee Schermerhorn 2009-04-22 20:32 ` Lee Schermerhorn 2009-04-22 20:34 ` David Rientjes 2009-04-22 20:34 ` David Rientjes 2009-04-23 0:11 ` KOSAKI Motohiro 2009-04-23 0:11 ` KOSAKI Motohiro 2009-04-23 0:19 ` Mel Gorman 2009-04-23 0:19 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 17/22] Do not check for compound pages during the page allocator sanity checks Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 18/22] Use allocation flags as an index to the zone watermark Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 17:11 ` Dave Hansen 2009-04-22 17:11 ` Dave Hansen 2009-04-22 17:14 ` Mel Gorman 2009-04-22 17:14 ` Mel Gorman 2009-04-22 17:47 ` Dave Hansen 2009-04-22 17:47 ` Dave Hansen 2009-04-23 0:27 ` KOSAKI Motohiro 2009-04-23 0:27 ` KOSAKI Motohiro 2009-04-23 10:03 ` Mel Gorman 2009-04-23 10:03 ` Mel Gorman 2009-04-24 6:41 ` KOSAKI Motohiro 2009-04-24 6:41 ` KOSAKI Motohiro 2009-04-22 20:06 ` David Rientjes 2009-04-22 20:06 ` David Rientjes 2009-04-23 0:29 ` Mel Gorman 2009-04-23 0:29 ` Mel Gorman 2009-04-27 17:00 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] array Mel Gorman 2009-04-27 17:00 ` Mel Gorman 2009-04-27 20:48 ` David Rientjes 2009-04-27 20:48 ` David Rientjes 2009-04-27 20:54 ` Mel Gorman 2009-04-27 20:54 ` Mel Gorman 2009-04-27 20:51 ` Christoph Lameter 2009-04-27 20:51 ` Christoph Lameter 2009-04-27 21:04 ` David Rientjes 2009-04-27 21:04 ` David Rientjes 2009-04-30 13:35 ` Mel Gorman 2009-04-30 13:35 ` Mel Gorman 2009-04-30 13:48 ` Dave Hansen 2009-04-30 13:48 ` Dave Hansen 2009-05-12 14:13 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] array V2 Mel Gorman 2009-05-12 14:13 ` Mel Gorman 2009-05-12 15:05 ` [RFC] Replace the watermark-related union in struct zone with awatermark[] " Dave Hansen 2009-05-12 15:05 ` Dave Hansen 2009-05-13 8:31 ` [RFC] Replace the watermark-related union in struct zone with a watermark[] " KOSAKI Motohiro 2009-05-13 8:31 ` KOSAKI Motohiro 2009-04-22 13:53 ` [PATCH 19/22] Update NR_FREE_PAGES only as necessary Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-23 23:06 ` Andrew Morton 2009-04-23 23:06 ` Andrew Morton 2009-04-23 23:04 ` Christoph Lameter 2009-04-23 23:04 ` Christoph Lameter 2009-04-24 13:06 ` Mel Gorman 2009-04-24 13:06 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 20/22] Get the pageblock migratetype without disabling interrupts Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 21/22] Use a pre-calculated value instead of num_online_nodes() in fast paths Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 23:04 ` David Rientjes 2009-04-22 23:04 ` David Rientjes 2009-04-23 0:44 ` Mel Gorman 2009-04-23 0:44 ` Mel Gorman 2009-04-23 19:29 ` David Rientjes 2009-04-23 19:29 ` David Rientjes 2009-04-24 13:31 ` [PATCH] Do not override definition of node_set_online() with macro Mel Gorman 2009-04-24 13:31 ` Mel Gorman 2009-04-22 13:53 ` [PATCH 22/22] slab: Use nr_online_nodes to check for a NUMA platform Mel Gorman 2009-04-22 13:53 ` Mel Gorman 2009-04-22 14:37 ` Pekka Enberg 2009-04-22 14:37 ` Pekka Enberg 2009-04-27 7:58 ` [PATCH 00/22] Cleanup and optimise the page allocator V7 Zhang, Yanmin 2009-04-27 7:58 ` Zhang, Yanmin 2009-04-27 14:38 ` Mel Gorman 2009-04-27 14:38 ` Mel Gorman 2009-04-28 1:59 ` Zhang, Yanmin 2009-04-28 1:59 ` Zhang, Yanmin 2009-04-28 10:27 ` Mel Gorman 2009-04-28 10:27 ` Mel Gorman 2009-04-28 10:31 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() Mel Gorman 2009-04-28 10:31 ` Mel Gorman 2009-04-28 16:37 ` Christoph Lameter 2009-04-28 16:37 ` Christoph Lameter 2009-04-28 16:51 ` Mel Gorman 2009-04-28 16:51 ` Mel Gorman 2009-04-28 17:15 ` Hugh Dickins 2009-04-28 17:15 ` Hugh Dickins 2009-04-28 18:07 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() V2 Mel Gorman 2009-04-28 18:07 ` Mel Gorman 2009-04-28 18:25 ` Hugh Dickins 2009-04-28 18:25 ` Hugh Dickins 2009-04-28 18:36 ` [PATCH] Properly account for freed pages in free_pages_bulk() and when allocating high-order pages in buffered_rmqueue() Mel Gorman 2009-04-28 18:36 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1240508211.10627.139.camel@nimitz \ --to=dave@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux-foundation.org \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mel@csn.ul.ie \ --cc=ming.m.lin@intel.com \ --cc=npiggin@suse.de \ --cc=penberg@cs.helsinki.fi \ --cc=peterz@infradead.org \ --cc=yanmin_zhang@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.