* [PATCH] Documentation:lockdep-design: fix note of state bits
@ 2009-04-24 15:08 tom.leiming
0 siblings, 0 replies; 2+ messages in thread
From: tom.leiming @ 2009-04-24 15:08 UTC (permalink / raw)
To: ingo, akpm; +Cc: linux-kernel, Ming Lei
From: Ming Lei <tom.leiming@gmail.com>
>From source code of get_usage_char(), the previous note is not correct,
so fix it.
static char get_usage_char(struct lock_class *class, enum lock_usage_bit bit)
{
char c = '.';
if (class->usage_mask & lock_flag(bit + 2))/*LOCK_ENABLED_##STATE*/
c = '+';
if (class->usage_mask & lock_flag(bit)) {/*LOCK_USED_IN_##STATE*/
c = '-';
if (class->usage_mask & lock_flag(bit + 2))
c = '?';
}
return c;
}
note:
1),The 'bit' parameter always is passed as LOCK_USED_IN_##STATE
or LOCK_USED_IN_##STATE_READ , from get_usage_chars().
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
Documentation/lockdep-design.txt | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/lockdep-design.txt b/Documentation/lockdep-design.txt
index 938ea22..e20d913 100644
--- a/Documentation/lockdep-design.txt
+++ b/Documentation/lockdep-design.txt
@@ -54,9 +54,9 @@ locking error messages, inside curlies. A contrived example:
The bit position indicates STATE, STATE-read, for each of the states listed
above, and the character displayed in each indicates:
- '.' acquired while irqs disabled
- '+' acquired in irq context
- '-' acquired with irqs enabled
+ '.' acquired while irqs disabled and not in irq context
+ '-' acquired in irq context
+ '+' acquired with irqs enabled
'?' acquired in irq context with irqs enabled.
Unused mutexes cannot be part of the cause of an error.
--
1.6.0.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Documentation:lockdep-design: fix note of state bits
@ 2009-04-24 15:10 tom.leiming
0 siblings, 0 replies; 2+ messages in thread
From: tom.leiming @ 2009-04-24 15:10 UTC (permalink / raw)
To: mingo, akpm; +Cc: linux-kernel, Ming Lei
From: Ming Lei <tom.leiming@gmail.com>
>From source code of get_usage_char(), the previous note is not correct,
so fix it.
static char get_usage_char(struct lock_class *class, enum lock_usage_bit bit)
{
char c = '.';
if (class->usage_mask & lock_flag(bit + 2))/*LOCK_ENABLED_##STATE*/
c = '+';
if (class->usage_mask & lock_flag(bit)) {/*LOCK_USED_IN_##STATE*/
c = '-';
if (class->usage_mask & lock_flag(bit + 2))
c = '?';
}
return c;
}
note:
1),The 'bit' parameter always is passed as LOCK_USED_IN_##STATE
or LOCK_USED_IN_##STATE_READ , from get_usage_chars().
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
Documentation/lockdep-design.txt | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/lockdep-design.txt b/Documentation/lockdep-design.txt
index 938ea22..e20d913 100644
--- a/Documentation/lockdep-design.txt
+++ b/Documentation/lockdep-design.txt
@@ -54,9 +54,9 @@ locking error messages, inside curlies. A contrived example:
The bit position indicates STATE, STATE-read, for each of the states listed
above, and the character displayed in each indicates:
- '.' acquired while irqs disabled
- '+' acquired in irq context
- '-' acquired with irqs enabled
+ '.' acquired while irqs disabled and not in irq context
+ '-' acquired in irq context
+ '+' acquired with irqs enabled
'?' acquired in irq context with irqs enabled.
Unused mutexes cannot be part of the cause of an error.
--
1.6.0.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-24 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-24 15:08 [PATCH] Documentation:lockdep-design: fix note of state bits tom.leiming
2009-04-24 15:10 tom.leiming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.