All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] prune-packed: advanced progress even for non-existing fan-out directories
@ 2009-04-27  7:44 Johannes Sixt
  0 siblings, 0 replies; only message in thread
From: Johannes Sixt @ 2009-04-27  7:44 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List, Johannes Sixt

A progress indicator is used to count through the 256 object fan-out
directories while unused object files are removed. (However, it becomes
visible only if this process takes long enough.)

Previously, display_progress() was only called if object files were
actually removed. But if directories towards the end (fd/, fe/, ff/) did
not exist, this could leave a strange line

   Removing duplicate objects:  99% (255/256), done.

in the terminal instead of the expected "100% (256/256)".

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 builtin-prune-packed.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/builtin-prune-packed.c b/builtin-prune-packed.c
index 2d5b2cd..4942892 100644
--- a/builtin-prune-packed.c
+++ b/builtin-prune-packed.c
@@ -55,6 +55,7 @@ void prune_packed_objects(int opts)
 	for (i = 0; i < 256; i++) {
 		DIR *d;
 
+		display_progress(progress, i + 1);
 		sprintf(pathname + len, "%02x/", i);
 		d = opendir(pathname);
 		if (!d)
-- 
1.6.3.rc1.88.g1bf9

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-27  7:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-27  7:44 [PATCH] prune-packed: advanced progress even for non-existing fan-out directories Johannes Sixt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.