All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm: discard masking checking when initial MSI-X entries
@ 2009-05-05  3:41 Sheng Yang
  2009-05-15  1:59 ` Sheng Yang
  2009-05-18  8:27 ` Avi Kivity
  0 siblings, 2 replies; 3+ messages in thread
From: Sheng Yang @ 2009-05-05  3:41 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm, Sheng Yang

This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
otherwise QEmu only counts the MSI-X entries, but won't fill it...

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 hw/device-assignment.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 0a5f850..bee0bd8 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
         if (entries_nr >= msix_nr.entry_nr)
             break;
         memcpy(&msg_ctrl, va + i * 16 + 12, 4);
-        if (msg_ctrl & 0x1)
-            continue;
         memcpy(&msg_data, va + i * 16 + 8, 4);
         if (msg_data == 0)
             continue;
-- 
1.5.4.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kvm: discard masking checking when initial MSI-X entries
  2009-05-05  3:41 [PATCH] kvm: discard masking checking when initial MSI-X entries Sheng Yang
@ 2009-05-15  1:59 ` Sheng Yang
  2009-05-18  8:27 ` Avi Kivity
  1 sibling, 0 replies; 3+ messages in thread
From: Sheng Yang @ 2009-05-15  1:59 UTC (permalink / raw)
  To: kvm; +Cc: Avi Kivity

On Tuesday 05 May 2009 11:41:55 Sheng Yang wrote:
> This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
> otherwise QEmu only counts the MSI-X entries, but won't fill it...
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  hw/device-assignment.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 0a5f850..bee0bd8 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice
> *pci_dev) if (entries_nr >= msix_nr.entry_nr)
>              break;
>          memcpy(&msg_ctrl, va + i * 16 + 12, 4);
> -        if (msg_ctrl & 0x1)
> -            continue;
>          memcpy(&msg_data, va + i * 16 + 8, 4);
>          if (msg_data == 0)
>              continue;

Avi?

-- 
regards
Yang, Sheng

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kvm: discard masking checking when initial MSI-X entries
  2009-05-05  3:41 [PATCH] kvm: discard masking checking when initial MSI-X entries Sheng Yang
  2009-05-15  1:59 ` Sheng Yang
@ 2009-05-18  8:27 ` Avi Kivity
  1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2009-05-18  8:27 UTC (permalink / raw)
  To: Sheng Yang; +Cc: kvm

Sheng Yang wrote:
> This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
> otherwise QEmu only counts the MSI-X entries, but won't fill it...
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-05-18  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-05  3:41 [PATCH] kvm: discard masking checking when initial MSI-X entries Sheng Yang
2009-05-15  1:59 ` Sheng Yang
2009-05-18  8:27 ` Avi Kivity

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.