[Qemu-devel] [PATCH] Use qemu_malloc & qemu_free instead of malloc & free

[Qemu-devel] [PATCH] Use qemu_malloc & qemu_free instead of malloc & free

[vibisreenivasan]

	Use qemu_malloc & qemu_free instead of malloc & free

Signed-off-by: vibi <vibi_sreenivasan@cms.com>
---
 qemu-sockets.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/qemu-sockets.c b/qemu-sockets.c
index 4111f82..f918dc0 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -329,7 +329,7 @@ int unix_listen(const char *str, char *ostr, int
olen)
     opts = strchr(str, ',');
     if (opts) {
         len = opts - str;
-        path = malloc(len+1);
+        path = qemu_malloc(len+1);
         snprintf(path, len+1, "%.*s", len, str);
     } else
         path = strdup(str);
@@ -365,11 +365,11 @@ int unix_listen(const char *str, char *ostr, int
olen)
 
     if (sockets_debug)
         fprintf(stderr, "bind(unix:%s): OK\n", un.sun_path);
-    free(path);
+    qemu_free(path);
     return sock;
 
 err:
-    free(path);
+    qemu_free(path);
     closesocket(sock);
     return -1;
 }
-- 
1.6.0

Re: [Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free

[vibisreenivasan]

hi Gred,
	Thanks for pointing that out.
	I will update patch & send it again.
regards
vibi

On Tue, 2009-05-05 at 14:50 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> > -        path = malloc(len+1);
> > +        path = qemu_malloc(len+1);
> >           snprintf(path, len+1, "%.*s", len, str);
> >       } else
> >           path = strdup(str);
> 
> You need s/strdup/qemu_strdup/ here (and maybe elsewhere too), otherwise 
> you'll mix strdup + qemu_free().
> 
> cheers,
>    Gerd
> 
> 

Re: [Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free

[Gerd Hoffmann]

   Hi,

> -        path = malloc(len+1);
> +        path = qemu_malloc(len+1);
>           snprintf(path, len+1, "%.*s", len, str);
>       } else
>           path = strdup(str);

You need s/strdup/qemu_strdup/ here (and maybe elsewhere too), otherwise 
you'll mix strdup + qemu_free().

cheers,
   Gerd

[Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free

[vibisreenivasan]

Use qemu_malloc & qemu_free instead of malloc & free

Signed-off-by: vibi <vibi_sreenivasan@cms.com>
---
 qemu-sockets.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/qemu-sockets.c b/qemu-sockets.c
index 4111f82..f918dc0 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -329,7 +329,7 @@ int unix_listen(const char *str, char *ostr, int
olen)
     opts = strchr(str, ',');
     if (opts) {
         len = opts - str;
-        path = malloc(len+1);
+        path = qemu_malloc(len+1);
         snprintf(path, len+1, "%.*s", len, str);
     } else
         path = strdup(str);
@@ -365,11 +365,11 @@ int unix_listen(const char *str, char *ostr, int
olen)
 
     if (sockets_debug)
         fprintf(stderr, "bind(unix:%s): OK\n", un.sun_path);
-    free(path);
+    qemu_free(path);
     return sock;
 
 err:
-    free(path);
+    qemu_free(path);
     closesocket(sock);
     return -1;
 }
-- 
1.6.0