[PATCH 1/3] bnx2x: free workqueue when driver fail to register

* [PATCH 1/3] bnx2x: free workqueue when driver fail to register
@ 2009-05-06  9:22 Stanislaw Gruszka
  2009-05-06 12:04 ` Eilon Greenstein
  0 siblings, 1 reply; 3+ messages in thread
From: Stanislaw Gruszka @ 2009-05-06  9:22 UTC (permalink / raw)
  To: netdev; +Cc: Eilon Greenstein

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/bnx2x_main.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index ad5ef25..ff2d9f6 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -11412,13 +11412,20 @@ static struct pci_driver bnx2x_pci_driver = {
 
 static int __init bnx2x_init(void)
 {
+	int ret;
+
 	bnx2x_wq = create_singlethread_workqueue("bnx2x");
 	if (bnx2x_wq == NULL) {
 		printk(KERN_ERR PFX "Cannot create workqueue\n");
 		return -ENOMEM;
 	}
 
-	return pci_register_driver(&bnx2x_pci_driver);
+	ret = pci_register_driver(&bnx2x_pci_driver);
+	if (ret) {
+		printk(KERN_ERR PFX "Cannot register driver\n");
+		destroy_workqueue(bnx2x_wq);
+	}
+	return ret;
 }
 
 static void __exit bnx2x_cleanup(void)
-- 
1.5.5.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread